Skip to content

GitLab

A
arduino-cli
Switch branch/tag
  1. 08 Aug, 2024 1 commit
    • Cristian Maglie's avatar
      [skip-changelog] Made the `Debug*` gRPC API implementation in par with the rest (#2672) · 5f010004
      Cristian Maglie authored 
      * Inlined gRPC methods to implement GetDebugConfig and IsDebugSupported

* Inlined function

* Renamed vars for clarity

* Added Debug gRPC adapter function

* Moved function and removed useless file

* Forward os.interrupt (aka CTRL-C) signal to the gdb process

This a challenging problem because we must wait on both an io.Read(...)
and a channel-read but, unfortunately, go native select can wait only on
channels.
To overcome this limitation I had to resort to a conditional variable and
write some boilerplate code to make everything synchronized.
      5f010004
  3. 02 Aug, 2024 1 commit
  5. 31 Jul, 2024 3 commits
    • Cristian Maglie's avatar
      fix: Ensure calls to BoardListWatch gRPC correctly release resources (#2681) · faa63596
      Cristian Maglie authored
      faa63596
    • Cristian Maglie's avatar
      [skip-changelog] Correctly remove unneded artifacts (#2682) · 43598fc8
      Cristian Maglie authored 
      The previous 'name' value `${{ env.CONFIGURATIONS_ARTIFACT }}` would not
match the name of the produced intermediate artifacts.
The correct pattern is `${{ env.CONFIGURATIONS_ARTIFACT }}-*`.
      43598fc8
    • Cristian Maglie's avatar
      [skip-changelog] Update artifact-related actions (#2679) · cbec8711
      Cristian Maglie authored 
      * Updated check-go-dependency workflow

In this case we should be fine since there is just one job that uploads
the artifacts.

* Updated publish-go-tester workflow

In this case the uploaded artifacts uses different paths and names,
there should be no breaking changes.

* Updated publish-go-nightly job

In this case the jobs exploited the previous action behaviour when
uploading multiple artifacts under the same "name".
To upgrade to v4 we need to upload artifacts with unique "name" and
merge them when downloading using the "pattern" property.

* Updated release-go job

This job got the same changes made in the publish-go-nightly job.

* Updated sync-label job

* Updated test-go job

* Updated comments

* Missed matrix run in sync-labels workflows.

* Missed double-matrix run in test-go workflow
      cbec8711
  7. 30 Jul, 2024 1 commit
  9. 29 Jul, 2024 1 commit
    • per1234's avatar
      Document breaking change to `config get` command output (#2676) · 82f60c62
      per1234 authored 
      * Correct typo in Upgrading docs

* Document breaking change to `config get` command output

Previously, the `config dump` CLI command returned the effective configuration, including both the values explicitly set
via the configuration file and environment variables as well as the values provided by defaults.

It was changed to only return the explicitly set configuration data. The breaking change was not documented at that time.
      82f60c62
  11. 26 Jul, 2024 1 commit
  13. 23 Jul, 2024 1 commit
  15. 19 Jul, 2024 1 commit
  17. 18 Jul, 2024 2 commits
  19. 12 Jul, 2024 1 commit
  21. 10 Jul, 2024 2 commits
  23. 02 Jul, 2024 1 commit
  25. 28 Jun, 2024 1 commit
    • per1234's avatar
      [skip changelog] Correct format of `upload_port` identification properties in snippet (#2655) · 7a4f716b
      per1234 authored 
      The platform developer can associate port properties with a board definition in order to cause Arduino CLI to identify
ports having those properties as that board.

The list format is supported for these platform properties in order to allow multiple alternative port property sets to
be associated. The platform property must have the format `upload_port.n.<property ID>` (where "n" is the array index of
the port property set).

Although the platform property format is correctly documented in the Arduino Platform Specification, an incorrect format
`upload_port.<property ID>.n` was previously used in the boards.txt snippet illustrating the use of the platform
properties.
      7a4f716b
  27. 27 Jun, 2024 1 commit
  29. 24 Jun, 2024 1 commit
    • Cristian Maglie's avatar
      regression: allow `monitor` to not require to specify the board if the port... · 850f22a8
      Cristian Maglie authored 
      regression: allow `monitor` to not require to specify the board if the port cannot be identified. (#2647)

* Allow default monitor settings if board can't be detected

* Improved messages at monitor startup

* Moving variable near their usage location

* Do not show warnings if the configs are provided by the user

* Added a couple of examples in the help
      850f22a8
  31. 20 Jun, 2024 1 commit
  33. 18 Jun, 2024 1 commit
  35. 17 Jun, 2024 2 commits
  37. 14 Jun, 2024 1 commit
  39. 12 Jun, 2024 3 commits
  41. 05 Jun, 2024 2 commits
  43. 30 May, 2024 1 commit
  45. 29 May, 2024 1 commit
  47. 22 May, 2024 1 commit
    • Cristian Maglie's avatar
      [skip-changelog] Added more lint checks and fixed some warnings. (#2610) · dc13ef64
      Cristian Maglie authored 
      * Enabled more checks in golangci-lint

* Removed unreachable code (impossible condition detected by linter)

internal/arduino/sketch/sketch.go:108:14: nilness: impossible condition: non-nil == nil (govet)
        if mainFile == nil {
                    ^

* Removed function alias for i18n.Tr

This allows a deeper lint-check of printf style functions, like:

  commands/instances.go:344:46: printf: github.com/arduino/arduino-cli/internal/i18n.Tr format %v reads arg #1, but call has 0 args (govet)
		s := status.Newf(codes.FailedPrecondition, i18n.Tr("Loading index file: %v"), err)

* Fixed a lot of i18n.Tr formatting errors

This commit fixes invalid calls to i18n.Tr.

1. Missing positional arguments, for example:

  return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s"), tool, err)

in the above case the positional arguments must be part of the Tr call:

-    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s"), tool, err)
+    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))

2. This also makes the fmt.Errorf call useless and it could be replaced by
the less expensive errors.New:

-    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))
+    return errors.New(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))

but we have cases of useless calls even when the string is a constant,
for example:

-    err := fmt.Errorf(i18n.Tr("no instance specified"))
+    err := errors.New(i18n.Tr("no instance specified"))

Unfortunately, this imperfection is not detected by the linter.

3. The "%w" directive is not supported directly in i18n.Tr, so we have
   to wrap it around another fmt.Errorf:

-    return nil, fmt.Errorf(i18n.Tr("reading library headers: %w"), err)
+    return nil, fmt.Errorf("%s: %w", i18n.Tr("reading library headers"), err)

* Removed useless call to i18n.Tr
      dc13ef64
  49. 21 May, 2024 1 commit
  51. 20 May, 2024 1 commit
  53. 17 May, 2024 1 commit
  55. 16 May, 2024 2 commits
  57. 15 May, 2024 3 commits