1. 12 Jun, 2022 4 commits
  2. 07 Jun, 2022 1 commit
  3. 30 May, 2022 3 commits
  4. 27 May, 2022 12 commits
    • Michael Ammann's avatar
      CTS / RTS pins were swapped in this API (#6816) · 54841295
      Michael Ammann authored
      espressif/esp-idf / components/driver/include/driver/uart.h defines the API:
      esp_err_t uart_set_pin(uart_port_t uart_num, int tx_io_num, int rx_io_num, int **rts_io_num**, int **cts_io_num**);
      uartSetPins uses that api but alls it with swapped CTS/RTS pins as its API uses a different pin ordering: 
      uart_set_pin(uart->num, txPin, rxPin, **ctsPin**, **rtsPin**); 
      
      This fixes the wrong order in the function uartSetPins
      54841295
    • Maximilian Gerhardt's avatar
    • Maximilian Gerhardt's avatar
    • Earle F. Philhower, III's avatar
      Remove -Wextra warnings (#6782) · 99ba0e1c
      Earle F. Philhower, III authored
      When building the core with `-Wextra` a few locations have `case:`
      fall throughs or skipped field initializers.
      
      Add proper comments for B64 cases to avoid GCC warnings
      
      Initialized unused fields in Tone and WiFiGeneric to avoid missing
      field initializer warnings.
      
      ````
      2022-05-19T17:40:42.2280300Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c: In function 'base64_decode_block_signed':
      2022-05-19T17:40:42.2282122Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:42:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
      2022-05-19T17:40:42.2283247Z          *plainchar    = (fragment & 0x03f) << 2;
      2022-05-19T17:40:42.2284240Z          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      2022-05-19T17:40:42.2285087Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:43:7: note: here
      2022-05-19T17:40:42.2285435Z        case step_b:
      2022-05-19T17:40:42.2285691Z        ^~~~
      2022-05-19T17:40:42.2286515Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:53:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
      2022-05-19T17:40:42.2286932Z          *plainchar    = (fragment & 0x00f) << 4;
      2022-05-19T17:40:42.2287219Z          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      2022-05-19T17:40:42.2287609Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:54:7: note: here
      2022-05-19T17:40:42.2287909Z        case step_c:
      2022-05-19T17:40:42.2288200Z        ^~~~
      2022-05-19T17:40:42.2288972Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:64:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
      2022-05-19T17:40:42.2289491Z          *plainchar    = (fragment & 0x003) << 6;
      2022-05-19T17:40:42.2289745Z          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      2022-05-19T17:40:42.2290162Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:65:7: note: here
      2022-05-19T17:40:42.2290509Z        case step_d:
      2022-05-19T17:40:42.2290714Z        ^~~~
      2022-05-19T17:40:42.2482744Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c: In function 'base64_encode_block':
      2022-05-19T17:40:42.2484713Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:46:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
      2022-05-19T17:40:42.2485415Z              result = (fragment & 0x003) << 4;
      2022-05-19T17:40:42.2486713Z              ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      2022-05-19T17:40:42.2487696Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:47:9: note: here
      2022-05-19T17:40:42.2488519Z          case step_B:
      2022-05-19T17:40:42.2489175Z          ^~~~
      2022-05-19T17:40:42.2492458Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:56:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
      2022-05-19T17:40:42.2493351Z              result = (fragment & 0x00f) << 2;
      2022-05-19T17:40:42.2494227Z              ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      2022-05-19T17:40:42.2496324Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:57:9: note: here
      2022-05-19T17:40:42.2496937Z          case step_C:
      2022-05-19T17:40:42.2497261Z          ^~~~
      2022-05-19T17:40:44.6354962Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void setToneChannel(uint8_t)':
      2022-05-19T17:40:44.6356417Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::pin' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6357120Z      };
      2022-05-19T17:40:44.6358732Z      ^
      2022-05-19T17:40:44.6364470Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::frequency' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6367914Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::duration' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6372875Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void noTone(uint8_t)':
      2022-05-19T17:40:44.6373943Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::frequency' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6375154Z      };
      2022-05-19T17:40:44.6375825Z      ^
      2022-05-19T17:40:44.6379852Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::duration' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6383291Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::channel' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6388688Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void tone(uint8_t, unsigned int, long unsigned int)':
      2022-05-19T17:40:44.6389829Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:128:5: warning: missing initializer for member 'tone_msg_t::channel' [-Wmissing-field-initializers]
      2022-05-19T17:40:44.6390677Z      };
      2022-05-19T17:40:44.6391420Z      ^
      2022-05-19T17:42:00.6768353Z /home/runner/arduino_ide/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.cpp: In static member function 'static bool WiFiGenericClass::setDualAntennaConfig(uint8_t, uint8_t, wifi_rx_ant_t, wifi_tx_ant_t)':
      2022-05-19T17:42:00.6769293Z /home/runner/arduino_ide/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.cpp:1333:5: warning: missing initializer for member 'wifi_ant_config_t::rx_ant_default' [-Wmissing-field-initializers]
      2022-05-19T17:42:00.6769658Z      };
      2022-05-19T17:42:00.6769824Z      ^
      ````
      99ba0e1c
    • sonictl's avatar
      Update littlefsbuilder.py (#6774) · d32d70dc
      sonictl authored
      add a comment to make it clear, since platformIO still creating the `spiffs.bin` for filesystem image. The file name `spiffs.bin` is so much CONFUSING! it makes the user fill the LittleFS creating is fail.
      d32d70dc
    • Abdelatif Guettouche's avatar
      6b93a6c2
    • sweetlilmre's avatar
      Fix timerAttachInterrupt() and timerDetachInterrupt() in esp32-hal-timer.c (#6763) · f9423ab8
      sweetlilmre authored
      * Fix timerAttachInterrupt() and timerDetachInterrupt() for migration to IDF 4.4
      
      * Fixing log messages as per request
      f9423ab8
    • Michael Ammann's avatar
      reduce stack size requirement for this library by 4k my moving a buffer to heap. (#6745) · e5913c36
      Michael Ammann authored
      Better allocate the buffer for f_mkfs from the heap otherwise the stack requirement of this library is huge due to a work buffer allocated for f_mkfs in sdcard_mount. The work buffer is only needed if argument format_if_empty is set true (which is by default false). 
      This change is quite important if you plan to use this library in a task. as now it increased the tasks stacks size by 4k, even this memory is never used if users are not aware of the large stack requirement during init this library may have other variables on stack that would have written memory outsides its range which can cause various side effects.
      Co-authored-by: default avatarJan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
      e5913c36
    • h-actsafe's avatar
      BluetoothSerial : Re-set _isRemoteAddressSet to false if connect() fails. (#6728) · 247bca8b
      h-actsafe authored
      The internal _isRemoteAddressSet variable is set to true
      when calling connect() functions. If connecting fails _isRemoteAddressSet
      needs to be re-set to false, otherwise other functions, such as
      discover() will fail without clear error messages.
      247bca8b
    • Rotzbua's avatar
      Doc: remove specific mention of wifi encryption... (#6671) · 46a026a4
      Rotzbua authored
      ... as availability depends on compilation parameters.
      46a026a4
    • Jan Procházka's avatar
      adc fixes and improvements (#6799) · 2cb664ee
      Jan Procházka authored
      Fixed channel / unit selection for ESP32C3 (has only 5 channels on 1 adc unit).
      
      Removed unnecessary includes.
      
      Fixed different attenuation on channels to be taken in care in __analogReadMilliVolt.
      
      All chips in __analogReadMilliVolts now use adc characteristics + calculation from raw to voltage as ESP32 does.
      2cb664ee
    • Rodrigo Garcia's avatar
      adds verbose message for WPA3 (#6812) · 2cde553e
      Rodrigo Garcia authored
      2cde553e
  5. 25 May, 2022 1 commit
  6. 19 May, 2022 1 commit
  7. 18 May, 2022 2 commits
  8. 16 May, 2022 2 commits
  9. 13 May, 2022 3 commits
  10. 11 May, 2022 5 commits
  11. 10 May, 2022 1 commit
  12. 09 May, 2022 5 commits
    • Kostis Anagnostopoulos's avatar
      fix: compiler warnings about printf-format for pointers in `esp32-hal-cpu.c` (#6705) · 70902999
      Kostis Anagnostopoulos authored
      * fix(hal.cpu) compiler warn about printf-format for pointers >
      
      warning was:
      ```
      framework-arduinoespressif32/cores/esp32/esp32-hal-cpu.c:132:9: note: in expansion of macro 'log_e'
               log_e("not found func=%08X arg=%08X",cb,arg);
               ^~~~~
      framework-arduinoespressif32/tools/sdk/esp32/include/log/include/esp_log.h:276:27: warning: format '%X' expects argument of type 'unsigned int', but argument 7 has type 'void *' [-Wformat=]
      
      ```
      
      * fix(tone.cpp) compiler warn about printf-format for pointers >
      
      format-str expected plain uint while `duration` is long-uint.
      
      Warning was:
      ```
      .../cores/esp32/esp32-hal-log.h:115:32: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
       #define log_d(format, ...) do {ESP_LOG_LEVEL_LOCAL(ESP_LOG_DEBUG, TAG, format, ##__VA_ARGS__);}while(0)
                                      ^~~~~~~~~~~~~~~~~~~
      .../cores/esp32/Tone.cpp:31:9: note: in expansion of macro 'log_d'
               log_d("Task received from queue TONE_START: _pin=%d, frequency=%u Hz, duration=%u ms", tone_msg.pin, tone_msg.frequency, tone_msg.duration);
               ^~~~~
      .../tools/sdk/esp32/include/log/include/esp_log.h:276:27: warning: format '%u' expects argument of type 'unsigned int', but argument 8 has type 'long unsigned int' [-Wformat=]
      ```
      70902999
    • smarq8's avatar
      fixing beginTransaction() thread safety (#6425) · bdeef89c
      smarq8 authored
      bdeef89c
    • Tomáš Pilný's avatar
      Added compiler.warning_flags to platform.txt; fixing #6118 (#6596) · ca77502c
      Tomáš Pilný authored
      Summary
      
      Added compiler.warning_flags to all chips in platform.txt to reflect users setting of warning level output during compilation (set up in Arduino IDE preferences)
      
      Impact
      
      When a warning is set to none the compilation will no longer display warnings
      
      Related links
      
      Solves issue #6118
      ca77502c
    • Jan Procházka's avatar
      Changed pinMode() default interrupt type DISABLED to previously set (#6695) · d3020912
      Jan Procházka authored
      * Changed in pinMode() default  intr_type
      
      pins default configuration has intr_type =  GPIO_INTR_DISABLE
      With this implementation, it will set the intr_type to previously set intr_type. It will no longer disable interrupt, when pinmode is called multiple times on same pin with interrupt enabled.
      d3020912
    • Abdelatif Guettouche's avatar
      hil.yml: Run the Event-file job only when the PR is labeled or the (#6717) · 5dc4226c
      Abdelatif Guettouche authored
      Workflow is scheduled.
      
      It looks like the depedency on the Test job was not enough and the Event
      job was triggering even without the label.
      Signed-off-by: default avatarAbdelatif Guettouche <abdelatif.guettouche@espressif.com>
      5dc4226c