GitLab

The reason why it was originally introduced:
https://github.com/arduino/Arduino/pull/2709/commits/a6909bdb49d99253b4e684365e72e5dce31a49a7

Why we are removing it now?
* Windows does preserve the state of the RTS/DTR bits on successive
  opening of the serial port.
* The serial library used in the Arduino IDE 1.8.x has a bug when trying
  to set DTR=false, on successive opening of the port the DTR line is
  set back high by the USB serial driver. This works differently from
  the serial library we use in the Arduino CLI, that sets DTR=false for
  good and this change is preserved on the successive opening of the
  port.
* Having the serial port left in a state with DTR=false may cause
  problems to tools uploading later.

It may probably completely removed, but for now, to reduce the testing
surface, it will be disabled only for Windows.

* Add DeleteRequest and DeleteResponse to gRPC

* Add Delete command to settings

* Add TestDelete to settings_test.go

* Remove temporary directory when TestWrite ends

* Refactor `config delete` command using gRPC function call

* Made `inventory` package private.

* If an error occurs reading the inventory.xml just log it and replace it.

* Added integration test

* Set `Platform.Intalled` to the installed release

* Test that the json output contains `installed`

* Align `board list --watch` and `board list` json output

* Update docs

* Fix failing board tests after package index updates

* Remove duplicate test

* Exclude sketch names ending with a dot

* Fail with error if a reserved name is used as sketch name

* Update sketch name specifications in docs

* Remove some direct access to sketch.Sketch

* Moved `LoadSketch` command in the proper place

* Removed some accesses to sketch.Sketch

The required information are returned from LoadSketch.

* Added SetSketchDefaults gRPC call

This allows to finally remove wrong access to `sketch.Sketch` from `cli`
package.

* Updated docs

* Fixed integration tests

* Update rpc/cc/arduino/cli/commands/v1/commands.proto
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

---------
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

* Created core.PlatformList implementaion follow gRPC naming

Previously it was named GetPlatforms with a different return type than
the one defined in gRPC API .proto files.

* Added test for #1529

* Perform first-update automatically in gRPC Init

* Made cli.instance.Create function private

* Extract function to compute index file name

* Auto-download 3rd party indexes as part of the Init

* fix wrong type assertion

* use feedback.Fatal otherwise it won't flush the stdout as json format

* use feedback.PrintResult instead of using fatal

* use errors.As in case in the future the err coming from PlatformUpgrade might be wrapped

errors.As search through all the wrapped error for our target type, in case it finds it then it popolate that struct but more important we can use it as a type assertion even if is nested through many errors

* Deprecate `query` in favor of `search_args`

* Give priority to `search_args` if possible

* Added integration test

* Fixed panic in upload tool selection

* Factored a method in library.List

* Fixed lint check

* Moved ResolveLibrary function in the correct source file

* Rename variable 'includes' -> 'includeFolders'

* Rename variables to use snakeCase (golang idiomatic)

* Rename variable 'include' -> 'missingIncludeH'

* Use pointers for SourceFile queues

* Clean up implementation of UniqueSourceFileQueue

* upgrade protoc to v23.2
* protoc-gen-go to v1.30.0
* protoc-gen-go-grpc to v1.3.0
* bump buf tooling to v1.20.0
* bump grpc and protobuf go deps

* Moved CTags parser out of legacy

* Moved CTags preprocess subroutine in proper place

* Factored all c++ source lines parsers

* Removed useless builderCtx field SketchSourceAfterCppPreprocessing

* Removed useless builderCtx field SketchSourceAfterArduinoPreprocessing

* Removed useless builderCtx field SketchSourceMerged

* Moved ctag preprocessor into proper location

* Moved ctags parser shenanigans into `internal` package

* Fixed linter warnings

* Simplified GCCPreprocRunner function

* Renamed variable

* Removed dependency on builder ctx in GCCPreprocRunner

* Moved GCCPreprocRunner into proper place

* Replaced algorithm with stdlib equivalent

* Reduced public API surface of CTags parser

* Renamed variable for lint checks

* Converted CTagsRunner into a function

* Removed useless tasks from ctags_runner test

* Simplified ctags_runner test

* Removed some ctags related fields from builder context

The last piece in RunCTags:

 	parser := &ctags.CTagsParser{}
 	parser.Parse(ctagsStdout, sketch.MainFile)
 	parser.FixCLinkageTagsDeclarations()

 	prototypes, line := parser.GeneratePrototypes()
 	if line != -1 {
 		prototypesLineWhereToInsert = line
 	}

has been moved at the beginning of PrototypesAdder.
RunCTags now returns the output of ctags instead of `prototypes` and `line`.
This also allows to remove the context variables that keeps those
information.

* Simplified RunCTags / factored test subroutine

* Removed DebugPreprocessor from builder ctx

* Added executils.RunAndCaptureOutput

* Moved RunCTags out of legacy package

* bump setup protoc to v2

* bump protoc-gen-go-grpc to 1.2.0

* check for compile diffs

* Upgrade relaxed-semver library to version 0.10.2

* Added integration test

* Movec ctags-related structs in ctags package

* Unified GCCPreprocRunner* functions

There is no need to duplicate a function that basically does the same
thing.

* Added implementation of functional algorithms

(until they are available in the golang standard library...)

* legacy: use generic algos where possibile

* Removed useless call to FilterSketchSource

* Converted AddPrototypes into a function

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This is obtained through the upgrade of the 'extract' library.

Upstream patch: https://github.com/codeclysm/extract/pull/21

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* legacy: Removed ReadFileAndStoreInContext command

* ctags parser.Parse signature change

* removing ctags-related data from builder ctx (part 1)

* removing ctags-related data from builder ctx (part 2)

* removing ctags-related data from builder ctx (part 3)

* Clearly separate Source code processing phases

* Removed Command wrapper from ContainerMergeCopySketchFiles

* Moved builder.CopySketchFilesToBuildPath into proper location

* Converted FilterSketchSource into a function

* Moved a couple of functions in the proper builder package

* Fixed lint error

* Load indexes first

* add new props to Index and Platform to understand if the platform is globally indexed

* add the new fields in the protobuf api

* generate protobuf stuff

* add the new fields in the PlatformReleaseToRPC mapping

* return the Platform struct from the PlatformUpgrade commands

* update the PlatformUpgrade daemon

* add the new props in the boards.ListAll func

* add the new props in the boards.Search func

* fix CR

* Use json output in test

* Fixed integration test

The dependency has been updated, previously it was downloaded the version
3.3.1, but at the moment the new dependency is 3.4.0.
This fix makes the test independent from such changes.

* Force serial-port-waiting in some uploads without port

* Updated upload-mock integration tests

* Force 'default' protocol if no port is specified in gRPC Upload

* Bump go-win32-utils dependency

* Update license metadata

Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 9.4 to 10.0.
- [Release notes](https://github.com/facelessuser/pymdown-extensions/releases)
- [Commits](https://github.com/facelessuser/pymdown-extensions/compare/9.4...10.0)

---
updated-dependencies:
- dependency-name: pymdown-extensions
  dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[skip-changelog] Verify installation of builtin tools by checking that their executable is present (#2168)

* Update previously written tests

* Verify builtin tools are correctly installed