Skip to content

GitLab

A
arduino-cli
Switch branch/tag
  1. 26 Jul, 2024 1 commit
  3. 23 Jul, 2024 1 commit
  5. 19 Jul, 2024 1 commit
  7. 18 Jul, 2024 2 commits
  9. 12 Jul, 2024 1 commit
  11. 10 Jul, 2024 2 commits
  13. 02 Jul, 2024 1 commit
  15. 28 Jun, 2024 1 commit
    • per1234's avatar
      [skip changelog] Correct format of `upload_port` identification properties in snippet (#2655) · 7a4f716b
      per1234 authored 
      The platform developer can associate port properties with a board definition in order to cause Arduino CLI to identify
ports having those properties as that board.

The list format is supported for these platform properties in order to allow multiple alternative port property sets to
be associated. The platform property must have the format `upload_port.n.<property ID>` (where "n" is the array index of
the port property set).

Although the platform property format is correctly documented in the Arduino Platform Specification, an incorrect format
`upload_port.<property ID>.n` was previously used in the boards.txt snippet illustrating the use of the platform
properties.
      7a4f716b
  17. 27 Jun, 2024 1 commit
  19. 24 Jun, 2024 1 commit
    • Cristian Maglie's avatar
      regression: allow `monitor` to not require to specify the board if the port... · 850f22a8
      Cristian Maglie authored 
      regression: allow `monitor` to not require to specify the board if the port cannot be identified. (#2647)

* Allow default monitor settings if board can't be detected

* Improved messages at monitor startup

* Moving variable near their usage location

* Do not show warnings if the configs are provided by the user

* Added a couple of examples in the help
      850f22a8
  21. 20 Jun, 2024 1 commit
  23. 18 Jun, 2024 1 commit
  25. 17 Jun, 2024 2 commits
  27. 14 Jun, 2024 1 commit
  29. 12 Jun, 2024 3 commits
  31. 05 Jun, 2024 2 commits
  33. 30 May, 2024 1 commit
  35. 29 May, 2024 1 commit
  37. 22 May, 2024 1 commit
    • Cristian Maglie's avatar
      [skip-changelog] Added more lint checks and fixed some warnings. (#2610) · dc13ef64
      Cristian Maglie authored 
      * Enabled more checks in golangci-lint

* Removed unreachable code (impossible condition detected by linter)

internal/arduino/sketch/sketch.go:108:14: nilness: impossible condition: non-nil == nil (govet)
        if mainFile == nil {
                    ^

* Removed function alias for i18n.Tr

This allows a deeper lint-check of printf style functions, like:

  commands/instances.go:344:46: printf: github.com/arduino/arduino-cli/internal/i18n.Tr format %v reads arg #1, but call has 0 args (govet)
		s := status.Newf(codes.FailedPrecondition, i18n.Tr("Loading index file: %v"), err)

* Fixed a lot of i18n.Tr formatting errors

This commit fixes invalid calls to i18n.Tr.

1. Missing positional arguments, for example:

  return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s"), tool, err)

in the above case the positional arguments must be part of the Tr call:

-    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s"), tool, err)
+    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))

2. This also makes the fmt.Errorf call useless and it could be replaced by
the less expensive errors.New:

-    return fmt.Errorf(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))
+    return errors.New(i18n.Tr("installing %[1]s tool: %[2]s", tool, err))

but we have cases of useless calls even when the string is a constant,
for example:

-    err := fmt.Errorf(i18n.Tr("no instance specified"))
+    err := errors.New(i18n.Tr("no instance specified"))

Unfortunately, this imperfection is not detected by the linter.

3. The "%w" directive is not supported directly in i18n.Tr, so we have
   to wrap it around another fmt.Errorf:

-    return nil, fmt.Errorf(i18n.Tr("reading library headers: %w"), err)
+    return nil, fmt.Errorf("%s: %w", i18n.Tr("reading library headers"), err)

* Removed useless call to i18n.Tr
      dc13ef64
  39. 21 May, 2024 1 commit
  41. 20 May, 2024 1 commit
  43. 17 May, 2024 1 commit
  45. 16 May, 2024 2 commits
  47. 15 May, 2024 10 commits