GitLab

This issue is mainly seen on Windows

Fix https://github.com/arduino/arduino-cli/issues/2156

* Respect the order of menu, when computing the config options

* reduce cyclomatic complexity

* fix the comment that was referring to the wrong filename

* Removed unused class

* Replaced two accessory functions with stdlib functions

* Removed unused structs

* Replaced utils.SliceContains with stdlib function

* Added test

* Hide compile stats when using preprocess flag

* Renaming some variables for clarity

* Moved 'build.board' property generation out of legacy package

* Moved unit tests related to build properties out of legacy package

* Removed legacy TargetBoardResolver and refactored unit-tests

* Removed legacy HardwareLoader

* Factored sketch-related build properties creation

* Moved SetupBuildProperties into proper package

* Removed SetCustomBuildProperties from legacy

* Factored --show-properties cli flag parser

* Made 'board ...' command arguments variables local

* Implemented --show-properties in 'board details'

* Fixed integration test

* Print error message if `board_manager.additional_urls` contains comma separated urls

* Improve documentation regarding the usage of environment variables

* Added integration test

* Removing useless constants

* Fixed regression in core caching

* Updated tests

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added `FQBN.Clone()` method

* Slightly increased unti-test isolation

* Added `PackageManager.NormalizeFQBN()` method.

* Print FQBN in verbose compile output

* Refactored AddMissingBuildPropertiesFromParentPlatformTxtFiles

Previously the specific recipes to run CTags were added to global build
properties. Now the global build properties are not altered anymore and
the CTags-specific properties are created only to run CTags and dropped
afterward.

* Removed platform rewrite-rules functionality

* Use the correct library when a relative path is passed as `--library` value

* Add test related to the changes

* Added codecov token to solve upload issues

* Use CODECOV_TOKEN also on pull-request runs.

It requires to expose the token, this is intentional.
https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Exclude libraries with a missing `.h` file from `lib` commands

* Add TestLibListDoesNotIncludeEmptyLibraries to lib_test.go

* Add unit tests for the changes

* Update documentation

* Removed some legacy constants

* Converted PreprocessSketchArduino and ContainerAddPrototypes into functions

* Skip useless operations in legacy test

* Removed legacy 'codecomplete' implementation.

* Upgrade minimum go version to 1.20

* Updated license cache

* Implemented code coverage in integration tests

* Use gocovmerge to merge all coverage artifacts

* Fixed build error on macOS dist

The error was due to an increased git security constraints

  ...
  go: downloading github.com/xanzy/ssh-agent v0.2.1
  go: downloading gopkg.in/warnings.v0 v0.1.2
  error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
  Error: failed building for darwin/amd64: exit status 1
  failed building for darwin/amd64: exit status 1
  task: Failed to run task "dist:macOS_64bit": exit status 1

To fix this I followed the suggestion here https://github.com/elastic/golang-crossbuild/issues/232

* Before killing the daemon, try a graceful shutdown

Otherwise the process will not outut the coverage data.

* Removed legacy vid_pid field from Compile gRPC call

* Removed support for `compile --vid-pid`

Since https://github.com/arduino/arduino-cli/pull/1804 has been fixed.

Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>

[breaking] Fix: `lib list --fqbn` and `lib examples --fqbn` do not show platform bundled lib when lib of same name is installed globally (#2113)

* Added test

* Factored function to determine library compatibility

* Made ComputePriority function public

* fix: use the libraries resolution algorithm to determine library priority

* Slightly refactored 'lib list' command call

* Updated UPGRADING.md

* Added test for a similar bug in `lib examples`

See #1656

* Recover from failed builtin tools installation

* Add tests for the changes

Fixes issue #2104

The code for `internal/cli/core` and `internal/cli/lib` has been
refactored so that we can use only the `Get` functions from
`internal/cli/outdated` package and compose there composited object.

For regular text output, the new table will have some extra fields that
either for platforms or for libraries will be blank.

For JSON and YAML output, the resulting object will have the top-level
keys `platforms` and `libraries` which contain, respectively, the array
of outaded platforms and outdated libraries.
Signed-off-by: Lluís Martínez <lluis@tastaollet.es>

* Added test

* Use normalized version as keys for matching versions in maps

* Use normalized version as keys for matching versions in maps for platforms and tools

* Updated relaxed-semver to 0.10.0

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed concurrent write to variables `err` and `n`

* Fix concurrent access to p.cmd.Process

The go-routine was spawned before the process was started. This means
that p.Kill may read p.cmd.Process before it is written in p.Run.

Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Removed go.mod from client_example

* Removed go.mod from docsgen

* Refactored discovery client and removed now useless go.mod files

* Updated license cache

* Upgraded some dependencies to fix dependabot alerts

The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames.

The origin of the specification is the text of the error message shown in Arduino IDE when the user attempts to save to
a name that contains disallowed characters:

https://github.com/arduino/Arduino/blob/89539b1131f8cde9f7a83225f21c811071af53a8/app/src/processing/app/SketchController.java#L847-L853

However, the implementation of the restriction in the IDE codebase has a bug that allows a leading underscore (because
the code uses _ as the replacement character).

After the restriction was implemented correctly in Arduino IDE 2.x, it was discovered that the loss of compatibility
with these non-compliant names was impactful.

One of the primary purposes for the specification and restrictions is to ensure sketches can be used in any tool. Since
the tools support this name format and there is no technical reason to disallow it, the best thing to do is change the
sketch specification to follow the historic tool behavior (even if that behavior was the result of a benign bug).

Leading underscores in sketch folder names and sketch code filenames are hereby permitted by the Arduino Sketch
Specification and `arduino-cli sketch new`.

* Added flag to LibrarySearchRequest gRPC API to reduce response output

* Added --omit-releases-details flag in 'lib search'