Fixed a couple of (very rare) race conditions (#2112)

* Fixed concurrent write to variables `err` and `n`

* Fix concurrent access to p.cmd.Process

The go-routine was spawned before the process was started. This means
that p.Kill may read p.cmd.Process before it is written in p.Run.

arduino/monitor/monitor_test.go

@@ -74,13 +74,13 @@ func TestDummyMonitor(t *testing.T) {
 	go func() {
 		buff := [1024]byte{}
 		// Receive "TEST" echoed back
-		n, err = rw.Read(buff[:])
+		_, err := rw.Read(buff[:])
 		require.NoError(t, err)
 		require.Equal(t, 4, n)
 		require.Equal(t, "TEST", string(buff[:4]))
 
 		// Block on read until the port is closed
-		n, err = rw.Read(buff[:])
+		_, err = rw.Read(buff[:])
 		require.ErrorIs(t, err, io.EOF)
 		atomic.StoreInt32(&completed, 1) // notify completion
 	}()

executils/process.go

@@ -160,6 +160,9 @@ func (p *Process) SetEnvironment(values []string) {
 // RunWithinContext starts the specified command and waits for it to complete. If the given context
 // is canceled before the normal process termination, the process is killed.
 func (p *Process) RunWithinContext(ctx context.Context) error {
+	if err := p.Start(); err != nil {
+		return err
+	}
 	completed := make(chan struct{})
 	defer close(completed)
 	go func() {
@@ -169,6 +172,5 @@ func (p *Process) RunWithinContext(ctx context.Context) error {
 		case <-completed:
 		}
 	}()
-	res := p.cmd.Run()
-	return res
+	return p.Wait()
 }