Skip to content

GitLab

A
arduino-cli
Switch branch/tag
  1. 27 Mar, 2023 3 commits
  3. 24 Mar, 2023 1 commit
  5. 22 Mar, 2023 4 commits
  7. 17 Mar, 2023 1 commit
    • Lluis Campos's avatar
      Fix invalid JSON and YAML outputs for `outdated` command (#2111) · a8b52ea5
      Lluis Campos authored 
      Fixes issue #2104

The code for `internal/cli/core` and `internal/cli/lib` has been
refactored so that we can use only the `Get` functions from
`internal/cli/outdated` package and compose there composited object.

For regular text output, the new table will have some extra fields that
either for platforms or for libraries will be blank.

For JSON and YAML output, the resulting object will have the top-level
keys `platforms` and `libraries` which contain, respectively, the array
of outaded platforms and outdated libraries.
Signed-off-by: default avatarLluís Martínez <lluis@tastaollet.es>
      a8b52ea5
  9. 16 Mar, 2023 3 commits
  11. 15 Mar, 2023 2 commits
  13. 14 Mar, 2023 1 commit
  15. 13 Mar, 2023 2 commits
    • per1234's avatar
      Allow leading underscore in sketch filenames (#2105) · 7feb54fb
      per1234 authored 
      The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames.

The origin of the specification is the text of the error message shown in Arduino IDE when the user attempts to save to
a name that contains disallowed characters:

https://github.com/arduino/Arduino/blob/89539b1131f8cde9f7a83225f21c811071af53a8/app/src/processing/app/SketchController.java#L847-L853

However, the implementation of the restriction in the IDE codebase has a bug that allows a leading underscore (because
the code uses _ as the replacement character).

After the restriction was implemented correctly in Arduino IDE 2.x, it was discovered that the loss of compatibility
with these non-compliant names was impactful.

One of the primary purposes for the specification and restrictions is to ensure sketches can be used in any tool. Since
the tools support this name format and there is no technical reason to disallow it, the best thing to do is change the
sketch specification to follow the historic tool behavior (even if that behavior was the result of a benign bug).

Leading underscores in sketch folder names and sketch code filenames are hereby permitted by the Arduino Sketch
Specification and `arduino-cli sketch new`.
      7feb54fb
    • Cristian Maglie's avatar
      Added `--omit-releases-details` flag in `lib search` (#2102) · 71a8576d
      Cristian Maglie authored 
      * Added flag to LibrarySearchRequest gRPC API to reduce response output

* Added --omit-releases-details flag in 'lib search'
      71a8576d
  17. 10 Mar, 2023 3 commits
  19. 08 Mar, 2023 1 commit
  21. 06 Mar, 2023 1 commit
  23. 03 Mar, 2023 1 commit
  25. 02 Mar, 2023 1 commit
    • Cristian Maglie's avatar
      Refactored build-properties creation (and removed some legacy code) (#2082) · 2f5b7678
      Cristian Maglie authored 
      * Moved 'build.fqbn' and 'build.arch' properties generation

* Moved some runtime build path properties to proper function

* Factored tools runtime properties generation

* Factored subroutine for time-related properties generation

* Made the referenced-core determination a bit more readable

Equivalent change, should not change behaviour

* Factored 'build.variant' and related properties calculation

* Removed useless state variable 'BuildCore'

* Refactoring of some legacy properties generation subroutines

* Refactored generation of 'software' build property

* Refactored build properties overlaying logic

* Refactored custom global properties handling

* Moved corePlatform and variantPlatform determination inside a specific method
      2f5b7678
  27. 01 Mar, 2023 1 commit
  29. 27 Feb, 2023 3 commits
  31. 22 Feb, 2023 2 commits
  33. 21 Feb, 2023 1 commit
    • per1234's avatar
      [skip changelog] Remove comment that breaks gRPC documentation structure (#2080) · c73f7355
      per1234 authored 
      The "gPRC Reference" section of the documentation website is automatically generated from the code and comments in the
project's Protocol Buffers files. The documentation is automatically structured according to the structure of the
Protocol Buffers code using heading levels, and the documentation website uses these heading levels to generate a table
of contents to allow easy navigation of the documentation and an overview of its structure.

The generation happens in two steps:

Protocol Buffers -> Markdown -> HTML

A comment in a Protocol Buffers file included a decorative underline formed from a series of `-` characters. This
happens to be markup for an H2 heading in the Markup language. This caused an inadvertent creation of an inappropriate
heading named "BOOTSTRAP COMMANDS", which resulted in the documentation having the following incorrect structure:

- Protocol Documentation
  - [...]
  - cc/arduino/cli/commands/v1/board.proto
    - [...]
  - cc/arduino/cli/commands/v1/commands.proto
    - [...]
    - ArduinoCoreService
  - BOOTSTRAP COMMANDS
    - <List of cc.arduino.cli.commands.v1.ArduinoCoreService methods>
  - cc/arduino/cli/commands/v1/common.proto
    - [...]
  - [...]

Instead of the correct structure:

- Protocol Documentation
  - [...]
  - cc/arduino/cli/commands/v1/board.proto
    - [...]
  - cc/arduino/cli/commands/v1/commands.proto
    - [...]
    - ArduinoCoreService
      - <List of cc.arduino.cli.commands.v1.ArduinoCoreService methods>
  - cc/arduino/cli/commands/v1/common.proto
    - [...]
  - [...]

This could be corrected by removing only the pointless decorative comment, leaving the "BOOTSTRAP COMMANDS" comment, but
I don't see any value in that comment and it introduced unpleasant caps lock prose content into the documentation so I
removed it as well.
      c73f7355
  35. 20 Feb, 2023 3 commits
  37. 17 Feb, 2023 2 commits
  39. 13 Feb, 2023 2 commits
  41. 09 Feb, 2023 1 commit
  43. 08 Feb, 2023 1 commit