GitLab

* Added FAILED_INSTANCE_INIT_REASON_INDEX_DOWNLOAD_ERROR in gRPC Init errors

* Improved error reporting during Init and first-index-update

The `--config` flag of the `arduino-cli monitor` command is used to configure the communication port used by the
monitor.

Previously the command line help did not provide any guidance for the usage of this flag, which might lead the users to
wonder:

- How can the configuration options available for use via the flag be determined?
- What is the format for the configuration option argument?

The information is provided in the FAQ page of the documentation, but that is not as convenient a source of information
as the command line help and the user may not even be aware of its existence.

The command help is hereby adjusted to provide the user with this information:

- Create a conceptual linkage between the `--config` and `--describe` flags by using the "communication port settings"
  terminology in the references of both.
- Document the argument format.

In addition to the comma-separated list format I documented here, an alternative usage of passing multiple `--config`
flags is also supported. I chose the former because I felt that the descriptions of the latter in either command line
notation (e.g., `[--config <ID>=<value>]...`) or in prose (e.g., "The format is <ID>=<value>. Can be used multiple times
for multiple settings.") were less clear.

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pygments](https://github.com/pygments/pygments) from 2.12.0 to 2.15.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](https://github.com/pygments/pygments/compare/2.12.0...2.15.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add output.no_color to configuration docs

* Add output.no_color to configuration.schema.json

* feat: add priority for main

* docs: Update sketch-build-process.md

* fix: suggestion @cmaglie of priorities libraries
Co-authored-by: Cristian Maglie <c.maglie@bug.st>

* tests: implement tests of new priority 'main'

* fix: build cpp_test.go

* fix: TestClosestMatchWithTotallyDifferentNames in cpp_test.go

---------
Co-authored-by: Cristian Maglie <c.maglie@bug.st>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

The reason why it was originally introduced:
https://github.com/arduino/Arduino/pull/2709/commits/a6909bdb49d99253b4e684365e72e5dce31a49a7

Why we are removing it now?
* Windows does preserve the state of the RTS/DTR bits on successive
  opening of the serial port.
* The serial library used in the Arduino IDE 1.8.x has a bug when trying
  to set DTR=false, on successive opening of the port the DTR line is
  set back high by the USB serial driver. This works differently from
  the serial library we use in the Arduino CLI, that sets DTR=false for
  good and this change is preserved on the successive opening of the
  port.
* Having the serial port left in a state with DTR=false may cause
  problems to tools uploading later.

It may probably completely removed, but for now, to reduce the testing
surface, it will be disabled only for Windows.

* Add DeleteRequest and DeleteResponse to gRPC

* Add Delete command to settings

* Add TestDelete to settings_test.go

* Remove temporary directory when TestWrite ends

* Refactor `config delete` command using gRPC function call

* Made `inventory` package private.

* If an error occurs reading the inventory.xml just log it and replace it.

* Added integration test

* Set `Platform.Intalled` to the installed release

* Test that the json output contains `installed`

* Align `board list --watch` and `board list` json output

* Update docs

* Fix failing board tests after package index updates

* Remove duplicate test

* Exclude sketch names ending with a dot

* Fail with error if a reserved name is used as sketch name

* Update sketch name specifications in docs

* Remove some direct access to sketch.Sketch

* Moved `LoadSketch` command in the proper place

* Removed some accesses to sketch.Sketch

The required information are returned from LoadSketch.

* Added SetSketchDefaults gRPC call

This allows to finally remove wrong access to `sketch.Sketch` from `cli`
package.

* Updated docs

* Fixed integration tests

* Update rpc/cc/arduino/cli/commands/v1/commands.proto
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

---------
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

* Created core.PlatformList implementaion follow gRPC naming

Previously it was named GetPlatforms with a different return type than
the one defined in gRPC API .proto files.

* Added test for #1529

* Perform first-update automatically in gRPC Init

* Made cli.instance.Create function private

* Extract function to compute index file name

* Auto-download 3rd party indexes as part of the Init

* fix wrong type assertion

* use feedback.Fatal otherwise it won't flush the stdout as json format

* use feedback.PrintResult instead of using fatal

* use errors.As in case in the future the err coming from PlatformUpgrade might be wrapped

errors.As search through all the wrapped error for our target type, in case it finds it then it popolate that struct but more important we can use it as a type assertion even if is nested through many errors

* Deprecate `query` in favor of `search_args`

* Give priority to `search_args` if possible

* Added integration test

* Fixed panic in upload tool selection

* Factored a method in library.List

* Fixed lint check

* Moved ResolveLibrary function in the correct source file

* Rename variable 'includes' -> 'includeFolders'

* Rename variables to use snakeCase (golang idiomatic)

* Rename variable 'include' -> 'missingIncludeH'

* Use pointers for SourceFile queues

* Clean up implementation of UniqueSourceFileQueue

* upgrade protoc to v23.2
* protoc-gen-go to v1.30.0
* protoc-gen-go-grpc to v1.3.0
* bump buf tooling to v1.20.0
* bump grpc and protobuf go deps

* Moved CTags parser out of legacy

* Moved CTags preprocess subroutine in proper place

* Factored all c++ source lines parsers

* Removed useless builderCtx field SketchSourceAfterCppPreprocessing

* Removed useless builderCtx field SketchSourceAfterArduinoPreprocessing

* Removed useless builderCtx field SketchSourceMerged

* Moved ctag preprocessor into proper location

* Moved ctags parser shenanigans into `internal` package

* Fixed linter warnings

* Simplified GCCPreprocRunner function

* Renamed variable

* Removed dependency on builder ctx in GCCPreprocRunner

* Moved GCCPreprocRunner into proper place

* Replaced algorithm with stdlib equivalent

* Reduced public API surface of CTags parser

* Renamed variable for lint checks

* Converted CTagsRunner into a function

* Removed useless tasks from ctags_runner test

* Simplified ctags_runner test

* Removed some ctags related fields from builder context

The last piece in RunCTags:

 	parser := &ctags.CTagsParser{}
 	parser.Parse(ctagsStdout, sketch.MainFile)
 	parser.FixCLinkageTagsDeclarations()

 	prototypes, line := parser.GeneratePrototypes()
 	if line != -1 {
 		prototypesLineWhereToInsert = line
 	}

has been moved at the beginning of PrototypesAdder.
RunCTags now returns the output of ctags instead of `prototypes` and `line`.
This also allows to remove the context variables that keeps those
information.

* Simplified RunCTags / factored test subroutine

* Removed DebugPreprocessor from builder ctx

* Added executils.RunAndCaptureOutput

* Moved RunCTags out of legacy package

* bump setup protoc to v2

* bump protoc-gen-go-grpc to 1.2.0

* check for compile diffs

* Upgrade relaxed-semver library to version 0.10.2

* Added integration test