- 30 Jun, 2023 1 commit
-
-
Cristian Maglie authored
The reason why it was originally introduced: https://github.com/arduino/Arduino/pull/2709/commits/a6909bdb49d99253b4e684365e72e5dce31a49a7 Why we are removing it now? * Windows does preserve the state of the RTS/DTR bits on successive opening of the serial port. * The serial library used in the Arduino IDE 1.8.x has a bug when trying to set DTR=false, on successive opening of the port the DTR line is set back high by the USB serial driver. This works differently from the serial library we use in the Arduino CLI, that sets DTR=false for good and this change is preserved on the successive opening of the port. * Having the serial port left in a state with DTR=false may cause problems to tools uploading later. It may probably completely removed, but for now, to reduce the testing surface, it will be disabled only for Windows.
-
- 12 Apr, 2023 1 commit
-
-
Cristian Maglie authored
* Added integration test * Removing useless constants * Fixed regression in core caching * Updated tests
-
- 07 Apr, 2023 2 commits
-
-
Cristian Maglie authored
-
Cristian Maglie authored
-
- 05 Apr, 2023 1 commit
-
-
github-actions[bot] authored
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
-
- 31 Mar, 2023 1 commit
-
-
Cristian Maglie authored
* Added `FQBN.Clone()` method * Slightly increased unti-test isolation * Added `PackageManager.NormalizeFQBN()` method. * Print FQBN in verbose compile output
-
- 30 Mar, 2023 1 commit
-
-
Cristian Maglie authored
* Refactored AddMissingBuildPropertiesFromParentPlatformTxtFiles Previously the specific recipes to run CTags were added to global build properties. Now the global build properties are not altered anymore and the CTags-specific properties are created only to run CTags and dropped afterward. * Removed platform rewrite-rules functionality
-
- 29 Mar, 2023 3 commits
-
-
MatteoPologruto authored
* Use the correct library when a relative path is passed as `--library` value * Add test related to the changes
-
Cristian Maglie authored
* Added codecov token to solve upload issues * Use CODECOV_TOKEN also on pull-request runs. It requires to expose the token, this is intentional. https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954
-
dependabot[bot] authored
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- 28 Mar, 2023 3 commits
-
-
MatteoPologruto authored
* Exclude libraries with a missing `.h` file from `lib` commands * Add TestLibListDoesNotIncludeEmptyLibraries to lib_test.go * Add unit tests for the changes * Update documentation
-
Cristian Maglie authored
* Removed some legacy constants * Converted PreprocessSketchArduino and ContainerAddPrototypes into functions
-
MatteoPologruto authored
-
- 27 Mar, 2023 5 commits
-
-
Cristian Maglie authored
* Skip useless operations in legacy test * Removed legacy 'codecomplete' implementation.
-
Cristian Maglie authored
* Upgrade minimum go version to 1.20 * Updated license cache * Implemented code coverage in integration tests * Use gocovmerge to merge all coverage artifacts * Fixed build error on macOS dist The error was due to an increased git security constraints ... go: downloading github.com/xanzy/ssh-agent v0.2.1 go: downloading gopkg.in/warnings.v0 v0.1.2 error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. Error: failed building for darwin/amd64: exit status 1 failed building for darwin/amd64: exit status 1 task: Failed to run task "dist:macOS_64bit": exit status 1 To fix this I followed the suggestion here https://github.com/elastic/golang-crossbuild/issues/232 * Before killing the daemon, try a graceful shutdown Otherwise the process will not outut the coverage data.
-
Cristian Maglie authored
-
Cristian Maglie authored
-
Cristian Maglie authored
* Removed legacy vid_pid field from Compile gRPC call * Removed support for `compile --vid-pid`
-
- 24 Mar, 2023 1 commit
-
-
Cristian Maglie authored
Since https://github.com/arduino/arduino-cli/pull/1804 has been fixed.
-
- 22 Mar, 2023 4 commits
-
-
Luis Colorado authored
Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
-
Cristian Maglie authored
[breaking] Fix: `lib list --fqbn` and `lib examples --fqbn` do not show platform bundled lib when lib of same name is installed globally (#2113) * Added test * Factored function to determine library compatibility * Made ComputePriority function public * fix: use the libraries resolution algorithm to determine library priority * Slightly refactored 'lib list' command call * Updated UPGRADING.md * Added test for a similar bug in `lib examples` See #1656
-
MatteoPologruto authored
* Recover from failed builtin tools installation * Add tests for the changes
-
MatteoPologruto authored
-
- 17 Mar, 2023 1 commit
-
-
Lluis Campos authored
Fixes issue #2104 The code for `internal/cli/core` and `internal/cli/lib` has been refactored so that we can use only the `Get` functions from `internal/cli/outdated` package and compose there composited object. For regular text output, the new table will have some extra fields that either for platforms or for libraries will be blank. For JSON and YAML output, the resulting object will have the top-level keys `platforms` and `libraries` which contain, respectively, the array of outaded platforms and outdated libraries. Signed-off-by: Lluís Martínez <lluis@tastaollet.es>
-
- 16 Mar, 2023 3 commits
-
-
Cristian Maglie authored
* Added test * Use normalized version as keys for matching versions in maps * Use normalized version as keys for matching versions in maps for platforms and tools * Updated relaxed-semver to 0.10.0
-
dependabot[bot] authored
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Cristian Maglie authored
* Fixed concurrent write to variables `err` and `n` * Fix concurrent access to p.cmd.Process The go-routine was spawned before the process was started. This means that p.Kill may read p.cmd.Process before it is written in p.Run.
-
- 15 Mar, 2023 2 commits
-
-
Cristian Maglie authored
-
Luca Bianconi authored
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
-
- 14 Mar, 2023 1 commit
-
-
Cristian Maglie authored
* Removed go.mod from client_example * Removed go.mod from docsgen * Refactored discovery client and removed now useless go.mod files * Updated license cache * Upgraded some dependencies to fix dependabot alerts
-
- 13 Mar, 2023 2 commits
-
-
per1234 authored
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. The origin of the specification is the text of the error message shown in Arduino IDE when the user attempts to save to a name that contains disallowed characters: https://github.com/arduino/Arduino/blob/89539b1131f8cde9f7a83225f21c811071af53a8/app/src/processing/app/SketchController.java#L847-L853 However, the implementation of the restriction in the IDE codebase has a bug that allows a leading underscore (because the code uses _ as the replacement character). After the restriction was implemented correctly in Arduino IDE 2.x, it was discovered that the loss of compatibility with these non-compliant names was impactful. One of the primary purposes for the specification and restrictions is to ensure sketches can be used in any tool. Since the tools support this name format and there is no technical reason to disallow it, the best thing to do is change the sketch specification to follow the historic tool behavior (even if that behavior was the result of a benign bug). Leading underscores in sketch folder names and sketch code filenames are hereby permitted by the Arduino Sketch Specification and `arduino-cli sketch new`.
-
Cristian Maglie authored
* Added flag to LibrarySearchRequest gRPC API to reduce response output * Added --omit-releases-details flag in 'lib search'
-
- 10 Mar, 2023 3 commits
-
-
Luca Bianconi authored
-
Cristian Maglie authored
* Added integration test for #1698 * Added helper functions to handle concurrent writes to ctx.Stdout/Stderr * Do not alter ctx.Stderr/Stdout in ExecCommand Some instances of ctx.Stdout may now contains nil since it's no more altered during ExecCommand. * Handle multi-threaded compile streams
-
Cristian Maglie authored
-
- 08 Mar, 2023 1 commit
-
-
MatteoPologruto authored
[skip-changelog] Fix string indexing in `tool not available for the current os` error message (#2099)
-
- 06 Mar, 2023 1 commit
-
-
MatteoPologruto authored
* Add instructions on how to contact the package manager to error message * Add TestCoreBrokenDependency to core_test.go
-
- 03 Mar, 2023 1 commit
-
-
MatteoPologruto authored
-
- 02 Mar, 2023 1 commit
-
-
Cristian Maglie authored
* Moved 'build.fqbn' and 'build.arch' properties generation * Moved some runtime build path properties to proper function * Factored tools runtime properties generation * Factored subroutine for time-related properties generation * Made the referenced-core determination a bit more readable Equivalent change, should not change behaviour * Factored 'build.variant' and related properties calculation * Removed useless state variable 'BuildCore' * Refactoring of some legacy properties generation subroutines * Refactored generation of 'software' build property * Refactored build properties overlaying logic * Refactored custom global properties handling * Moved corePlatform and variantPlatform determination inside a specific method
-
- 01 Mar, 2023 1 commit
-
-
MatteoPologruto authored
[skip-changelog] Handle repeated builds of a sketch when `--build-path` target is in the sketch directory (#2084) * Handle repeated builds of a sketch when the build path is inside the sketch directory * Add TestCompileBuildPathInsideSketch to compile_test.go
-