- 28 Aug, 2017 4 commits
-
-
Jeffrey I. Schiller authored
During development it is common to erase the local development datastore and start over. However if the browser in use still had a valid authentication cookie (very common), a blank dialog would be displayed because the cookie resolved to a non-existent account. This change results instead with either the login page, or Google authentication being invoked (depending on configuration). Note: This code should *not* get triggered in production. Change-Id: Iafbc7c774c392d99073342c49108dc6774e715a0
-
Evan W. Patton authored
Change-Id: I0d0b6cdb0dc8b5e7360616a75d96cb18391eb8ae
-
Evan W. Patton authored
Fixes build issues on Windows where the default charset isn't UTF-8. Change-Id: I22f583eda2f000ef1dd82a672b5a0de6a4b9e7cb
-
Michael J Gallagher authored
Close #852 Change-Id: I99e8fea50b5d0632bb935183fe90c9a1b2c7bdd4
-
- 23 Aug, 2017 2 commits
-
-
Jeffrey I. Schiller authored
Includes the favicon.ico as well as the logo Change-Id: Ie05bd5e3a6a3f072c81c91d11aee60b52fe9905c
-
Evan W. Patton authored
A user reported an issue with a project where connecting the companion caused the ReplMgr to go into an infinite loop. The issue was due to a combination of setter block having an empty socket (triggering an error resulting in the slow path) and the fact that there were more than 20 top-level blocks in the project. After testing the first 20 blocks it would attempt the fast path, which would retrigger the slow path, ad infinitum. This commit updates the countdown in the slow path to use the number of top-level blocks in the workspace rather than hard-coding 20 checks. Fixes #887 Change-Id: Ie15b0f35cd145ecc0b789707f032eca6c179d107
-
- 17 Aug, 2017 3 commits
-
-
Evan W. Patton authored
Prior to the IOT release, extensions were packaged using the FQCN of the extension inside of the AIX file. To faciltate being able to contain multiple extension components in a single package, we switched to using the package name rather than the FQCN. This causes backward compatibility issues for extension developers who released extensions prior to the update. This commit adds a extensions.packagefqcn property to ant that can be set to true by developers supporting older extensions so that the internals of the extension package reflect the older layout. It is recommended that all new extensions be built with the default (false) to benefit from the new layout. Change-Id: Idd9134c7d4d7c19f9a8869e4f88e164e2efa5cc8
-
Evan W. Patton authored
ClientJsonParser was calling a GWT API that used eval() to parse JSON content rather than JSON.parse(). A maliciously crafted project containing an extension components.json file with Javascript instead of JSON would allow injecting arbitrary Javascript into the user's session. This commit switches to strict parsing and includes exception handling to report corrupt/invalid components.json to the user. Change-Id: Iafaaf004310ac45cf0c1cea18eae1cfd58de17ef
-
Evan W. Patton authored
If a project contained multiple extensions sharing the same package name, deleting one extension would also remove the other extensions sharing that package name. This generally shouldn't happen going forward because extension bundles automatically group extensions by package name (which is why this logic is in place), but it didn't handle the case where old extensions were in the same package. This commit groups extensions by the components.json file that defines them, and only deletes those extensions that are siblings by the components.json file, rather than blanket-deleting extensions solely by package name. Fixes #910 Change-Id: I26a5db29a3919033fd50f2a2d65c6f805513ae2c
-
- 15 Aug, 2017 1 commit
-
-
Jeffrey I. Schiller authored
Replace the default App Logo with our new Bee based version. Change-Id: Ibfaa3792bf29d799b253b261cd83b26e187eaa18
-
- 12 Aug, 2017 1 commit
-
-
Jeffrey I. Schiller authored
Change-Id: I16d609f13d7818a03f4de13761aaca3d1f5c40b2
-
- 11 Aug, 2017 1 commit
-
-
Jeffrey I. Schiller authored
Change-Id: Ic5f5d83e40051cfd62504196bd71f9a9781b521f
-
- 21 Jul, 2017 1 commit
-
-
Evan W. Patton authored
Taifun reported that importing many extensions of the same package name into a single project made them unable to load. This change detects this scenario and returns an error to the user preventing them from loading the conflicting extension. There is also a test to ensure that if one has two extensions in the same package and then loads a bundle containing the individually FQCN extensions the old extensions will be removed and placed with the bundled version. Change-Id: If35663d650d3a24f6c5aaeceaf490a24ac008522
-
- 18 Jul, 2017 1 commit
-
-
Jeffrey I. Schiller authored
Firefox requires that the <div> that includes the Tutorial Panel has its height set to 100%, otherwise it displays it with a height of 150px (per the CSS standard). Change-Id: Id7afd34f4aa058dd5f7b4982d6409941d472d907
-
- 08 Jul, 2017 2 commits
-
-
Jeffrey I. Schiller authored
Remove references to AI1 from the No Projects Dialog in non-English language translations. Change-Id: Ic518901c445cb65fbf6d0ac6b2abcd1276e23264
-
Jeffrey I. Schiller authored
Remove the Splash Screen Message from OdeMessages. The message now comes from the data store. The update made to take the message from the data store neglected to remove the obsolete message from OdeMessages. We remove it here. Change-Id: I1ed7e751ce4a3ab150cf4250270b0a544416e9ac
-
- 06 Jul, 2017 3 commits
-
-
Klomi authored
Change-Id: I4811755660bdcbb662f39f719b0cb7ad89b9f12f
-
Magdalena Sowder authored
Created a modal pop-up for videos and images from the tutorial. Added changes to separate file to create a new class that extends Frame. Change-Id: Ie47ce9896aefff2bcebe3cbe64fbe512a1258661
-
Katie Mathison authored
There was an issue where some generic component method blocks did not have the mutator labeling them as such. This was fixed by explicitly setting the is_generic mutator along with the other mutators when these blocks are generated in the drawer. There was another issue where generic clock add blocks expected a time unit dropdown which only exists on the instance version of the clock add blocks. This was fixed by only setting the time unit if the block is not generic, since this attribute is only used in the instance version of these blocks. Change-Id: I9fb4bee9bef9fa76e40a240b587ec0b05ba86693
-
- 05 Jul, 2017 1 commit
-
-
Jeffrey I. Schiller authored
Remove the “Beta” tag from MIT App Inventor. Also remove the “2” as well. Change-Id: Ifed997d86e13b5f59a93e736f5caee7299ca1039
-
- 04 Jul, 2017 2 commits
-
-
Jeffrey I. Schiller authored
If someone attempts to download a packaged project while a new build is running, we throw in IllegalArgumentException because the built apk is no longer present (the first thing a new build does is remove the old apk). This happens often enough that it is one of the top errors being logged by the Google Cloud Console. This change eliminates the IllegalArgumentException and instead just returns a “File Not Found” error (404 error) to the user attempting the download. Change-Id: I6fb92e51477c1ad93059cf57a449396d4fea0d7d
-
Jeffrey I. Schiller authored
Change-Id: I1166ec3b843665338e6fdd8155d1486cce23b7b7
-
- 03 Jul, 2017 2 commits
-
-
Jeffrey I. Schiller authored
Change-Id: Ic3deb5ee2bfe9ac98f3d0f64b6a98b987e2d36d6
-
Jeffrey I. Schiller authored
Update the URL to use tinywebdb.appinventor.mit.edu instead of at appspot.com. This gives us the flexibility to move the service from Google’s App Engine to a service hosted anywhere, including at MIT. Change-Id: I1f68f118e20f25740b7667b1efe93b2a1b925ce0
-
- 30 Jun, 2017 1 commit
-
-
Evan W. Patton authored
The old version of Google Voice used by the Texting component redirects to a newer version, breaking the existing functionality. This change uses a special URL redirection and cookie provided by Google to legacy Google Voice to work around the issue. This will likely break again in the future but will buy time to implement a more robust solution, likely based on a non-Google product. Change-Id: Ie519a34fde18204060bd44278f206c1d4c77034b
-
- 14 Jun, 2017 2 commits
-
-
Jeffrey I. Schiller authored
Change-Id: I110e242808fae3f32a3ae7a4627934accfffb546
-
Jeffrey I. Schiller authored
-
- 12 Jun, 2017 3 commits
-
-
Evan W. Patton authored
Fixes #888 Change-Id: Ib394778a30729c54cfdc787107e542b85cfd3a1a
-
Evan W. Patton authored
Change-Id: I62d20ee830af8f88ce816736d71ab78da90fed9d
-
Evan W. Patton authored
It was reported that deleting an extension that had been instantiated results in an "Oops! something broke" message. The issue is caused by collecting all of the sibling component types in the same package (due to extension bundles) and accidentally double-counting the extension type that triggered the deletion. This would result in an attempt to delete the same component twice resulting in an error because the component no longer existed. This commit fixes the problem by checking the sibling name against the set of to-be-removed classes to ensure that adding a sibling doesn't duplicate the original class for removal. Change-Id: Id3d5e17da4e3a5c4e8423ac32fc427cfdcd8ebdc
-
- 09 Jun, 2017 1 commit
-
-
Evan W. Patton authored
A user reported when loading an old project with a reference to the BLE component resulted in an unexpected error. This was due to the component being present in the Screen1.scm but not in the assets. This commit makes it so that looking up an undefined component will result in an error message being reported to the user indicating that the project in question cannot be loaded. Change-Id: Ida96802fd8152bf94dc2ac1f481c3acb3810a724
-
- 04 Jun, 2017 2 commits
-
-
Jeffrey I. Schiller authored
The TutorialURL will be opened in a sidebar in MIT App Inventor. This permits people to build “template” projects with a tutorial (hosted on their own site) displayed in a sidebar. For now, we only allow tutorial urls from http://appinventor.mit.edu/ or http://appinv.us/. Change-Id: Ia79eeac6bd3809ce32d0475aa3954ad2c996c776
-
Jeffrey I. Schiller authored
When running a set of buildservers behind a load balancer there is a bunching effect that can happen when one buildserver winds up with a large number of simultaneous builds while other buildservers are idle. This happens when a buildserver becomes a little busy and as a result runs slower then the other servers. This increases the likelihood that it will get more work to do while it is still working on existing jobs. Which slows it even further which results in more jobs until it hits its maximum and rejects jobs (while the other buildservers are idle!). This change results in the buildserver returning an unhealthy status to the load balancer (most load balancers can be configured to check a buildservers health periodically) after it reaches 2/3 of its maximum load. It then stays in this “DRAINING” state until the load becomes less then 1/3 at which point the state becomes “UP” again. Change-Id: Id6be52475151a0208000ced17fe1f2d3f15e7b94
-
- 03 Jun, 2017 1 commit
-
-
User authored
Correct a translation error Change-Id: I85ef2c21e7ad56daa9aec8efa4e386aaf9fa55ae
-
- 30 May, 2017 2 commits
-
-
Evan W. Patton authored
This commit fixes the following: 1. Blocks in the mutator workspace did not respond to mouse down events in Firefox versions earlier than 53.0 due to the lack of a focus method on SVG elements. 2. Made the splash screens only appear after leaving the project list (if the user had projects). This prevents a scrolling issue that occurs when the user has more than one screen's height worth of projects and the DeckPanel transitions from the project list to the designer view while the splash screen is being shown. In some cases, users were unable to scroll to or otherwise access the dialog to dismiss it. Change-Id: If368f4c15a55993f95ef17050bb8c0e9493cf40e
-
Pavitra authored
Change-Id: If1b6dcd50078f3b214d03fa8bb13032a88b54c96
-
- 29 May, 2017 1 commit
-
-
Evan W. Patton authored
1. Added more checks for cases where dragging a block from the drawer results in many blocks being created at the same (x, y) coordinates. (see mit-cml/blockly master) 2. Fixed issue where error checking did not occur when deleting a global variable definition block. 3. Fixed issue introduced in extension update that prevented deleting extensions from projects imported before the update. Change-Id: I5fdcc89dfdc9f1392948fb8c864b77e45a2f8e3a
-
- 27 May, 2017 1 commit
-
-
Evan W. Patton authored
This commit addresses two issues with the blockly update: 1. Updates the flyout implementation in Blockly core to store information about the last created block so that if many create operations are fired only the first will be applied. This should prevent a reported issue where many blocks are created at exactly the same location when dragging from the flyout. 2. Change the z-index of ode-DialogBox to be greater than Blockly's drag surface z-index so that dialogs that appear during drag operations will not be occluded by the dialog. Prior to this change, the block would be above the dialog and prevent the user from being able to click any button to dismiss the dialog. Change-Id: I07f19b971860f72ec512dfd9cb39bcb5207f3987
-
- 25 May, 2017 1 commit
-
-
Jeffrey I. Schiller authored
It embeds an obsolete version of the BLE extension. Change-Id: I63f6da2e537dac86ce7581cb11fbbdd74a5f68d4
-
- 24 May, 2017 1 commit
-
-
Evan W. Patton authored
This commit provides a progress bar so that the UI gives feedback to the user when sending large assets (such as extensions) to the Companion. This commit also adds the _extensions RPC to the Companion to enable loading of project-specific extensions from the phone's AppInventor directory rather than all *.jar files present. Change-Id: I787374dcf2d7c295b2a14e38a72c6c06996ce5d1
-