GitLab

App Engine requires that we now include the companions download
directory in the <static-files> section of appengine-web.xml.

Change-Id: I13c03f0f4625f79ea42a902ab23aaed6adf45569

After the recent App Inventor 2 update, the backpack is now persistent,
which means that when right-clicking on the backpack icon on the block
editor and clicking "Show Backpack documentation", some of the text in
the dialog is incorrect. I have corrected the text to show that of the
release notes.

Change-Id: I223be859193a2b02be8bcf673bdebd6f7116444d

Josh ran into a NullPointerException when receiving a SMS message
using a Pixel running Google Fi. There are a few possible reasons this
could happen:

1. We linked against android.telephony.gms.SmsMessage. If the message
   was formatted as CDMA (3gpp2) then it is possible that the message
   returned is null, resulting in the NPE.

2. Any format other than 3gpp or 3gpp2 will result in the same flow as
   1 if a new format is introduced in the future, or if the format
   were something such as a data packet from Google Voice.

In API 19, there was a new
android.provider.Telephony.Sms.Intents#getMessagesFromIntent
introduced to abstract away extracting SmsMessages from Intents. This
commit uses this API when the SDK is 19 or higher. We also catch NPE
in the broadcast receiver and log it to Logcat to prevent crashing.

Change-Id: I9f00d6156f004d3d72938de1e57b31cfb034d241

We store the backpack in a new “user file” named backpack.xml (the other
user file supported is “android.keystore” for the user’s signing
key). As an optimization we remove the backpack.xml file if we store
“[]” in it (the empty backpack represented as an empty JSON string).

Change-Id: I16fb747f31e59d30535f690c1b35c80bde53629f

When an obfuscated text is used in an application with memory
pressure, the iteration over the obfuscated string can cause a
NullPointerException to be thrown from gnu.text.CharMap. The CharMap
uses weak references to Char objects to make Chars eq?. However, Kawa
does not check whether the Char returned from the WeakReference.get()
method is null and then attempts to take its intValue(). In
applications where there is little memory pressure the WeakReferences
are unlikely to be GCed so we don't normally observe this erroroneous
behavior.

This commit updates kawa-1.11-modified.jar with a check whether the
Char returned by the WeakReference is null prior to taking the
intValue(). If the Char is null, it will fall through to recreate the
Char and add it to the CharMap.

Change-Id: Idb19540b6096a9609a8aa06e77d628cd3ce1dc6b

Limit the number of calls to MockForm.refresh(). This lets a project
with a lot of designer objects load when otherwise the exponential time
and space consumption of repeated and nested calls to refresh() would
cause it to fail to load.

This implementation throttles the calls “locally.” The idea is to limit
the number of calls to 1 every 2 seconds. An alternative implementation
would be to set a flag while a project is loading (which is when this is
a problem) and inhibit all calls to refresh while this flag is set. Then
when the project is no longer loading, clear the flag and do one final
call to refresh. However this would be tricky because loading is
asynchronous and knowing when it is completely finished is
complicated. Such an implementation would be spread over several
modules, and add complexity to the codebase. This change is simpler
because it is limited to one module.

We also add a logging call Ode.CLog to Ode that logs to the developer
console instead of the OdeLog module which logs to the special debug
tab. There are situations where logging to the console is desirable,
like when the problem you are attempting to debug leaves App Inventor
locked up so you cannot see the debug tab!

Change-Id: I5fb9c832704e87c6e73903dc3a75ceb79df5f7f3

On phones with smaller memory footprints, the use of InputStream.mark
was causing an IOException to be thrown that resulted in images not
loading. This patch loads the entirety of the image into a byte[] and
then uses that in conjunction with a ByteArrayInputStream to pass the
image around to the multiple interfaces that need it without reloading
the content. This fixes the failure to load many images in the
emulator.

Change-Id: If7185e8e1a02e19a46037a4dd4df545241fa7f2b

Do not use a transaction when running in the dev server as this causes a
multi-entity group error. This happens because the dev server simulates
the Google Cloud Store using the datastore. If we use a transaction in
create project it winds up covering multiple entity groups. One for our
modifications to the “FileData” kind and a second for the simulated GCS
bucket kind.

Change-Id: I4a31eb16c7866e4ed721c02dbc77addea8df3dbf

Remove the check in versioning.js that throws an exception if a
component version is newer then the system version. This exception
guaranteed that a project touched by a newer version of App Inventor
would not work in the current version.

With this change the project may work if the newer version made not
incompatible changes. The user is shown a warning dialog stating that
the project might not work.

Change-Id: I72c15383b20d918ffd0077d6f7a10f8d1dd4b345

Change-Id: I323066420ea9e0dd9472829e3ee2a1d750d4ba5f

Refactoring to reduce the number of unique dialog boxes instantiated by
Ode. We add this generic MessageDialog method and use it for the
Firebase experimental warning, eliminating the ode.warningDialog
method. Future refactoring can remove more unique dialogs.

Change-Id: I77e1df2a359424aac38c6e8ae8b04fec292cbe99

This reverts most of commit b5e78d70.
We keep the changes to MediaUtil.getBitmapDrawable. So the actual image
fetching happens on a non-UI thread, but the UI Thread blocks until the
network I/O is done. This is non-ideal, as blocking on the UI thread can
result in an Application Not Responding (ANR) error. However this might
be more desirable then having the application apparently not load a
background image for a long time, and then having it suddenly appear
when the background network loading is finally finished.

Change-Id: I3424918a83284d19ee6ccfc9deb8824f5c0605a2

When the minSdkVersion is >= 10 and the user attempts to set an image
to a non-file URL, the Android runtime will throw an
android.os.NetworkOnMainThreadException. This commit changes the
behavior of MediaUtil.getBitmapDrawable to an asynchronous design that
takes a callback that will be triggered after the bitmap has been
loaded. If an exception occurs, an onException callback will be
used. Other failures are reported via the onFailure callback. Due to
the change to AsyncCallbackPair, this change also affects a number of
other components that may or may not have been performing network
access on the main thread.

Testing of this change should focus on the following components:
 * ButtonBase and its descendants
 * Canvas
 * Form
 * GameClient
 * HVArrangement and its descendants
 * Image
 * ImageSprite
 * MediaStore
 * TinyWebDB
 * Voting

Change-Id: Ib9bd0a0a929b26ad44eeda58a7c637398dd70219

Reported by the forum posting [1], the SoundRecorder crashes when the
Start method is called. After some debugging, this is due to
unexpected values being reported via the onInfo method being called
with an unexpected, non-documented value of `what`. The code always
called controller.recorder.stop(), but since the MediaRecorder hadn't
transitioned to the recording state yet, stop() throws an uncaught
IllegalStateException, which kills the program.

This commit makes the onInfo method more robust by reporting known
`what` values via dispatchErrorOccurredEvent and ignoring any values
not declared by AOSP. It also adds a call to StoppedRecording()
otherwise the app may not have been aware of the failure state.

[1] https://groups.google.com/d/msg/mitappinventortest/qMPzn5s82UY/LJu8znfrAwAJ

Change-Id: Ifd12fcf016df07b500b958bd4900781bf6ff6c47

When set this property causes lists to be displayed in JSON notation
rather then Lisp notation. Its default value is “false” so current
projects continue to work and new projects will still use Lisp
format. This can be changed in the future once the Companion that
supports ShowListsAsJson is widely deployed.

Change-Id: I2e6b25c32d27377685eb8111f44536479e7c55b7

Newer versions of the App Engine SDK insist that we declare our
statically served files. We omitted /reference/**. This commit adds it.

Change-Id: I652adae99b7bf3df50ea8b6fb3f201c430d3e002

Change-Id: I45302130bece743ac779ed5c569208b534f82e57

Selected element in the palette is now colored green making it easier to
see that it is selected.

Change-Id: I09006eb537495343bef3dfdad2888a3d96135e29

There is a prompt for the user to create or open a project. However,
this is based on whether currentFileEditor is set, which is a problem
is a project load is in process. This commit adds a check to
EditorManager to see if there is an editor even though
currentFileEditor is null, in which case no prompt is shown.

Change-Id: Icf044a638fef19d7fb5660a4783f852c7ccbb6cb

The loading of GallerySettings has a high latency in production. This
commit makes it so that the GallerySetting object is created only once
per GAE instance. It also updates the Flag class to cache the value on
first read since these flags are set in appengine-web.xml and are only
expected to change during deployment of a new version of App Inventor.

Change-Id: I7bb123697e821f2510807c5cbd5671bae71db307

This commit updates Google App Engine and Google Cloud Storage
libraries to the most recent versions. This fixes exceptions in the
dev server regarding the deprecated Files API.

Change-Id: Icd3883c292cfb055bb18560ca04aaf2b313ba9ba

Commit e38f54e9 deferred gallery loading until the user opened the
gallery. This commit provides more complex logic for managing the
"Loading..." messages shown during loading of the gallery by counting
the number of tabs that have loaded content. In the earlier commit, if
the primary tab wasn't loaded the message would go away if one of the
non-visible tabs finished loading. Now the loading message will only
go away if all tabs have loaded their content.

Change-Id: I019891c4b3160f91658f43ad1d42f47e00cffd32

Switching between tabs will save settings even if nothing has
changed. This results in more network operations than is necessary to
maintain correct behavior of the application.

This commit updates the CommonSettings class hierarchy to record when
changes have been made. UserSettings and ProjectSettings will perform
RPC if and only if the changed flag is true. Otherwise, saving
settings is a no-op.

Change-Id: I1f15d39418036b320ee3050003034b97e46415be

Only certain actions modify the state of android.keystore on the
server. The keystore can only change if a new one is imported, the
current keystore is deleted, or when no keystore exists but the user
builds an app. However, this is not reflected in the flow control of
App Inventor. Switching between projects, for example, will check for
the state of android.keystore even though this is a user file not a
project file, and the state of the android.keystore will be invariant
between projects.

This commit caches the result of checks for android.keystore to reduce
the number of round trips to the server and only rechecks when an
action may result in an update to the status or in the event an
earlier call to hasUserFile fails.

Change-Id: I65df499d509ea7098f6b349d0da09cdaea84dd08

Reduce logging so only anomalous situations result in log entries (you
can turn logging back on by setting appinventor.debugging to true in
appengine-web.xml).

Disable App Stats, as it really isn’t needed in production.

Provide reasonable caching and expiration on some static files,
including making sure they are served statically (this is required when
removing App Stats).

Change-Id: I84bd4877a2cbeba79f7da9248919920ea27c499b

Daily we have 750,000+ requests for resources via /ode/gallery. These
requests occur even if the user never actually accesses the gallery
since they are done at initialization of Ode. This commit defers the
initialization of the gallery UI so that it is only generated once the
user accesses the gallery.

Change-Id: Ic16ae5f45c8f79570d763408f5958170fa332ae1

Commit 72e0ca15 added a callback to handle loading of assets to the
Companion. However, if the Companion is connected to a project without
assets, the callback to switch from ASSET state to CONNECTED state
will never fire. This commit checks whether the asset map has 0
elements, in which case it will synchronously fire the callback so
that projects without assets will immediately transition to CONNECTED
state.

Change-Id: Iba12232966752ed9cb61af0f97aa16ebcffeed4a

Apparently the canvas.toDataURL method does not work reliably when the
blocks image is large. Instead convert it to a block with canvas.toBlob
and create a URL from the blob. This seems to work with blocks areas
that fail with the toDataURL approach.

Change-Id: I8706c91c23e1522be193f5391afb6390ea036f81

Change-Id: I4a6084d1a6cd83ac69d73fcc1b3e3a510ece7997

Asset loading is performed asynchronously and usually happens
quickly. However with many or large assets, the transferring of the
asset to the device (or emulator) may not finish in time, resulting in
an error and a re-try (which eventually succeeds).

We re-factor the asset transferring code to properly handle its
asynchronous nature using appropriate callbacks.

Change-Id: Idf0170d9a6d929a7ca964b3852811b2b09dc49ce

Summary:
Using the @ActivityElement and @UsesActivities annotations, it is now
possible to launch an arbitrary activity from a component without
hacking Compiler.java to register that activity in AndroidManifest.xml.

Using the @ReceiverElement and @UsesBroadcastReceivers annotations, it is
now possible to leverage the full functionality of the Android
framework when creating <receiver> elements in AndroidManifest.xml.

Both of these new annotations allow App Inventor component developers
to add <intent-filter> and <meta-data> subelements to activities and
broadcast receivers declared in AndroidManifest.xml with the
@IntentFilterElement and @MetaDataElement annotations.

-ListPicker has been refactored to use these new annotations.
-BarcodeScanner has been refactored to use these new annotations.
-Twitter has been refactored to use these new annotations.
-Texting has been refactored to use these new annotations.
-Since the NearField component makes changes to the main activity contingent
 on information that is only available at build time, Form and NearField
 cannot be refactored to use these annotations at the moment.
-New unit tests for broadcast receiver and activity generation were added in
 com.google.appinventor.buildserver.CompilerTest.java.
-Added legacy support for the deprecated @SimpleBroadcastReceiver annotation
 so that we don't break extensions that are currently using it.

Change-Id: I2114f2b522bdbcf51e1e1b79a642010ff040e183

This commit disables suggestions in the TextView, which appears to
crash the Companion on Android 7+ due to missing layouts.

Change-Id: I932f5aeaded2584e80f1e2e512e401000a7214ed

Change-Id: I8b786623776c50edfd44af519eee87c7779cbd56

Fix to permit extension loading again.

Change-Id: I6edb0391d1f4abb9815eda198af8ed16b7b5da7c

When changing the called procedure name in a procedure block that
returns a value, the parameter sockets disappear and the block becomes
unusable. This is caused by the fact that the code looks to call
getProcedureDef but it is undefined, even on procedure blocks. The
issue was that it is supposed to be copied from the no return version
of the procedure call block, but the reference was wrong and so the
value was undefined. This commit fixes the erroneous reference in
order that the behavior is correct. This also has the side effect of
fixing the (unreported?) bug that the "Highlight Proceduce" context
menu action was not working due to the same issue.

Fixes #844

Change-Id: I7041c3ab05a89c1a710128a7d91a543bb601940a

Change-Id: I040f50fbe9fadf0fbd3b26e7312fa98b43f3d374

Change-Id: I375eddc7d09e1042ad372e2c581552c1401954d6