GitLab

Add style to general error messages

Fix GH-628: Add box shadow for focus state on checkboxes

Fix GH-666: Make category options into key/value

so that we can store the query string with the tab name, since it's not the same in every instance. fixes #666, and makes a couple other style tweaks.

From review of the style with @carljbowman

Requires a bit of magic, where the Form component manually adds the "all" value. But without a major overhaul of the validation system, I don't see how else to put the general error among the other fields.

Resolves #647

Fixes #628 by applying the same outline for focus as is currently applied to checked boxes.

Fix JSON response parsing in IE

Get rid of most splash warnings in development

Fixes #654

IE does not honor responseType: 'json', and will not parse responses as JSON unless json data is present in the request. For some reason this issue can also be solved by including a `json` attribute on the xhr request, but if that's present, url encoded form data is overwritten with the contents of the json.  So just try to parse the response ourselves if it looks like it wasn't parsed.

See https://github.com/Raynos/xhr/issues/123

Fix GH-655: use custom-defined internal separator in locale compare

There is some stacking that happens in object keys that had been using the `-` to track language/view hierarchies, which was thrown off by view names that used a `-` in them. Switch to using `:`, and also make it customizable. Fixes #655

Revalidate address step after invalid submissions

I don't like that the state is being set to a calculation of existing props. When I did that calculation in `render`, it didn't update when fields were changed.

Fixes #645

Fix GH-649: Dropdown hidden by TED Talk

Fix GH-651: Orangeify navbar when SCRATCH_ENV=staging

Fix GH-642: Use empty default object for validation factory

Looks as if the having one of these objects as the default causes overwriting in some way, as opposed to augmentation. Have the source object be an empty one, so that it gets the attributes of both defaults and props. Fixes #642.

Clarify username field is not for logging in

Fix GH-637: Make links to help and tips window relative

Fix localization of address validation message

Fix GH-643: use empty string if no cookie value found

Fixes #608

redux doesn't like getting null values for actions, so give empty ones

/cc @rschamp

Fix GH-636: point landing page to teacher faq page

Fixes #636

Fix GH-626: Set null contents to null instead of error throw

thanks @rschamp!

Before, if a cookie didn't exist, it would throw an error, not causing permissions/tokens to change to empty values. This fixes that (and #626) by setting the value to undefined instead.

Fix #633, #634, and #635: Embedded player fixes

Fix GH-617: switch ordering in defaults

This was assigning `props` to defaults, rather than the other way around. Fixes #618.