Commit 936172d7 authored by seotts's avatar seotts

only show feedback link for new mute

Add variable for isBad string
parent 35b3c8d6
......@@ -162,7 +162,7 @@ class MuteModal extends React.Component {
)}}
/>
</p>
{this.state.step === this.numSteps ? feedbackPrompt : null}
{this.state.step === this.numSteps && this.props.showFeedback ? feedbackPrompt : null}
</MuteStep>
<MuteStep
header={this.props.intl.formatMessage({id: 'comments.muted.mistakeHeader'})}
......
......@@ -23,6 +23,7 @@ require('./comment.scss');
const onUpdate = update => update;
const MAX_COMMENT_LENGTH = 500;
const JUST_MUTED_ERROR = 'isBad';
const ComposeStatus = keyMirror({
EDITING: null,
......@@ -363,7 +364,9 @@ class ComposeComment extends React.Component {
commentContent={this.state.message}
muteModalMessages={this.getMuteMessageInfo()}
shouldCloseOnOverlayClick={false}
showFeedback={this.state.status === ComposeStatus.REJECTED_MUTE}
showFeedback={
this.state.status === ComposeStatus.REJECTED_MUTE && this.state.error === JUST_MUTED_ERROR
}
showWarning={this.state.showWarning}
startStep={this.getMuteModalStartStep()}
timeMuted={formatTime.formatRelativeTime(this.state.muteExpiresAtMs, window._locale)}
......
......@@ -304,6 +304,59 @@ describe('Compose Comment test', () => {
expect(component.find('MuteModal').props().showWarning).toBe(true);
});
test('Mute Modal gets showFeedback props from state', () => {
const store = mockStore({
session: {
session: {
user: {},
permissions: {
mute_status: {}
}
}
}
});
const component = mountWithIntl(
<ComposeComment
{...defaultProps()}
/>
, {context: {store}}
);
const commentInstance = component.find('ComposeComment').instance();
commentInstance.setState({
status: 'REJECTED_MUTE',
error: 'isBad',
muteOpen: true
});
component.update();
expect(component.find('MuteModal').exists()).toEqual(true);
expect(component.find('MuteModal').props().showFeedback).toBe(true);
commentInstance.setState({
status: 'REJECTED_MUTE',
error: 'isMute',
showWarning: true,
muteOpen: true
});
component.update();
expect(component.find('MuteModal').exists()).toEqual(true);
expect(component.find('MuteModal').props().showFeedback).toBe(false);
commentInstance.setState({
status: 'REJECTED',
error: 'isBad',
showWarning: true,
muteOpen: true
});
component.update();
expect(component.find('MuteModal').exists()).toEqual(true);
expect(component.find('MuteModal').props().showFeedback).toBe(false);
});
test('shouldShowMuteModal is false when muteStatus is undefined ', () => {
const commentInstance = getComposeCommentWrapper({}).instance();
expect(commentInstance.shouldShowMuteModal()).toBe(false);
......@@ -449,4 +502,15 @@ describe('Compose Comment test', () => {
commentInstance.setState({muteType: 'spaghetti'});
expect(commentInstance.getMuteMessageInfo().commentType).toBe('comment.type.general');
});
// test('Show feedback link when comment is initially rejected', () => {
// const component = getComposeCommentWrapper({});
// const commentInstance = component.instance();
// commentInstance.setState({error: 'isBad', mute_status: {}});
// component.update();
// expect(component.find('FlexRow.compose-error-row').exists()).toEqual(true);
// // Buttons stay enabled when comment rejected for non-mute reasons
// expect(component.find('Button.compose-post').props().disabled).toBe(false);
// expect(component.find('Button.compose-cancel').props().disabled).toBe(false);
// });
});
......@@ -160,6 +160,23 @@ describe('MuteModalTest', () => {
expect(component.find('p.feedback-prompt').exists()).toEqual(true);
});
test('Mute modal does not for feedback on extra showWarning step if not showFeedback', () => {
const component = mountWithIntl(
<MuteModal
showWarning
muteModalMessages={defaultMessages}
/>
);
component.find('MuteModal').instance()
.setState({step: 1});
component.update();
expect(component.find('p.feedback-prompt').exists()).toEqual(false);
component.find('MuteModal').instance()
.setState({step: 2});
component.update();
expect(component.find('p.feedback-prompt').exists()).toEqual(false);
});
test('Mute modal handle go to feedback', () => {
const component = shallowWithIntl(
<MuteModal
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment