fix missing the first bit in HC589 shift in (#2448)

c0345eaf · Nguyen Hong Thiet · Me No Dev · 71ec3c3e · c0345eaf
Commit c0345eaf authored Feb 14, 2019 by Nguyen Hong Thiet Committed by Me No Dev Feb 14, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

cores/esp32/wiring_shift.c cores/esp32/wiring_shift.c +2 -1

No files found.
--- a/cores/esp32/wiring_shift.c
+++ b/cores/esp32/wiring_shift.c
@@ -25,11 +25,12 @@ uint8_t shiftIn(uint8_t dataPin, uint8_t clockPin, uint8_t bitOrder) {
    uint8_t i;

    for(i = 0; i < 8; ++i) {
-        digitalWrite(clockPin, HIGH);
+        //digitalWrite(clockPin, HIGH);
        if(bitOrder == LSBFIRST)
            value |= digitalRead(dataPin) << i;
        else
            value |= digitalRead(dataPin) << (7 - i);
+        digitalWrite(clockPin, HIGH);
        digitalWrite(clockPin, LOW);
    }
    return value;