Fix getString() freeze on empty responses (#4317)

aa529eb5 · wadim · GitHub · a9cb7c6d · aa529eb5
Unverified Commit aa529eb5 authored Oct 01, 2020 by wadim Committed by GitHub Oct 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

libraries/HTTPClient/src/HTTPClient.cpp libraries/HTTPClient/src/HTTPClient.cpp +4 -1

No files found.
--- a/libraries/HTTPClient/src/HTTPClient.cpp
+++ b/libraries/HTTPClient/src/HTTPClient.cpp
@@ -921,13 +921,16 @@ String HTTPClient::getString(void)
 {
    StreamString sstring;

-    if(_size) {
+    if(_size > 0) {
        // try to reserve needed memmory
        if(!sstring.reserve((_size + 1))) {
            log_d("not enough memory to reserve a string! need: %d", (_size + 1));
            return "";
        }
    }
+    else {
+        return "";
+    }

    writeToStream(&sstring);
    return sstring;