Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
arduino-esp32
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
xpstem
arduino-esp32
Commits
9fe34f65
Unverified
Commit
9fe34f65
authored
Jan 31, 2022
by
mrengineer7777
Committed by
GitHub
Jan 31, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve WString TODO (#6190)
Resolve TODO (XXX) by logging warning message.
parent
cbeb7c4d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
cores/esp32/WString.cpp
cores/esp32/WString.cpp
+3
-1
No files found.
cores/esp32/WString.cpp
View file @
9fe34f65
...
...
@@ -24,6 +24,7 @@
#include <Arduino.h>
#include "WString.h"
#include "stdlib_noniso.h"
#include "esp32-hal-log.h"
/*********************************************/
/* Constructors */
...
...
@@ -774,7 +775,8 @@ void String::replace(const String& find, const String& replace) {
if
(
size
==
len
())
return
;
if
(
size
>
capacity
()
&&
!
changeBuffer
(
size
))
return
;
// XXX: tell user!
log_w
(
"String.Replace() Insufficient space to replace string"
);
return
;
int
index
=
len
()
-
1
;
while
(
index
>=
0
&&
(
index
=
lastIndexOf
(
find
,
index
))
>=
0
)
{
readFrom
=
wbuffer
()
+
index
+
find
.
len
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment