Fixes DNS Server Memory Leak when deleted (#6707)

44beee2f · Rodrigo Garcia · GitHub · 0b3f1a9f · 44beee2f · 44beee2f
Unverified Commit 44beee2f authored May 09, 2022 by Rodrigo Garcia Committed by GitHub May 09, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 0 deletions

libraries/DNSServer/src/DNSServer.cpp libraries/DNSServer/src/DNSServer.cpp +16 -0

libraries/DNSServer/src/DNSServer.h libraries/DNSServer/src/DNSServer.h +1 -0

No files found.
--- a/libraries/DNSServer/src/DNSServer.cpp
+++ b/libraries/DNSServer/src/DNSServer.cpp
@@ -20,6 +20,22 @@ DNSServer::DNSServer()
  _port = 0;
 }

+DNSServer::~DNSServer()
+{
+  if (_dnsHeader) {
+    free(_dnsHeader);
+    _dnsHeader = NULL;
+  }
+  if (_dnsQuestion) {
+    free(_dnsQuestion);
+    _dnsQuestion = NULL;
+  }
+  if (_buffer) {
+    free(_buffer);
+    _buffer = NULL;
+  }
+}
+
 bool DNSServer::start(const uint16_t &port, const String &domainName,
                     const IPAddress &resolvedIP)
 {

--- a/libraries/DNSServer/src/DNSServer.h
+++ b/libraries/DNSServer/src/DNSServer.h
@@ -76,6 +76,7 @@ class DNSServer
 {
  public:
    DNSServer();
+    ~DNSServer();
    void processNextRequest();
    void setErrorReplyCode(const DNSReplyCode &replyCode);
    void setTTL(const uint32_t &ttl);