GitLab

[breaking] feature: Added gRPC `close` signal to `Monitor` call (allows graceful close of monitor) (#2276)

* Refactored gRPC Monitor API

* Added Close request to gRPC Monitor API

* Updated docs

* Made CreateEnvForDaeamon available in all integration tests

* Added integration test

* lint: avoid redefinition of the built-in function close

* lint: comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error

* Allow up to 5 seconds for a pluggable monitor to gracefully close

* Made the gRPC daemon actually wait for port close completion

* Removed libraries index fields from LibraryManager

The presence of the Index* fileds inside LibraryManager didn't give any
functional benefit.

* Removed all references to LibraryManger.Index

* Removed unused tmp file creation

* downloadLibrary do not require a libmanager but just the downloadDir

* Inline method LibrariesManager.Install

* Move initializations closer to usage

* Use LibraryManager.FindAllInstalled instead of direct access to field

* Made LibraryManager.Libraries private

* Simplified libraries resolver init

* Made LibrariesManager.LibrariesDir private

* Removed DownloadsDir field from LibraryManager

* Removed librariesindex.Reference structure and related helpers

It does make things more complicated without any actual benefit.

* Removed state-altering methods from LibrariesManager

The original LibrariresManager has been split into three objects with
specific goals:
* The Builder object is used to construct a new LibrariesManager. It has
  methods to add librarires directories and to build the LibrariesManager.
* The Explorer object is used to query the LibrariesManager about
  installed libraries.
* The Installer object is used to rescan installed libraries and to
  install and uninstall.

* Fixed test

It is buggy, unmaintained and no more used.

* Bump google.golang.org/protobuf from 1.31.0 to 1.32.0

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Factored some library_index.json URL globals

* Removed unused parameter

* findLibraryIndexRelease requires libraries index instead of libraries manager

* LibrariesManager.AddLibrariesDir now accepts directly a LibraryDir struct

This is preparatory for the next commit

* AddLibrariesDir now can handle also single-lib directories

* Removed weird hack in the library detector

Previously the libraries detector had to load the single librares
provided via '--library' flag after a Rescan, because the library
manager wasn't able to handle a single folder library. Now it can so we
removed all the tricky machinery.

It makes explicit that the function may fails to get the package manager
or the library manager.

[breaking] gRPC updates to `CompilerResponse`, `UploadUsingProgrammerResponse`, and `BurnBootloaderResponse` (#2472)

* Refactored gRPC CompilerResponse

* Refactored gRPC UploadUsingProgrammerResponse and BurnBootloaderResponse

* Reuse archiveCompiledFiles helper for long commandline shrink

Since archiveCompiledFiles already handles hot cache correctly, this avoids objs.a being rebuilt even if files don't change.

Would be ideal if PathList could expose a generic Filter API (to get rid of the "duplicated" filter)

* Upgrade go-paths / remove duplicate filter function

* Consider existing archives during the build

* Simplified archiveCompiledFiles function signature

It doesn't make sense anymore to keep path and filename separated.

* Added integration test

---------
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Bump github.com/spf13/viper from 1.18.1 to 1.18.2

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](https://github.com/spf13/viper/compare/v1.18.1...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Bump google.golang.org/grpc from 1.60.0 to 1.60.1

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.60.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.60.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Added versioning/upgrading policy

* Added backward compatibility policy

* Bump golang.org/x/crypto from 0.16.0 to 0.17.0

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Internalized 'i18n' module

* Internalized 'docsgen' package

* Internalized 'client_example'

* Updated docs

Bumps [github.com/rogpeppe/go-internal](https://github.com/rogpeppe/go-internal) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/rogpeppe/go-internal/releases)
- [Commits](https://github.com/rogpeppe/go-internal/compare/v1.11.0...v1.12.0)

---
updated-dependencies:
- dependency-name: github.com/rogpeppe/go-internal
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/grpc from 1.59.0 to 1.60.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.59.0...v1.60.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Bump github.com/spf13/viper from 1.17.0 to 1.18.1

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.17.0 to 1.18.1.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](https://github.com/spf13/viper/compare/v1.17.0...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Made 'configuration' package internal

* Made 'arduino' package internal

* Moved errors in their own package

* Moved directories init out of commands/internal/instances

* Updated docs

* Removed dep on pkg/errors library

* Update easyjson task and generated files

* Move the terminal detection subroutines in feedback package

This also fix the linter errors:

internal/cli/configuration/term.go:25:39: use of `os.Stdin` forbidden because "in cli package use `feedback.*` instead" (forbidigo)
var IsInteractive = isatty.IsTerminal(os.Stdin.Fd()) || isatty.IsCygwinTerminal(os.Stdin.Fd())
                                      ^
internal/cli/configuration/term.go:28:36: use of `os.Stdout` forbidden because "in cli package use `feedback.*` instead" (forbidigo)
var HasConsole = isatty.IsTerminal(os.Stdout.Fd()) || isatty.IsCygwinTerminal(os.Stdout.Fd())

* Fix linter warning

* Fixed docs:include-configuration-json-schema task

* Fixed build test for discovery_client

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Replaced 'executils' with go-paths library equivalent

* Made 'buildcache' private

* Made 'table'' private

* Updated docs

* Fix caching for libraries when installation folder differents from Name

* Prepare infra to add integration test

* Added integration test

---------
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

Added `debug check` command to check if a combination of board/programmer supports debugging. (#2443)

* Moved rcp message to proper position

* Added gRPC command to check for debugger support

* Made debug flags var non-global

* Implementation of 'debug check' command

* Implementation of cli command 'debug check'

* added integration test

* Renamed field for clarity

* Added minimum debug_fqbn computation in 'debug check' command

* Bump golang.org/x/term from 0.14.0 to 0.15.0

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.14.0 to 0.15.0.
- [Commits](https://github.com/golang/term/compare/v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Parallelize upload_mock integration tests

* Accumulate output in integration test' runs of arduino-cli

Otherwise the output may be interleaved if tests are run in parallel.

* fix: debugging requires a non empty debug.executable

* Updated docs

---------
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

Library update/install with `--no-overwrite` will perform the update if it's possible to keep already installed dependencies at their current version (#2431)

* Updated semver library

* Improved behaviour of 'lib install --no-overwrite' flag

Previously the --no-overwrite flag would fail to install if a library
dependency was already installed but not at the latest version.
After this change the already present library may be accepted as a
dependency if it match the version constraints of the installed library.

* Fixed integration test

* Added integration test

* Always use 'installed' version if available

* Allow a bit more time for slow CI

* Removed debugging_supported field from BoardDetailsResponse

* fix typo

* debug: extend hotfix for trailing dash '-' to all toolchains

* Added additional_config selector for debug configuration

* Added docs

* Added gRPC message errors

* Implemented specific exit-code for "programmer not found" error

* Added a compatibility trick in "debug -I" for toolchain.prefix key

The key was ignored in older versions of the Arduino IDE.
In the upcoming release (Arduino IDE 2.2.2) the key is used, but it was
wrongly set to "arm-none-eabi-" when we actually want "arm-none-eabi".

This patch ensure backward and forward compatibility.

* Fixed debug command

* Fixed regression in compile_commands.json generation

* Added integration tests

* Improve gh-actions output by folding integration-test output

* Reduce build verbosity (not needed in GH actions logs)