GitLab

Previously installing from a zip file would extract the content directly
into the user library folder, this could have caused problem if the zip
file wasn't structured correctly.

To handle this we now extract to a temp directory to verify that the zip
is structured correctly and to infer the name of the library being
installed. If everything is fine we then copy it over to the user
library folder to finalize the installation.

Installing from a git repository has been enhanced too, after
cloning the repository to the user library folder we delete the .git
folder to make it a plain folder. Cloning should be faster too since we
now clone using depth of one commit to avoid downloading useless files.

Both when installing from a zip file or from a git repository we delete
the installed library folder if one with the same name is already
installed.

* Fix lib install with git url

* Better git url handling

* Precompiled libraries: only select a folder if it contains files

* Restore precompiled tests

* slightly refactored directoryContainsFile function

* [skip changelog] Fix compile tests

* [skip changelog] Fix compile test
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>

Previously overwriting a file will not truncate it, so if the download
size was less than the file size already on disk then the resulting file
will end up with a "corrupted" piece at the end.

* Don't archive preexisting archives if commandline is too long

Fixes https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1693000682?check_suite_focus=true#step:7:277
Should revert https://github.com/arduino-libraries/ArduinoIoTCloud/pull/222

* Added test
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

The terms "cache" and "clean" might bring compilation to mind, but the `arduino-cli cache clean` command has nothing to
do with compilation. Many users will likely not even be aware of the existence or purpose of the `directories.downloads`
folder. For this reason, it's important to make the purpose of this command clear.

Previously, the Arduino library specification required the library.properties `name` field value to start with a letter.
Before Arduino IDE 1.8.4, library folder names starting with a number were not supported. Because the library folder for
Library Manager installations is named according to the library.properties name value, it was necessary to apply the
same restriction to the name value. It was determined that enough time has passed since the Arduino IDE 1.8.4 release to
reflect this change in the Arduino library specification.

Previously the name of the specification was "package_index.json specification". Only the primary official package index
is allowed to be named package_index.json, but this specification applies to all package indexes. So "Arduino package
index specification" (shortened to "Package index specification" in the documentation navigaion pane) is less likely to
cause confusion and also easier to remember and talk about.

This feature allows to selectively "override" the content of a sketch.
Overridden files will not be read from disk as usual but fetched directly
from gRPC paramaters (if the cli is running as daemon) or from a .json
file containing the new source code (if running from command line).

For example if we have bossac 1.7.1 and 1.9.0 installed, this will
result in the following properties available during upload:

{runtime.tools.bossac-1.7.0-arduino3.path} => /path/to/bossac/1.7.0
{runtime.tools.bossac-1.9.0-arduino3.path} => /path/to/bossac/1.9.0
{runtime.tools.bossac.path} => /path/to/bossac/1.9.0

some platforms fails to correctly specify the version of the tool in the
package_index.json but they do the correct specification in the recipes.
This patch allows to not fail in this latter case.

Fix #1040

* Draft: Support generating a compile_commands.json file

This is still very rough and unfinished.

* Added compile flag to produce only the compilation database

* Save compilation database inside build path

* Removed 'Writing compilation database...' message

Also slightly refactore code

* Added missing (c) header

* Renamed some functions, did some small cleanups

* compilation database: made some fields public

* compilation database: added LoadCompilationDatabase method

* Added unit tests for compilation_database
Co-authored-by: Matthijs Kooijman <matthijs@stdin.nl>

* [skip changelog] Improve wording of FAQ re: boards w/o dedicated VID/PID

Some minor wording improvements for readability/correct terminology.

* [skip changelog] Mention Nano in FAQ re: boards w/o dedicated VID/PID

The classic Nano is the sole active official board without a custom VID/PID, so it's especially important to mention it
in this FAQ.

* Removed unused return error in cores.Platform.GetOrCreateRelease

* cosmetic: renamed variables in commands/bundled_tools_serial_discovery.go

* fixed typo

* Renamed mutex -> listBoardMutex

* tools-flavor-tests: Some renames and clean up

* tools-flavors: Prioritize OS exatch-match over compatible-match

* tools-flavors: unrolled freebsd regexps

* tools-flavors: Added Apple silicon support

* tools-flavors: Added support for Windows 64 bit

* tools-flavors: give priority to better matching OS

* [skip changelog] Update UPGRADING.md with new breaking changes

* [skip changelog] Apply suggestions from code review
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>

* Add support for file:// schema to set local additional URLs

* Fix local path parsing on Windows

* Move URL parsing in utility function

[skip changelog] Update contributions guidelines and PR template to add labeling and increase focus on breaking changes (#1039)

* [skip changelog] Update contributions guidelines and PR template to add labeling and increase focus on breaking changes

* Add better explanation of breaking changes based on suggestions

* Reword breaking change paragraph in docs and Arduino CLI name in pull request template

* Revert typo

* [skip changelog] Update breaking changes policy

* [skip changelog] Fix some docs issues

* [skip changelog] Remove unused link from docs
Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>

* Initial commit

* Bind new flag --additional-paths and add new function LoadIndexNoSign

* Use absolute file path to package_index.json

* Add documentation for additional-paths feature

* Update comment for LoadIndexNoSign

* Update variable names to pass checks + simplify code

* Add new config for additional_paths

* Bump actions/cache to v2

* Bump actions/checkout to v2

* Pin actions/create-release to v1

* Bump actions/download-artifact to v2 and maitain compatibility

* Bump actions/github-scripts to v3

* Bump actions/upload-artifact to v2

* Bump peter-evans/create-pull-request to v3

* Bump svenstaro/upload-release-action to v2

* Fix issue with actions/checkout@v2

In certain workflows we use a custom Docker image for cross-compilation,
this image is old and unmaintained so it has an old version of git and
the latest version actions/checkout doesn't support it.
This causes the action to fallback to the Github API to download the
files but that doesn't create a git repository, thus the history is lost
but goreleaser needs it to generate the changelog so it fails.

So we use the older version of the action in certain cases to avoid
this failures.
Co-authored-by: Silvano Cerza <silvanocerza@gmail.com>

* legacy: inlined utils.PrepareCommand

* legacy: inlined ExecRecipe function

* Added Compile json output

* Factored out methods to convert Libraries into their rpc counterpart

* Give some more info in compiler json output

* Added simple smoke-test for compile --format json

* Output in json even in case of error

* Added binary size to compile json output

* lib list: always output rows in table output, even if the "library.Release" field is not set

* Libs and cores update is now correctly run only on first CLI execution

* Enhance error messages when updating indexes or local index files are missing

If the certificates fail verification, a notification will be posted on the #team_tooling Slack channel.

If the certificates expire in less than 30 days, a notification will be posted on the #team_tooling Slack channel.