GitLab

* If the upload port-detector fails detection, fallback to the user-provided port

This will ensure that a port is always returned.

* Increased debug level

* Extend timeout if candidate port is lost in any case

Even if `waitForUploadPort` is true, we should extend the timeout to
allow USB enumeration to complete. In this case we extend by only 1
second instead of 5.

* Revert "Extend timeout if candidate port is lost in any case"

This reverts commit 7c77ed242383e416ff8748884a64474f73932911.

The latest commit is not necessary since the detector has already 5 seconds of timeout.

* Added 'upload' flags to set upload fields value

* Introducing key/value flag type

* Bump golang.org/x/net from 0.8.0 to 0.17.0

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.8.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>

* Updated license cache

---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Allow non-sequential properties list

* Command 'debug info' choose between "script" and "scripts" configs exclusively

* Updated docs

* Added test for mixed old and new-style openocd script definition

* Update docs/platform-specification.md
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>

---------
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.35 to 3.1.37.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.35...3.1.37)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improved specification of debug configuration

* Added integration test

* Added the possibility to provide cortex-debug custom configs

* Added svd-file debug option

* Added textual print of custom cortex-debug config

* Updated docs

* Apply suggestions from code review
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>

* Added integration test for programmer selection

---------
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>

* Use paths.ReadDirRecursive filtered where possible

* Do not add sketch files from known build paths

* Improved builder globals

* Added integration test

[breaking] Eliminate BoardListWatchRequest `Interrupt` from the grpc api and make it server streaming only (#2330)

* replace deprecated openpgp lib (https://github.com/golang/go/issues/44226)

* update license

* Removed logger as a field of BuildOptionManager

* Made BuildOptionsManager a field of Builder

* Renamed BuildOptionsManager -> BuildOptions

* Made WipeBuildPath a method of Builder

* Removed unused currentBuildOptionsJSON field

* Separated wipeBuildPath and createBuildOptionsJSON actions

* Made wipe() a proper method -> Buidler.wipeBuildPath()

* Made BuildOptions private

* Made SketchLibrariesDetector a private field of Buidler

* Made BuildArtifacts private

* Made all builder subpackages internal

* Moved initialization of private structs inside NewBuilder

When compiling with --output-dir pointing to the same directory of --build-path do not copy file

* Move WarnDeprecatedFiles to commands/sketch

* Change FindPlatform's signature to avoid references to the Package Manager

* Replace direct access to the package manager with a call to PlatformSearch function

* Add skip_pre_uninstall parameter to gRPC platform requests

* Add pre-uninstall flags to CLI arguments

* Run pre-uninstall script when a platform or tool is uninstalled

* Document the changes

* Include pre-uninstall script run into the unit test

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.34...3.1.35)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Move Preprocess and Build in arduino/builder

* Move the detector inside arduino/builder

* remove legacy targets from TaskFile

* inline some variable declaration

* remove no longer used builder getters

* make only necessary function public in the new builder

* fix CR: avoid mutating internal state

* fix CR: only print normaloutput when is not verbose

* ported SketchThatIncludesArduinoH from legacy into integration test

* ported SketchWithStaticAsserts from legacy into integration test

* ported SketchWithEnumClass from legacy into integration test

* ported SketchWithExternC from legacy into integration test

* ported testBuilderSketchWithMultilinePrototypes from legacy into integration test

* ported SketchWithExternCMultiline from legacy into integration test

* ported SketchWithMultilineTemplate from legacy into integration test

* ported SketchWithFakeFunctionPointer from legacy into integration test

* fix wrong templating

* ported SketchWithMinMaxDefinitions from legacy into integration test

* ported SketchWithFastledsLibrary from legacy into integration test

* ported sketch with merged sketch and bootloader from legacy into integration test

* temporary disable legacy test, before porting them to the new infra

* update .gitignore

* ported CheckBuildOptionsFile from legacy into integration test

* ported SketchClassFunction from legacy into integration test

* ported SketchThatChecksIfSPIHasTransactionsAndIncludesMissingEthernet from legacy into integration test

* remove legacy builder test folder

* remove unsued fields from context

* move customBuildProperties to arduino/builder

* remove BuildProperties from context

* remove BuildPath from context

* remove sketch,libraries,core build path from Context

* remove buildPath parameter to PrepareSketchBuildPath func

* Make CoreBuilder a method recevier of arduino/builder

* Add BuilderLogger in arduino/builder

* Remove BuilderLogger from CoreBuild parameter

* Make getCachedCoreArchiveDirName unexported

* heavily refactored the ContainerBuildOptions

* remove fqbn from Context

* remove clean from Context

* remove unsued properties in Context

* remove sourceOverrides from Context

* make SketchBuilder a method recevier of arduino/builder

* make BuildLibraries a method recevier of arduino/builder

* make RunRecipe a method recevier of arduino/builder

* make RemoveUnusedCompiledLibraries a method recevier of arduino/builder

* make MergeSketchWithBootloader a method recevier of arduino/builder

* make WarnAboutArchIncompatibleLibraries a method recevier of arduino/builder

* make PrintUsedLibraries a method recevier of arduino/builder

* make ExportCmake and PreprocessorSketch a method recevier of arduino/builder

* remove legacy/constans pkg

* make Linker a method recevier of arduino/builder

* make Size a method recevier of arduino/builder

* remove onlyUpdateCompilationDatabase from Context

* remove Progress from Context

* remove ExecutableSectionSize from Context

* remove CompilationDatabase from Context

* remove LineOffset from Context

* introduce BuilderArtifacts to better isolate write operations

* remove ActualPlatform and TargetPlatform from Context

* directly pass the remaining properties of Context in the builder constructor

The remaning fields is used only by legacy tests

* polish legacy test

Logging with `info` generates too much noise.

Closes arduino/arduino-cli#2313
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Related to #2301 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* move CoreBuilder in arduino/builder and move CompilationDatabase in compilation pkg

* rename CompilationDatabse in Database

* move libraries phases in arduino/builder

* move linker phases in arduino/builder

* move sketch_builder phases in arduino/builder

* move sizer phases in arduino/builder/sizer

* create bulder logger

* use builder logger in the sketLibrariesDetector

* replace context Info logger with BuilderLogger

* replace context Warn logger with BuilderLogger

* replace context WriteStdout logger with BuilderLogger

* replace context WriteStderr logger with BuilderLogger

* directly pass the BuilderLogger to RecipeByPrefixSuffixRunner func

* directly pass the BuilderLogger to part2

* directly pass the BuilderLogger to Linker func

* directly pass the BuilderLogger to sizer.Size func

* remove Stdout, Stderr and stdlock from Context

* appease golint

* add missinig license headers

* remove WarningsLevel from context

* remove Verbose from context

* Fixed weird error message in 'core install' if invalid platform is specified

* Fixed integration test

* refactor RecipeRunner in a function

* refactor CreateBuildOptionsMap in a function

* refactor LoadPreviousBuildOptionsMap in a function

* refactor StoreBuildOptionsMap in a function

* refactor WipeoutBuildPathIfBuildOptionsChanged in a function

* refactor ContainerBuildOptions in a function

* refactor MergeSketchWithBootloader in a function

* refactor PrintUsedLibrariesIfVerbose in a function

* refactor UnusedCompiledLibrariesRemover in a function

* refactor WarnAboutArchIncompatibleLibraries in a function

* refactor CreateMakeRule in a function

* move include finder with regex tests under detector

* move jobs properites in arduino/builder component

* remove sketch property from context

* apply CR suggestion

* Slightly de-entangled makeSourceFile

* Moved some initializations directly into NewBuilder

* Pruned constants

* Pruned more constants

* Fixed lint warnings

* remove unused LibraryDir from legacy context

* remove unused WatchedLocation from legacy context

* remove unused IgnoreSketchFolderNameErrors from legacy context

* remove CanUseCachedTools from legacy context

* remove UseArduinoPreprocessor from legacy context

* make the CoreBuilder command a function

* remove the use of context from builder_utils

* mvoe types.ProgressStruct in a dedicated pkg

* move ExecCommand under arduino/utils

* move LogIfVerbose from utils to legacy builder

* move some legacy constans in builder package

* move builder_utils under arduino/builder/utils pkg

* appease golint

* move coreBuildCachePath in the arduino Builder

* refactor Linker command in a function

* refactor SketchBuilder in a function

* refactor LibrariesBuilder in a function

* refactor Sizer in a function

* remove empty file

* remove unused struct FailIfBuildPathEqualsSketchPath

* Ported TestCoreCaching to current integration test infra

* Removed useless TestBuilderEmptySketch

The same features are already tested in a number of other integration tests.

* Ported TestBuilderWithBuildPathInSketchDir to current integration test infra

* Ported TestLoadHardware to current integration test infra

* Moved user_hardware testdata resources

* Ported TestLoadHardwareMixingUserHardwareFolder to current integration test infra

* Removed redundant legacy tests

* Removed useless 'sleep' helper function

* Removed unused LoadAndInterpolate function

* Removed useless NoError helper function

* Grouped tests inside the same correct sub-group

* Ported TestFailIfBuildPathEqualsSketchPath and TestFailIfBuildPathEqualsSketchPathSketchPathDiffers to current integration test infra

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.32 to 3.1.34.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.32...3.1.34)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Simplified compileFiles

* Starting new Builder (part 1/n)

* builder: renamed variable and moved dir creation up

* builder: made a sketch-prepress function part of Builder

* Removed ctx dependency in PreprocessSketchWithArduinoPreprocessor

* uniform parameters between preprocesors

* Moved PreprocessSketchWithArduinoPreprocessor into proper place

* Inlined function

* Converted sketchCopyAdditionalFiles into a Builder method

* Made SetupBuildProperties a method of the new Builder

* Refactor AddAdditionalEntriesToContext

https://github.com/cmaglie/arduino-cli/pull/32

* refactor AddAdditionalEntriesToContext in a function

* use the new function in all the tests

* Move the assignaton of LibrariesResolutionResults inside the ResolveLibrary func

The ResolveLibrary func is only called by the ContainerFindIncludes

* rename bPath to buildPath

* cleanup usless tests

* remove shadowed variable

* Refactor legacy LibrariesLoader command

* move LibrariesLoader under arduino/builder

* remove usless nil check

* remove AddAdditionalEntries func, in favour of initializing them in the compile command

* move a check directly in the compile command

* create the SketchLibrariesDetector struct

* move all the logic of ContainerSetupHardwareToolsLibsSketchAndProps in the compile command

* remove container_setup and adjust relative tests

* remove LibraryResolver property from context

* remove UseCachedLibrariesResolution for context

* remove ImportedLibraries from context

* remove LibrariesResolutionResults from context

* remove LibrariesManager from context

* fix regression exceeding 100% status bar

* refactor find_includes

* refactoring the cmd.Exec in favour of executils

* use detector FindIncludes in tests

* add comments and make some plubic methods private

---------
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

* Change GetPort's returned type to rpc.Port

* Use LoadSketch in runUploadCommand