GitLab

Terminate daemon command when parent process exits; added "--daemonize" flag to keep old behaviour (#488)

* daemon: terminate on parent process ending; added --daemonize flag

This is useful when the cli daemon is launched from an external process
to avoid leaving zombie process if the parent process unexpectedly dies.

If daemonization (so no stdin/stdout) is the intended behaviour the
--daemonize flag must be used.

* (cosmetic) reorganized runDaemonCommand in a more straighforward way

* add an option to show all the versions

* add all_versions option to the rpc proto

* clean up code + docs

* added integration tests

When build-path and cache-path are on different partitions it will not
be possible (on windows) to reference them with a relative path.
This commit allows this by automatically disabling the aggressive core
caching.

Previously an error was emitted and the build interrupted.

Fix #469

* Fixed nil exception on some rare case with multiple libs selection

The closestmatch algorithm may return 'nil' if none of the candidate
libraries has enough matching of the name. In this case just return the
first library in alphanumeric ordering.

See https://github.com/arduino/Arduino/issues/9242

* Run of go mod tidy

* Fixed typo

This also adds some documentation showing how this works.

* Board identification: always check vid.1/pid.1

Even if vid.0/pid.0 is missing.

Fix #456

* Renamed 'again'->'present' and 'found'->'matched' for clarity

It seems that the package bou.ke/monkey is no longer supported with the
lastest macosx (it fails with a Permission denied error).

* Add tests for ResolveFQBN

This adds tests for ResolveFQBN (which returns more details than the
FindBoardWithFQBN that was already tested), but also adds an extra
boards.txt with boards that are derived from another platform/core (i.e.
have `build.core=package:core`.

These new tests are currently failing, because of a bug and insufficient
error handling, which will be fixed in subsequent commits.

* Fix resolution of referenced cores

A core is referenced by specifying `build.core=package:core` in board
properties. However, the code used the second part (core) both for
looking up the the package, as well as for the core to use from that
package. The most commonly used core reference is `arduino:arduino`
which works because both parts are identical, which is probably why this
bug has not shown up before.

This commit fixes the bug by simply using the right part to look up the
package.

* Improve error message when referencing missing package

This used to say e.g.

	missing platform adafruit:referenced:avr required for build

where two packagenames (adafruit and referenced) were joined together
which makes no sense. Now, it just mentions the missing package, and the
fqbn that references it.

* Fix segfault when referenced platform is missing

Before, when a platform was referenced through a `build.core` and the
package was present by the platform/architecure was missing, a
nullpointer was passed to GetInstalledPlatformRelease, which would
segfault.

Now, a proper error message is returned.

* add testcases to cover https://github.com/arduino/arduino-cli/issues/358 (Symbolic link as sketch directory) and https://github.com/arduino/arduino-cli/issues/424 (folder with .ino extension)

* add test to check error throw on symlink loop detection

* create symlink via test code to ensure cross platform creation

* fixed assert to make the check cross platform

* fixed all symlink check asserts to make the check cross platform

* nitpicking

* Use a local Walk function

Because arduino-cli segfaults when sketchDir is a symbolic link, a simple
walk function is introduced with a twofold effect:
- fix the segfault
- allow to use symlinks

ref: https://www.google.com/search?q=golang+Walk+does+not+follow+symbolic+links

* tabs

* style

* comment

* retrigger CI

* retrigger CI

* style

* check sketch for being a file

* check sketch is not a directory

* additions:
- act on error in walk function (OS can detect symbolic links loops (lnk -> lnk))
- add a deepness detector for non trivial loops (dir/lnk -> ../..)

* fixes from "task check"

* updates per review

* style

* Update arduino/builder/sketch.go
Co-Authored-By: Roberto Sora <r.sora@arduino.cc>

* fixes

* Copy multiple build artifacts matching a name pattern.

Previously the compile command copied only the following artifacts:

  sketch.ino.hex (or .bin)
  sketch.ino.elf

now also the files matching the glob sketch.ino.*.hex will be copied.
This allows for some 3rd party core (like esp32) to copy also the extra
file sketch.ino.partitions.bin.

Should fix #163

* Added test for improved support for esp32:esp32

https://github.com/arduino/arduino-cli/issues/163

* Run of "go mod tidy"

* [skip changelog] Force windows env to use cmd as shell instead of powershell

* temporarly enable only windows for test flow

* moved up cmd default shell for windows at job level

* revert and enable all

* disable macos

* force use of cmd on windows only for go getting dependencies

* typo

* typo

* test using `bash` as default shell

* cleanup task and comment

* run tests on osx

* use latest version of the action

* pass github token

* Do not try to identify non-usb ports via vid/pid

* Added test TestBoardDetectionViaAPIWithNonUSBPort

Change "Alredy" to "Already"

* fix install instructions

* [ci skip] fix header

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
Co-Authored-By: Edoardo T <endorama@users.noreply.github.com>

* Update README.md
Co-Authored-By: Roberto Sora <r.sora@arduino.cc>

* avoid calling cloud API if vid or pid are invalid

* user regex

The "new name" given in the error message is not correct - the new file name seems to be arduino-cli.yaml

`[  ... == ...  ]` is Bash extension. install.sh should use syntax of
standard `test` command.

To increase thread-safery and allow adding extra headers if needed.

* bump go version in client go.mod

* fix help strings

* differentiate dataDir folders

* Fixed library-cache-miss regression

* Changed 'includeCacheEntry' field to pointer type

This allows a better memory management and avoids struct copy
operations.

Some boards do not produce elf file intermediate (i.e those that use
build.preferred_export_format=axf or the like).  This changes the
logic so that it's not an error for and elf file to be missing.