GitLab

Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>

* Removed go.mod from client_example

* Removed go.mod from docsgen

* Refactored discovery client and removed now useless go.mod files

* Updated license cache

* Upgraded some dependencies to fix dependabot alerts

The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames.

The origin of the specification is the text of the error message shown in Arduino IDE when the user attempts to save to
a name that contains disallowed characters:

https://github.com/arduino/Arduino/blob/89539b1131f8cde9f7a83225f21c811071af53a8/app/src/processing/app/SketchController.java#L847-L853

However, the implementation of the restriction in the IDE codebase has a bug that allows a leading underscore (because
the code uses _ as the replacement character).

After the restriction was implemented correctly in Arduino IDE 2.x, it was discovered that the loss of compatibility
with these non-compliant names was impactful.

One of the primary purposes for the specification and restrictions is to ensure sketches can be used in any tool. Since
the tools support this name format and there is no technical reason to disallow it, the best thing to do is change the
sketch specification to follow the historic tool behavior (even if that behavior was the result of a benign bug).

Leading underscores in sketch folder names and sketch code filenames are hereby permitted by the Arduino Sketch
Specification and `arduino-cli sketch new`.

* Added flag to LibrarySearchRequest gRPC API to reduce response output

* Added --omit-releases-details flag in 'lib search'

* Added integration test for #1698

* Added helper functions to handle concurrent writes to ctx.Stdout/Stderr

* Do not alter ctx.Stderr/Stdout in ExecCommand

Some instances of ctx.Stdout may now contains nil since it's no more
altered during ExecCommand.

* Handle multi-threaded compile streams

[skip-changelog] Fix string indexing in `tool not available for the current os` error message (#2099)

* Add instructions on how to contact the package manager to error message

* Add TestCoreBrokenDependency to core_test.go

* Moved 'build.fqbn' and 'build.arch' properties generation

* Moved some runtime build path properties to proper function

* Factored tools runtime properties generation

* Factored subroutine for time-related properties generation

* Made the referenced-core determination a bit more readable

Equivalent change, should not change behaviour

* Factored 'build.variant' and related properties calculation

* Removed useless state variable 'BuildCore'

* Refactoring of some legacy properties generation subroutines

* Refactored generation of 'software' build property

* Refactored build properties overlaying logic

* Refactored custom global properties handling

* Moved corePlatform and variantPlatform determination inside a specific method

[skip-changelog] Handle repeated builds of a sketch when `--build-path` target is in the sketch directory (#2084)

* Handle repeated builds of a sketch when the build path is inside the sketch directory

* Add TestCompileBuildPathInsideSketch to compile_test.go

Co-authored-by: per1234 <accounts@perglass.com>

[skip-changelog] Modify `board search --help` description to correctly explain the command's function (#2081)

The "gPRC Reference" section of the documentation website is automatically generated from the code and comments in the
project's Protocol Buffers files. The documentation is automatically structured according to the structure of the
Protocol Buffers code using heading levels, and the documentation website uses these heading levels to generate a table
of contents to allow easy navigation of the documentation and an overview of its structure.

The generation happens in two steps:

Protocol Buffers -> Markdown -> HTML

A comment in a Protocol Buffers file included a decorative underline formed from a series of `-` characters. This
happens to be markup for an H2 heading in the Markup language. This caused an inadvertent creation of an inappropriate
heading named "BOOTSTRAP COMMANDS", which resulted in the documentation having the following incorrect structure:

- Protocol Documentation
  - [...]
  - cc/arduino/cli/commands/v1/board.proto
    - [...]
  - cc/arduino/cli/commands/v1/commands.proto
    - [...]
    - ArduinoCoreService
  - BOOTSTRAP COMMANDS
    - <List of cc.arduino.cli.commands.v1.ArduinoCoreService methods>
  - cc/arduino/cli/commands/v1/common.proto
    - [...]
  - [...]

Instead of the correct structure:

- Protocol Documentation
  - [...]
  - cc/arduino/cli/commands/v1/board.proto
    - [...]
  - cc/arduino/cli/commands/v1/commands.proto
    - [...]
    - ArduinoCoreService
      - <List of cc.arduino.cli.commands.v1.ArduinoCoreService methods>
  - cc/arduino/cli/commands/v1/common.proto
    - [...]
  - [...]

This could be corrected by removing only the pointless decorative comment, leaving the "BOOTSTRAP COMMANDS" comment, but
I don't see any value in that comment and it introduced unpleasant caps lock prose content into the documentation so I
removed it as well.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add post install script support for tools

* Add TestCoreInstallRunsToolPostInstallScript to core_test.go

* Document changes in UPGRADING.md

* In download query, report if a library is builtin

* 'lib download' flag vars are now local

* Added --install-in-builtin-dir flag in 'lib install'

* Added missing file extensions from sketch specification

* Update docs/sketch-specification.md
Co-authored-by: per1234 <accounts@perglass.com>

---------
Co-authored-by: per1234 <accounts@perglass.com>

* cli: use cached index with lib search (#1624)

* remove comment on default cache timeout (maintenance smell)

* Simplify code applying minor changes

---------
Co-authored-by: ardnew <andrew@ardnew.com>

* Added 'hardwareId' support to pluggable discovery

* Added hardwareId output in 'board list -w' too

* Update docs/pluggable-discovery-specification.md
Co-authored-by: Luca Bianconi <71259950+Bikappa@users.noreply.github.com>

---------
Co-authored-by: Luca Bianconi <71259950+Bikappa@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Do not show available updates with `version` if `updater.enable_notification` is set to `false` (#2055)

* [skip changelog] Updated the deprecated ioutil dependency

* Resolved the go fmt violation that causes the check go CI workflow run failure

* Removed the typo grave accent from ctags_parser_test

* Removed the arbitrary fs.FileInfo array and its iterations in legacy/builder/utils/utils.go

ctags can fail, for example if TMPDIR is unset. It aids debugging to show the stderr with -v if that's the case

* Add prioritization to tool selection in absence of explicit dependencies

* Made tests working on windows too

* Updated docs

* Added tool selection from referenced platform

* Added some explanatory comments

* Moved integration tests into 'compile_3' group

Co-authored-by: per1234 <accounts@perglass.com>

* Removed builderCtx.BuildCachePath

Because it creates a lot of confusion

* Removed useless assignment

* Do not store sketch build-path but generate it on demand

* Removed redundant SketchLocation field and related subroutines

* Replaced deprecated calls (from go linter)

* Remove `ip` flag from daemon command

* Update UPGRADING.md