GitLab

* fix regression on board attach

* fix integration tests

* Improve error message on build failure
* properly report an error message

* remove error checking on unused proto field, added deprecation comment

* fix typo in function name

* do not os.exit in library code

* create data dir tree if it doesnt exist

* rename Sketchbook folder to User

* missing join on path

* define proto messages and service

* run protoc on settings interface, regenerate code

* add service implementation and tests

* remove test leftovers

* use pip-tools, bump packages to support 3.8

* Bump Python to 3.8 in the CI environment

* add test for #443

* return an empty json array when there are no libs

Fix the inconsistent name of libraries when installing
and uninstalling.

* dump all settings

* init config file using viper

* remove configs package

* use viper API

* default url shouldnt be added to additional_urls

* map log settings to config file

* do not use logging before it's ready

* look for project wide config file

* Update go-serial library to latest version

Includes a fix to serial.Read method.

Should fix: https://github.com/arduino/arduino-cli/issues/504

Actual patch: https://github.com/bugst/go-serial/pull/69

* Using versioned release of go.bug.st/serial

* extend search fields for libs, added tests

* adjust tests

When only specifying folder, the logic will try both <DirName>.ino and
<DirName>.pde as the main sketch file. If both are found, and error is
also thrown (it would break on compile later on).

Added couple of unit tests also.
Signed-off-by: Lluis Campos <lluis.campos@northern.tech>

* Added infrastructure to handle 'dependency' field in library index

* Added globals.ParseLibraryReferenceArgs method

* Added check for missing library version/name in args

* Added check for missing core/arch/version in core arg parsing

* 100% test coverage for librariesindexer module

* Added grpc call LibraryResolveDependencies (WIP)

This is just the body of the call, no implementation yet.

* Use semver.Dependency interface to represent a library dependency

* Added library-dep resolution function in core modules

* Added implementation for LibraryResolveDependency grpc call

* Implementation of deps install in 'lib install' command

* Added no-deps flag in lib install command

* Added lib deps command

* Replace asciilogo.txt with donwlodads index.html as a test resource

* Remove prints and re-enable test pieces

* Fix file size

Terminate daemon command when parent process exits; added "--daemonize" flag to keep old behaviour (#488)

* daemon: terminate on parent process ending; added --daemonize flag

This is useful when the cli daemon is launched from an external process
to avoid leaving zombie process if the parent process unexpectedly dies.

If daemonization (so no stdin/stdout) is the intended behaviour the
--daemonize flag must be used.

* (cosmetic) reorganized runDaemonCommand in a more straighforward way

* add an option to show all the versions

* add all_versions option to the rpc proto

* clean up code + docs

* added integration tests

When build-path and cache-path are on different partitions it will not
be possible (on windows) to reference them with a relative path.
This commit allows this by automatically disabling the aggressive core
caching.

Previously an error was emitted and the build interrupted.

Fix #469

* Fixed nil exception on some rare case with multiple libs selection

The closestmatch algorithm may return 'nil' if none of the candidate
libraries has enough matching of the name. In this case just return the
first library in alphanumeric ordering.

See https://github.com/arduino/Arduino/issues/9242

* Run of go mod tidy

* Fixed typo

This also adds some documentation showing how this works.

* Board identification: always check vid.1/pid.1

Even if vid.0/pid.0 is missing.

Fix #456

* Renamed 'again'->'present' and 'found'->'matched' for clarity

It seems that the package bou.ke/monkey is no longer supported with the
lastest macosx (it fails with a Permission denied error).

* Add tests for ResolveFQBN

This adds tests for ResolveFQBN (which returns more details than the
FindBoardWithFQBN that was already tested), but also adds an extra
boards.txt with boards that are derived from another platform/core (i.e.
have `build.core=package:core`.

These new tests are currently failing, because of a bug and insufficient
error handling, which will be fixed in subsequent commits.

* Fix resolution of referenced cores

A core is referenced by specifying `build.core=package:core` in board
properties. However, the code used the second part (core) both for
looking up the the package, as well as for the core to use from that
package. The most commonly used core reference is `arduino:arduino`
which works because both parts are identical, which is probably why this
bug has not shown up before.

This commit fixes the bug by simply using the right part to look up the
package.

* Improve error message when referencing missing package

This used to say e.g.

	missing platform adafruit:referenced:avr required for build

where two packagenames (adafruit and referenced) were joined together
which makes no sense. Now, it just mentions the missing package, and the
fqbn that references it.

* Fix segfault when referenced platform is missing

Before, when a platform was referenced through a `build.core` and the
package was present by the platform/architecure was missing, a
nullpointer was passed to GetInstalledPlatformRelease, which would
segfault.

Now, a proper error message is returned.

* add testcases to cover https://github.com/arduino/arduino-cli/issues/358 (Symbolic link as sketch directory) and https://github.com/arduino/arduino-cli/issues/424 (folder with .ino extension)

* add test to check error throw on symlink loop detection

* create symlink via test code to ensure cross platform creation

* fixed assert to make the check cross platform

* fixed all symlink check asserts to make the check cross platform

* nitpicking

* Use a local Walk function

Because arduino-cli segfaults when sketchDir is a symbolic link, a simple
walk function is introduced with a twofold effect:
- fix the segfault
- allow to use symlinks

ref: https://www.google.com/search?q=golang+Walk+does+not+follow+symbolic+links

* tabs

* style

* comment

* retrigger CI

* retrigger CI

* style

* check sketch for being a file

* check sketch is not a directory

* additions:
- act on error in walk function (OS can detect symbolic links loops (lnk -> lnk))
- add a deepness detector for non trivial loops (dir/lnk -> ../..)

* fixes from "task check"

* updates per review

* style

* Update arduino/builder/sketch.go
Co-Authored-By: Roberto Sora <r.sora@arduino.cc>

* fixes