- 08 Feb, 2023 2 commits
-
-
MatteoPologruto authored
-
Luca Bianconi authored
-
- 07 Feb, 2023 1 commit
-
-
github-actions[bot] authored
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
-
- 06 Feb, 2023 1 commit
-
-
Luca Bianconi authored
-
- 02 Feb, 2023 1 commit
-
-
MatteoPologruto authored
-
- 01 Feb, 2023 2 commits
-
-
MatteoPologruto authored
Do not show available updates with `version` if `updater.enable_notification` is set to `false` (#2055)
-
Zachary Walters authored
* [skip changelog] Updated the deprecated ioutil dependency * Resolved the go fmt violation that causes the check go CI workflow run failure * Removed the typo grave accent from ctags_parser_test * Removed the arbitrary fs.FileInfo array and its iterations in legacy/builder/utils/utils.go
-
- 31 Jan, 2023 2 commits
-
-
Bouke van der Bijl authored
ctags can fail, for example if TMPDIR is unset. It aids debugging to show the stderr with -v if that's the case
-
Cristian Maglie authored
* Add prioritization to tool selection in absence of explicit dependencies * Made tests working on windows too * Updated docs * Added tool selection from referenced platform * Added some explanatory comments * Moved integration tests into 'compile_3' group
-
- 30 Jan, 2023 2 commits
-
-
Luca Bianconi authored
-
Luca Bianconi authored
Co-authored-by: per1234 <accounts@perglass.com>
-
- 27 Jan, 2023 1 commit
-
-
Cristian Maglie authored
* Removed builderCtx.BuildCachePath Because it creates a lot of confusion * Removed useless assignment * Do not store sketch build-path but generate it on demand * Removed redundant SketchLocation field and related subroutines * Replaced deprecated calls (from go linter)
-
- 24 Jan, 2023 2 commits
-
-
MatteoPologruto authored
* Remove `ip` flag from daemon command * Update UPGRADING.md
-
Zachary Cushon authored
-
- 19 Jan, 2023 2 commits
-
-
Luca Bianconi authored
-
MatteoPologruto authored
-
- 17 Jan, 2023 2 commits
-
-
Cristian Maglie authored
* Added function to create buffering streams * Moved the direct output of build properties to commands.Compile * BuildProperties are now returned as part of Compile response * Build properties are now displayed alone if running in text mode * Fixed wrong error report * Added integration test * Small improvement on result output
-
MatteoPologruto authored
* Add query parameters to urls generated by lib commands * Add test to check query parameters * Fix comments on functions to make them clearer
-
- 16 Jan, 2023 1 commit
-
-
Cristian Maglie authored
[breaking] Fixed a lot of `--format json` and, in general, how Arduino CLI output is handled (#2003) * Added source code static-check to enforce `--format` output. The first test run gives: === RUN TestNoDirectOutputToStdOut burnbootloader/burnbootloader.go:85:5: object `os.Stdout` should not be used in this package (use `feedback.*` instead) burnbootloader/burnbootloader.go:85:16: object `os.Stderr` should not be used in this package (use `feedback.*` instead) compile/compile.go:235:84: object `os.Stdout` should not be used in this package (use `feedback.*` instead) compile/compile.go:235:95: object `os.Stderr` should not be used in this package (use `feedback.*` instead) compile/compile.go:274:72: object `os.Stdout` should not be used in this package (use `feedback.*` instead) compile/compile.go:274:83: object `os.Stderr` should not be used in this package (use `feedback.*` instead) compile/compile.go:296:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:297:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:298:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:305:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:306:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:307:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:308:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:309:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:311:3: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:313:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:319:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:321:5: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:325:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) compile/compile.go:326:4: function `fmt.Print` should not be used in this package (use `feedback.*` instead) completion/completion.go:58:34: object `os.Stdout` should not be used in this package (use `feedback.*` instead) completion/completion.go:61:38: object `os.Stdout` should not be used in this package (use `feedback.*` instead) completion/completion.go:63:32: object `os.Stdout` should not be used in this package (use `feedback.*` instead) completion/completion.go:66:32: object `os.Stdout` should not be used in this package (use `feedback.*` instead) completion/completion.go:68:38: object `os.Stdout` should not be used in this package (use `feedback.*` instead) daemon/interceptors.go:29:19: object `os.Stdout` should not be used in this package (use `feedback.*` instead) debug/debug.go:106:82: object `os.Stdout` should not be used in this package (use `feedback.*` instead) monitor/term.go:38:9: object `os.Stdout` should not be used in this package (use `feedback.*` instead) output/rpc_progress.go:115:4: function `fmt.Print` should not be used in this package (use `feedback.*` instead) output/rpc_progress.go:117:5: function `fmt.Println` should not be used in this package (use `feedback.*` instead) output/rpc_progress.go:119:5: function `fmt.Println` should not be used in this package (use `feedback.*` instead) upload/upload.go:163:5: object `os.Stdout` should not be used in this package (use `feedback.*` instead) upload/upload.go:163:16: object `os.Stderr` should not be used in this package (use `feedback.*` instead) cli.go:215:4: function `fmt.Println` should not be used in this package (use `feedback.*` instead) --- FAIL: TestNoDirectOutputToStdOut (0.01s) FAIL exit status 1 FAIL github.com/arduino/arduino-cli/cli 0.019s * Slightly improved naming/docs of OutputFormat enumeration Also changed a condition in a more meaningful way. * Removed `feedback.Feedback` since only the global instance is used We may think of bringing it back again in the future if the global instance will be removed in a major refactoring of the CLI. * Moved `cli/output` package into `cli/feedback` This is the better place where it belongs, and slighlty simplifies the golang API. * Print progress bar and task progess only on interactive terminals * Use feedback functions to output task progress * User-input functions are now moved into `feedback` package * Fix user-input function - Final "\n" is automatically printed when entering non-passwords (no need to do a Println() - The final "\n" is included in the result of ReadBytes() so it will be removed. * Added cmd to test feedback functions * Better error message * Removed unprotected print * Removed useless response from Upload and UploadWithProgrammer * VersionInfo now implements feedback.Result interface * Added `feedback` support for direct streaming When the Text format is selected the output is sent straigh to the output stream, otherwise it is buffered and returned as a `feedback.Result` to be used at the end of the job. * Replace direct use of os.Stdout/Stderr in Upload command * Implemented feedback.Fatal and FatalError These functions outputs the error (also in machine-encoded if user choose to do so) and at the same time exits with os.Exit(). This API is much more readable and provides a better meaning to the CLI commands implementation. * Added output buffers in error messages (if used) * Removed direct access to stdio streams in monitor command * Removed direct access to stdio streams in debug command * Removed direct access to stdio streams in daemon command * Removed direct access to stdio streams in burn-bootlodaer command * Removed direct access to stdio streams in compile command * Removed direct access to stdio streams in completion command * compile: print platforms stats only if present * Removed direct access to stdio streams in --dump-profile command * Added feedback functions to report warnings * Moved `errorcodes` into `feedback` * Remove direct os.Stdin access from daemon command * Removed redundant `cli/globals` package This will help later to make the whole `cli` package internal. * Made `cli` package internal * updated docs * Removed redundant logic in getter for stdio streams Co-authored-by: per1234 <accounts@perglass.com> * Internationalize more strings Co-authored-by: per1234 <accounts@perglass.com> * Spellcheck internal/cli/feedback/stdio.go Co-authored-by: per1234 <accounts@perglass.com> * Spellcheck internal/cli/feedback/feedback_cmd.go Co-authored-by: per1234 <accounts@perglass.com> * feedback: remove stray '\r' on Windows on interactive input * Ban use of os.Exit from cli package * Removed unused parameter in compile.Compile * Non-interactive stream are always buffered * Use direct streams where appropiate * Compile outputs profile dump as part of the result * Report saved warnings also when erroring out * Print compile error and suggestions as part of the result * Add trailing newline only if compiler has produced output * FatalResult now outputs the error on stderr Co-authored-by: per1234 <accounts@perglass.com>
-
- 12 Jan, 2023 2 commits
-
-
Cristian Maglie authored
* Upgraded extract to v3.1.0 * Updated docs
-
dependabot[bot] authored
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.29 to 3.1.30. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.29...3.1.30) --- updated-dependencies: - dependency-name: gitpython dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- 10 Jan, 2023 1 commit
-
-
Giuliano Panzironi authored
Fix #2028 Any temporary file will be persisted in a new dedicated folder named as "arduino" located in the OS-specific temporary directory, e.g.: /tmp/ ├── arduino │ ├── arduino-core-cache │ │ └── core_arduino_avr_uno_640aa5b4d646262327bbea65c3462b39.a │ └── arduino-sketch-89E1544CF5F196B29E530BA6940B661F │ ├── 06.ino.elf │ ├── 06.ino.with_bootloader.bin │ ├── build.options.json │ ├── compile_commands.json │ ├── core │ │ ├── abi.cpp.d [...] This change is meant to make easier maintenance operations for both end-users and operating-systems. Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
-
- 05 Jan, 2023 1 commit
-
-
Luca Bianconi authored
-
- 04 Jan, 2023 1 commit
-
-
Luca Bianconi authored
-
- 03 Jan, 2023 2 commits
-
-
Luca Bianconi authored
-
Luca Bianconi authored
-
- 21 Dec, 2022 1 commit
-
-
MatteoPologruto authored
* Show bundled libs when `-b` flag is used * Modify test_lib.go to test the changes
-
- 19 Dec, 2022 2 commits
-
-
MatteoPologruto authored
* Add online help field to rpc platform * Add online help field to the output of `core search --format json` * Add tests for the changes
-
per1234 authored
For efficiency, the "Test Go" GitHub Actions workflow splits the test suite into multiple jobs which run in parallel. This is done via a "job matrix". By default GitHub Actions uses a "fail fast" behavior for job matrixes, where all in progress or pending jobs of the matrix are immediately canceled upon failure of any job. The benefit of this "fail fast" behavior is efficiency in the case where a failure is universal and those other jobs were certain to eventually fail. However, in other cases a failure is either specific to the configuration of a single job (e.g., a Windows-specific bug), or a spurious result of a transient network outage. In the latter case, canceling the other jobs is very harmful. Running the jobs for the other operating systems would highlight the nature of an OS-specific failure for the contributor. Canceling other jobs due to a transient failure means all those jobs must be reran instead of only the specific job that suffered the failure. The workflow is hereby configured to disable the "fail fast" behavior. All the matrix jobs will now run even if one of them has failed.
-
- 16 Dec, 2022 2 commits
-
-
MatteoPologruto authored
-
MatteoPologruto authored
* Remove python testsuite and the related workflows * Update documentation according to the removal of the python testsuite * Remove `check-python-task` and the related unused dependencies
-
- 14 Dec, 2022 1 commit
-
-
MatteoPologruto authored
* Migrate TestUpload from test_upload.py to upload_test.go * Migrate TestUploadWithInputDirFlag from test_upload.py to upload_test.go * Migrate TestUploadWithInputFileFlag from test_upload.py to upload_test.go * Migrate TestCompileAndUploadCombo from test_upload.py to upload_test.go * Migrate TestCompileAndUploadComboWithCustomBuildPath from test_upload.py to upload_test.go * Migrate TestCompileAndUploadComboWithPdeExtension from test_upload.py to upload_test.go * Migrate TestUploadSketchWithPdeExtension from test_upload.py to upload_test.go * Migrate TestUploadWithInputDirContainingMultipleBinaries from test_upload.py to upload_test.go * Migrate TestCompileAndUploadComboSketchWithMismatchedCasing from test_upload.py to upload_test.go * Migrate TestUploadSketchWithMismatchedCasing from test_upload.py to upload_test.go * Migrate TestUploadToPortWithBoardAutodetect from test_upload.py to upload_test.go * Migrate TestCompileAndUploadToPortWithBoardAutodetect to upload_test.go and delete test_upload.py
-
- 13 Dec, 2022 1 commit
-
-
MatteoPologruto authored
* Migrate TestLibExamplesWithCaseMismatch from test_lib.py to lib_test.go * Migrate TestLibCommandsWithLibraryHavingInvalidVersion from test_lib.py to lib_test.go * Migrate TestInstallZipLibWithMacosMetadata from test_lib.py to lib_test.go * Migrate TestInstallZipInvalidLibrary from test_lib.py to lib_test.go * Migrate TestInstallGitInvalidLibrary from test_lib.py to lib_test.go * Migrate TestUpgradeDoesNotTryToUpgradeBundledCoreLibrariesInSketchbook from test_lib.py to lib_test.go * Migrate TestUpgradeDoesNotTryToUpgradeBundledCoreLibraries from test_lib.py to lib_test.go * Migrate TestInstallGitUrlAndZipPathFlagsVisibility from test_lib.py to lib_test.go * Migrate TestInstallWithZipPath from test_lib.py to lib_test.go * Migrate TestInstallWithZipPathMultipleLibraries from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlLocalFileUri to lib_test.go and delete test_lib.py * Improve style and readability
-
- 12 Dec, 2022 1 commit
-
-
MatteoPologruto authored
* Migrate TestUninstallSpaces from test_lib.py to lib_test.go * Migrate TestLibOpsCaseInsensitive from test_lib.py to lib_test.go * Migrate TestSearch from test_lib.py to lib_test.go * Migrate TestSearchParagraph from test_lib.py to lib_test.go * Migrate TestLibListWithUpdatableFlag from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlFromCurrentDirectory from test_lib.py to lib_test.go * Migrate TestInstallWithGitLocalUrl from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlRelativePath from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlDoesNotCreateGitRepo from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlMultipleLibraries from test_lib.py to lib_test.go * Migrate TestLibExamples from test_lib.py to lib_test.go * Migrate TestLibExamplesWithPdeFile from test_lib.py to lib_test.go
-
- 09 Dec, 2022 3 commits
-
-
dependabot[bot] authored
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.5.18.1 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](https://github.com/certifi/python-certifi/compare/2022.05.18.1...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Cristian Maglie authored
* Updated go-paths-helper to v1.8.0 * Pass of go-fmt * Removed unused functions * Removed dep golang.org/x/crypto/ssh/terminal in favor of golang.org/x/term * Fixed wrong error message
-
Cristian Maglie authored
-
- 07 Dec, 2022 2 commits
-
-
per1234 authored
The "Check Certificates" GitHub Actions workflow uses OpenSSL to check for problems with the project's signing certificates. Certificates exported to PKS #12 archive files using older tools may have been encrypted using the "RC2-40-CBC" algorithm. Due to the availability of more secure modern alternatives, default support for RC2-40-CBC encryption was dropped in OpenSSL 3.x. The macOS signing certificate uses this RC2-40-CBC encryption. The "Check Certificates" GitHub Actions workflow runs on the `ubuntu-latest` runner. Previously, this runner used Ubuntu 20.04. This has now changed to Ubuntu 22.04. With the operating system update came an OpenSSL update from 1.1.1f to 3.0.2. This caused the workflow runs to fail on the macOS certificate job: Error outputting keys and certificates 80FBB0C5087F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../crypto/evp/evp_fetch.c:349:Global default library context, Algorithm (RC2-40-CBC : 0), Properties () Even though no longer done by default, OpenSSL still supports RC2-40-CBC encryption via its "legacy" provider. So compatibility with the certificate is restored by adding the `-legacy` flag to the `openssl pkcs12` commands.
-
MatteoPologruto authored
* Avoid running publish-go-tester-task if tag is set * Update .github/workflows/publish-go-tester-task.yml Co-authored-by: per1234 <accounts@perglass.com> * Update .github/workflows/publish-go-tester-task.yml Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: per1234 <accounts@perglass.com>
-
- 02 Dec, 2022 1 commit
-
-
MatteoPologruto authored
* Migrate TestList from test_lib.py to lib_test.go * Migrate TestListExitCode from test_lib.py to lib_test.go * Migrate TestListWithFqbn from test_lib.py to lib_test.go * Migrate TestListProvidesIncludesFallback from test_lib.py to lib_test.go * Migrate TestLibDownload from test_lib.py to lib_test.go * Migrate TestInstall from test_lib.py to lib_test.go * Migrate TestInstallLibraryWithDependencies from test_lib.py to lib_test.go * Migrate TestInstallNoDeps from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrl from test_lib.py to lib_test.go * Migrate TestInstallWithGitUrlFragmentAsBranch from test_lib.py to lib_test.go * Migrate TestUpdateIndex from test_lib.py to lib_test.go * Migrate TestUninstall from test_lib.py to lib_test.go * Reduce quoting using verbatim strings and improve jq queries Co-authored-by: Cristian Maglie <c.maglie@bug.st> Co-authored-by: Cristian Maglie <c.maglie@bug.st>
-