Unverified Commit ffb3d2f7 authored by MatteoPologruto's avatar MatteoPologruto Committed by GitHub

[skip-changelog] Fix failing board tests (#2222)

* Fix failing board tests after package index updates

* Remove duplicate test
parent 642996ff
...@@ -124,30 +124,6 @@ func TestBoardListWithFqbnFilterInvalid(t *testing.T) { ...@@ -124,30 +124,6 @@ func TestBoardListWithFqbnFilterInvalid(t *testing.T) {
requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`) requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`)
} }
func TestBoardListWithInvalidDiscovery(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()
_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)
_, _, err = cli.Run("board", "list")
require.NoError(t, err)
// check that the CLI does not crash if an invalid discovery is installed
// (for example if the installation fails midway).
// https://github.com/arduino/arduino-cli/issues/1669
toolDir := cli.DataDir().Join("packages", "builtin", "tools", "serial-discovery")
dirsToEmpty, err := toolDir.ReadDir()
require.NoError(t, err)
require.Len(t, dirsToEmpty, 1)
require.NoError(t, dirsToEmpty[0].RemoveAll())
require.NoError(t, dirsToEmpty[0].MkdirAll())
_, stderr, err := cli.Run("board", "list")
require.NoError(t, err)
require.Contains(t, string(stderr), "builtin:serial-discovery")
}
func TestBoardListall(t *testing.T) { func TestBoardListall(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t) env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp() defer env.CleanUp()
...@@ -405,7 +381,7 @@ func TestBoardSearch(t *testing.T) { ...@@ -405,7 +381,7 @@ func TestBoardSearch(t *testing.T) {
// Verifies no board has FQBN set since no platform is installed // Verifies no board has FQBN set since no platform is installed
requirejson.Query(t, stdout, "[ .[] | select(.fqbn) ] | length", "0") requirejson.Query(t, stdout, "[ .[] | select(.fqbn) ] | length", "0")
requirejson.Contains(t, stdout, `[ requirejson.Contains(t, stdout, `[
{"name": "Arduino Uno"}, {"name": "Arduino UNO"},
{"name": "Arduino Yún"}, {"name": "Arduino Yún"},
{"name": "Arduino Zero"}, {"name": "Arduino Zero"},
{"name": "Arduino Nano 33 BLE"}, {"name": "Arduino Nano 33 BLE"},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment