Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
arduino-cli
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Operations
Operations
Metrics
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
xpstem
arduino-cli
Commits
982a2712
Commit
982a2712
authored
Jun 04, 2019
by
Cristian Maglie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Removed "flavour" option in 'board attach' command
parent
15bf593f
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
59 additions
and
73 deletions
+59
-73
cli/board/attach.go
cli/board/attach.go
+0
-4
rpc/board.pb.go
rpc/board.pb.go
+58
-67
rpc/board.proto
rpc/board.proto
+1
-2
No files found.
cli/board/attach.go
View file @
982a2712
...
...
@@ -39,15 +39,12 @@ func initAttachCommand() *cobra.Command {
Args
:
cobra
.
RangeArgs
(
1
,
2
),
Run
:
runAttachCommand
,
}
attachCommand
.
Flags
()
.
StringVar
(
&
attachFlags
.
boardFlavour
,
"flavour"
,
"default"
,
"The Name of the CPU flavour, it is required for some boards (e.g. Arduino Nano)."
)
attachCommand
.
Flags
()
.
StringVar
(
&
attachFlags
.
searchTimeout
,
"timeout"
,
"5s"
,
"The timeout of the search of connected devices, try to high it if your board is not found (e.g. to 10s)."
)
return
attachCommand
}
var
attachFlags
struct
{
boardFlavour
string
// The flavor of the chipset of the cpu of the connected board, if not specified it is set to "default".
searchTimeout
string
// Expressed in a parsable duration, is the timeout for the list and attach commands.
}
...
...
@@ -61,7 +58,6 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
Instance
:
instance
,
BoardUri
:
args
[
0
],
SketchPath
:
path
,
BoardFlavour
:
attachFlags
.
boardFlavour
,
SearchTimeout
:
attachFlags
.
searchTimeout
,
},
cli
.
OutputTaskProgress
())
if
err
!=
nil
{
...
...
rpc/board.pb.go
View file @
982a2712
This diff is collapsed.
Click to expand it.
rpc/board.proto
View file @
982a2712
...
...
@@ -56,8 +56,7 @@ message BoardAttachReq {
Instance
instance
=
1
;
string
board_uri
=
2
;
string
sketch_path
=
3
;
string
board_flavour
=
4
;
string
search_timeout
=
5
;
string
search_timeout
=
4
;
}
message
BoardAttachResp
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment