[BREAKING]: gRPC drop query field from LibrarySearchRequest (#2388)

commands/lib/search.go

@@ -40,10 +40,6 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchRequest) (*rpc.Lib
 func searchLibrary(req *rpc.LibrarySearchRequest, lm *librariesmanager.LibrariesManager) *rpc.LibrarySearchResponse {
 	res := []*rpc.SearchedLibrary{}
 	query := req.GetSearchArgs()
-	if query == "" {
-		query = req.GetQuery()
-	}
-
 	matcher := MatcherFromQueryString(query)
 
 	for _, lib := range lm.Index.Libraries {

docs/UPGRADING.md

@@ -4,6 +4,10 @@ Here you can find a list of migration guides to handle breaking changes between
 
 ## 0.36.0
 
+### gRPC `cc.arduino.cli.commands.v1.LibrarySearchRequest` message has been changed.
+
+The `query` field has been removed, use `search_args` instead.
+
 ### CLI `core list` and `core search` changed JSON output.
 
 Below is an example of the response containing an object with all possible keys set.

rpc/cc/arduino/cli/commands/v1/lib.proto

@@ -137,13 +137,11 @@ message LibraryDependencyStatus {
 message LibrarySearchRequest {
   // Arduino Core Service instance from the `Init` response.
   Instance instance = 1;
-  // Deprecated. Use search_args instead.
-  string query = 2 [ deprecated = true ];
   // Set to true to not populate the releases field in the response (may save a
   // lot of bandwidth/CPU).
-  bool omit_releases_details = 3;
+  bool omit_releases_details = 2;
   // Keywords for the search.
-  string search_args = 4;
+  string search_args = 3;
 }
 
 enum LibrarySearchStatus {