[skip-changelog] Migrate tests from `test_update.py` to `update_test.go` (#1933)

* Migrate TestUpdate from test_update.py to update_test.go

* Migrate TestUpdateShowingOutdated from test_update.py to update_test.go

* Migrate TestUpdateWithUrlNotFound from test_update.py to update_test.go

* Migrate TestUpdateWithUrlInternalServerError from test_update.py to update_test.go

* Migrate TestUpdateShowingOutdatedUsingLibraryWithInvalidVersion to update_test.go and delete test_update.py

internal/integrationtest/update/update_test.go

+// This file is part of arduino-cli.
+//
+// Copyright 2022 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to license@arduino.cc.
+
+package update_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/arduino/arduino-cli/internal/integrationtest"
+	"github.com/arduino/go-paths-helper"
+	"github.com/stretchr/testify/require"
+)
+
+func TestUpdate(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	stdout, _, err := cli.Run("update")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Downloading index: package_index.tar.bz2 downloaded")
+	require.Contains(t, string(stdout), "Downloading index: library_index.tar.bz2 downloaded")
+}
+
+func TestUpdateShowingOutdated(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Updates index for cores and libraries
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "update-index")
+	require.NoError(t, err)
+
+	// Installs an outdated core and library
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.6.3")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "USBHost@1.0.0")
+	require.NoError(t, err)
+
+	// Installs latest version of a core and a library
+	_, _, err = cli.Run("core", "install", "arduino:samd")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "ArduinoJson")
+	require.NoError(t, err)
+
+	// Verifies outdated cores and libraries are printed after updating indexes
+	stdout, _, err := cli.Run("update", "--show-outdated")
+	require.NoError(t, err)
+	lines := strings.Split(string(stdout), "\n")
+	for i := range lines {
+		lines[i] = strings.TrimSpace(lines[i])
+	}
+
+	require.Contains(t, lines[0], "Downloading index: package_index.tar.bz2 downloaded")
+	require.Contains(t, lines[1], "Downloading index: library_index.tar.bz2 downloaded")
+	require.True(t, strings.HasPrefix(lines[3], "Arduino AVR Boards"))
+	require.True(t, strings.HasPrefix(lines[6], "USBHost"))
+}
+
+func TestUpdateWithUrlNotFound(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Brings up a local server to fake a failure
+	url := env.HTTPServeFileError(8000, paths.New("test_index.json"), 404)
+
+	stdout, _, err := cli.Run("update", "--additional-urls="+url.String())
+	require.Error(t, err)
+	require.Contains(t, string(stdout), "Downloading index: test_index.json Server responded with: 404 Not Found")
+}
+
+func TestUpdateWithUrlInternalServerError(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Brings up a local server to fake a failure
+	url := env.HTTPServeFileError(8000, paths.New("test_index.json"), 500)
+
+	stdout, _, err := cli.Run("update", "--additional-urls="+url.String())
+	require.Error(t, err)
+	require.Contains(t, string(stdout), "Downloading index: test_index.json Server responded with: 500 Internal Server Error")
+}
+
+func TestUpdateShowingOutdatedUsingLibraryWithInvalidVersion(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install latest version of a library
+	_, _, err = cli.Run("lib", "install", "WiFi101")
+	require.NoError(t, err)
+
+	// Verifies library doesn't get updated
+	stdout, _, err := cli.Run("update", "--show-outdated")
+	require.NoError(t, err)
+	require.NotContains(t, string(stdout), "WiFi101")
+
+	// Changes the version of the currently installed library so that it's
+	// invalid
+	libPath := cli.SketchbookDir().Join("libraries", "WiFi101", "library.properties")
+	require.NoError(t, libPath.WriteFile([]byte("name=WiFi101\nversion=1.0001")))
+
+	// Verifies library gets updated
+	stdout, _, err = cli.Run("update", "--show-outdated")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "WiFi101")
+}

test/test_update.py

-# This file is part of arduino-cli.
-#
-# Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
-#
-# This software is released under the GNU General Public License version 3,
-# which covers the main part of arduino-cli.
-# The terms of this license can be found at:
-# https://www.gnu.org/licenses/gpl-3.0.en.html
-#
-# You can be released from the requirements of the above licenses by purchasing
-# a commercial license. Buying such a license is mandatory if you want to modify or
-# otherwise use the software for commercial activities involving the Arduino
-# software without disclosing the source code of your own applications. To purchase
-# a commercial license, send an email to license@arduino.cc.
-
-from pathlib import Path
-
-
-def test_update(run_command):
-    res = run_command(["update"])
-    assert res.ok
-    lines = [l.strip() for l in res.stdout.splitlines()]
-
-    assert "Downloading index: package_index.tar.bz2 downloaded" in lines
-    assert "Downloading index: library_index.tar.bz2 downloaded" in lines
-
-
-def test_update_showing_outdated(run_command):
-    # Updates index for cores and libraries
-    run_command(["core", "update-index"])
-    run_command(["lib", "update-index"])
-
-    # Installs an outdated core and library
-    run_command(["core", "install", "arduino:avr@1.6.3"])
-    assert run_command(["lib", "install", "USBHost@1.0.0"])
-
-    # Installs latest version of a core and a library
-    run_command(["core", "install", "arduino:samd"])
-    assert run_command(["lib", "install", "ArduinoJson"])
-
-    # Verifies outdated cores and libraries are printed after updating indexes
-    result = run_command(["update", "--show-outdated"])
-    assert result.ok
-    lines = [l.strip() for l in result.stdout.splitlines()]
-
-    assert "Downloading index: package_index.tar.bz2 downloaded" in lines
-    assert "Downloading index: library_index.tar.bz2 downloaded" in lines
-    assert lines[-5].startswith("Arduino AVR Boards")
-    assert lines[-2].startswith("USBHost")
-
-
-def test_update_with_url_not_found(run_command, httpserver):
-    assert run_command(["update"])
-
-    # Brings up a local server to fake a failure
-    httpserver.expect_request("/test_index.json").respond_with_data(status=404)
-    url = httpserver.url_for("/test_index.json")
-
-    res = run_command(["update", f"--additional-urls={url}"])
-    assert res.failed
-    lines = [l.strip() for l in res.stdout.splitlines()]
-    assert "Downloading index: test_index.json Server responded with: 404 NOT FOUND" in lines
-
-
-def test_update_with_url_internal_server_error(run_command, httpserver):
-    assert run_command(["update"])
-
-    # Brings up a local server to fake a failure
-    httpserver.expect_request("/test_index.json").respond_with_data(status=500)
-    url = httpserver.url_for("/test_index.json")
-
-    res = run_command(["update", f"--additional-urls={url}"])
-    assert res.failed
-    lines = [l.strip() for l in res.stdout.splitlines()]
-    assert "Downloading index: test_index.json Server responded with: 500 INTERNAL SERVER ERROR" in lines
-
-
-def test_update_showing_outdated_using_library_with_invalid_version(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Install latest version of a library
-    assert run_command(["lib", "install", "WiFi101"])
-
-    # Verifies library doesn't get updated
-    res = run_command(["update", "--show-outdated"])
-    assert res.ok
-    assert "WiFi101" not in res.stdout
-
-    # Changes the version of the currently installed library so that it's
-    # invalid
-    lib_path = Path(data_dir, "libraries", "WiFi101")
-    Path(lib_path, "library.properties").write_text("name=WiFi101\nversion=1.0001")
-
-    # Verifies library gets updated
-    res = run_command(["update", "--show-outdated"])
-    assert res.ok
-    assert "WiFi101" in res.stdout