• Umberto Baldi's avatar
    [breaking] Optimize `core` operations, improving on the user input (#1574) · e63c798c
    Umberto Baldi authored
    * [breaking] remove `parseArch` var since it is always true
    
    * [breaking] make packages and platform case insensitive
    using the `core.GetPlatform()` approach
    
    * enhance comments and do not optimize if results are != 1
    
    * add logging
    
    * add simple test, install, uninstall etc are already covered since they use the same piece of logic (`ParseReference()`)
    
    * Apply suggestions from code review
    Co-authored-by: default avatarper1234 <accounts@perglass.com>
    
    * add new error to handle multiple platform found, return res if the string the user is trying to operate matches perfectly one of the available platforms, optimize the code
    
    * enhance comment describing what the function does
    
    * add test to verify that an operation on two fake cores is not possible
    
    * skip test failing on macOS and on win and optimize the test
    Co-authored-by: default avatarper1234 <accounts@perglass.com>
    e63c798c
upgrade.go 3.46 KB