• Cristian Maglie's avatar
    [breaking] refactor: made some golang modules private (part 2) (#2455) · 0fc6575e
    Cristian Maglie authored
    * Made 'configuration' package internal
    
    * Made 'arduino' package internal
    
    * Moved errors in their own package
    
    * Moved directories init out of commands/internal/instances
    
    * Updated docs
    
    * Removed dep on pkg/errors library
    
    * Update easyjson task and generated files
    
    * Move the terminal detection subroutines in feedback package
    
    This also fix the linter errors:
    
    internal/cli/configuration/term.go:25:39: use of `os.Stdin` forbidden because "in cli package use `feedback.*` instead" (forbidigo)
    var IsInteractive = isatty.IsTerminal(os.Stdin.Fd()) || isatty.IsCygwinTerminal(os.Stdin.Fd())
                                          ^
    internal/cli/configuration/term.go:28:36: use of `os.Stdout` forbidden because "in cli package use `feedback.*` instead" (forbidigo)
    var HasConsole = isatty.IsTerminal(os.Stdout.Fd()) || isatty.IsCygwinTerminal(os.Stdout.Fd())
    
    * Fix linter warning
    
    * Fixed docs:include-configuration-json-schema task
    
    * Fixed build test for discovery_client
    0fc6575e
main.go 931 Bytes