Remove unused HelpService

Change-Id: I3f54c7c2f3db0cfd32b9646f0ca4849cabdd00c6

appinventor/appengine/src/com/google/appinventor/YaClient.gwt.xml

@@ -37,7 +37,6 @@
   <servlet path="/components" class="com.google.appinventor.server.ComponentServiceImpl" />
   <servlet path="/download" class="com.google.appinventor.server.DownloadServlet" />
   <servlet path="/getmotd" class="com.google.appinventor.server.GetMotdServiceImpl" />
-  <servlet path="/help" class="com.google.appinventor.server.HelpServiceImpl" />
   <servlet path="/projects" class="com.google.appinventor.server.ProjectServiceImpl" />
   <servlet path="/upload" class="com.google.appinventor.server.UploadServlet" />
   <servlet path="/userinfo" class="com.google.appinventor.server.UserInfoServiceImpl" />
@@ -83,7 +82,6 @@
   <source path="shared/youngandroid"/>
   <source path="shared/properties/json"/>
   <source path="shared/rpc/component"/>
-  <source path="shared/rpc/help"/>
   <source path="shared/rpc/launch"/>
   <source path="shared/rpc/project"/>
   <source path="shared/rpc/user"/>

appinventor/appengine/src/com/google/appinventor/client/Ode.java

@@ -68,8 +68,6 @@ import com.google.appinventor.shared.rpc.RpcResult;
 import com.google.appinventor.shared.rpc.ServerLayout;
 import com.google.appinventor.shared.rpc.admin.AdminInfoService;
 import com.google.appinventor.shared.rpc.admin.AdminInfoServiceAsync;
-import com.google.appinventor.shared.rpc.help.HelpService;
-import com.google.appinventor.shared.rpc.help.HelpServiceAsync;
 import com.google.appinventor.shared.rpc.project.FileNode;
 import com.google.appinventor.shared.rpc.project.GalleryAppListResult;
 import com.google.appinventor.shared.rpc.project.GalleryComment;
@@ -257,9 +255,6 @@ public class Ode implements EntryPoint {
   // initially, and will be hidden automatically after the first RPC completes.
   private static RpcStatusPopup rpcStatusPopup;
 
-  // Web service for help information
-  private final HelpServiceAsync helpService = GWT.create(HelpService.class);
-
   // Web service for project related information
   private final ProjectServiceAsync projectService = GWT.create(ProjectService.class);
 
@@ -997,7 +992,6 @@ public class Ode implements EntryPoint {
     rpcStatusPopup = new RpcStatusPopup();
 
     // Register services with RPC status popup
-    rpcStatusPopup.register((ExtendedServiceProxy<?>) helpService);
     rpcStatusPopup.register((ExtendedServiceProxy<?>) projectService);
     rpcStatusPopup.register((ExtendedServiceProxy<?>) galleryService);
     rpcStatusPopup.register((ExtendedServiceProxy<?>) userInfoService);
@@ -1427,15 +1421,6 @@ public class Ode implements EntryPoint {
     return adminInfoService;
   }
 
-  /**
-   * Get an instance of the help web service.
-   *
-   * @return help service instance
-   */
-  public HelpServiceAsync getHelpService() {
-    return helpService;
-  }
-
   /**
    * Get an instance of the component web service.
    *
@@ -1687,7 +1672,6 @@ public class Ode implements EntryPoint {
     }
 
     // Unregister services with RPC status popup.
-    rpcStatusPopup.unregister((ExtendedServiceProxy<?>) helpService);
     rpcStatusPopup.unregister((ExtendedServiceProxy<?>) projectService);
     rpcStatusPopup.unregister((ExtendedServiceProxy<?>) userInfoService);
 

appinventor/appengine/src/com/google/appinventor/server/HelpServiceImpl.java

-// -*- mode: java; c-basic-offset: 2; -*-
-// Copyright 2009-2011 Google, All Rights reserved
-// Copyright 2011-2012 MIT, All rights reserved
-// Released under the Apache License, Version 2.0
-// http://www.apache.org/licenses/LICENSE-2.0
-
-package com.google.appinventor.server;
-
-
-import com.google.appinventor.shared.rpc.help.HelpService;
-
-/**
- * Implementation of the help service.
- *
- * <p>The help service also provides information.
- *
- */
-public class HelpServiceImpl extends OdeRemoteServiceServlet implements HelpService {
-
-  private static final long serialVersionUID = -73163124332949366L;
-
-  @Override
-  public boolean isProductionServer() {
-    return Server.isProductionServer();
-  }
-}

appinventor/appengine/src/com/google/appinventor/shared/rpc/ServerLayout.java

@@ -69,13 +69,6 @@ public class ServerLayout {
    */
   public static final String ANDROID_SERVLET = "android";
 
-  /**
-   * Relative path of the
-   * {@link com.google.appinventor.shared.rpc.help.HelpService} within the
-   * ODE GWT module.
-   */
-  public static final String HELP_SERVICE = "help";
-
   /**
    * Relative path of the
    * {@link com.google.appinventor.shared.rpc.user.UserInfoService} within the

appinventor/appengine/src/com/google/appinventor/shared/rpc/help/HelpService.java

-// -*- mode: java; c-basic-offset: 2; -*-
-// Copyright 2009-2011 Google, All Rights reserved
-// Copyright 2011-2012 MIT, All rights reserved
-// Released under the Apache License, Version 2.0
-// http://www.apache.org/licenses/LICENSE-2.0
-
-package com.google.appinventor.shared.rpc.help;
-
-import com.google.appinventor.shared.rpc.ServerLayout;
-import com.google.gwt.user.client.rpc.RemoteService;
-import com.google.gwt.user.client.rpc.RemoteServiceRelativePath;
-
-/**
- * Interface for the service providing help information.
- *
- */
-@RemoteServiceRelativePath(ServerLayout.HELP_SERVICE)
-public interface HelpService extends RemoteService {
-
-  /**
-   * Returns true if this server instance is running on app engine production
-   * @return is production server running
-   */
-  boolean isProductionServer();
-}

appinventor/appengine/src/com/google/appinventor/shared/rpc/help/HelpServiceAsync.java

-// -*- mode: java; c-basic-offset: 2; -*-
-// Copyright 2009-2011 Google, All Rights reserved
-// Copyright 2011-2012 MIT, All rights reserved
-// Released under the Apache License, Version 2.0
-// http://www.apache.org/licenses/LICENSE-2.0
-
-package com.google.appinventor.shared.rpc.help;
-
-import com.google.gwt.user.client.rpc.AsyncCallback;
-
-/**
- * Interface for the service providing help information. All
- * declarations in this interface are mirrored in {@link HelpService}.
- * For further information see {@link HelpService}.
- *
- */
-public interface HelpServiceAsync {
-
-  /**
-   * @see HelpService#isProductionServer()
-   */
-  void isProductionServer(AsyncCallback<Boolean> callback);
-}

appinventor/appengine/war/WEB-INF/web.xml

@@ -156,16 +156,6 @@
     <servlet-name>getMotdService</servlet-name>
   </filter-mapping>
 
-  <!-- help -->
-  <servlet>
-    <servlet-name>helpService</servlet-name>
-    <servlet-class>com.google.appinventor.server.HelpServiceImpl</servlet-class>
-  </servlet>
-  <servlet-mapping>
-    <servlet-name>helpService</servlet-name>
-    <url-pattern>/ode/help</url-pattern>
-  </servlet-mapping>
-
   <!-- projects -->
   <servlet>
     <servlet-name>projectService</servlet-name>