Fix buggy ask for write permissions when not in REPL (#1579)

Change-Id: I4a4b0af5365581cf4663f66181991ca3c747146e

Fix buggy ask for write permissions when not in REPL (#1579)
Change-Id: I4a4b0af5365581cf4663f66181991ca3c747146e
c98261fe · Evan W. Patton · Jeffrey Schiller · d75ffca7 · c98261fe
Commit c98261fe authored Mar 01, 2019 by Evan W. Patton Committed by Jeffrey Schiller Mar 01, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

appinventor/components/src/com/google/appinventor/components/runtime/Form.java ...s/src/com/google/appinventor/components/runtime/Form.java +2 -2

No files found.
--- a/appinventor/components/src/com/google/appinventor/components/runtime/Form.java
+++ b/appinventor/components/src/com/google/appinventor/components/runtime/Form.java
@@ -360,8 +360,8 @@ public class Form extends AppInventorCompatActivity
    // process (onCreateFinish2). Sigh.

    boolean needSdcardWrite = doesAppDeclarePermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) &&
-        // Don't ask permission if we are REPL and using the splash screen
-        !(isRepl() && AppInventorFeatures.doCompanionSplashScreen());
+        // Only ask permission if we are in the REPL and not using the splash screen
+        isRepl() && !AppInventorFeatures.doCompanionSplashScreen();
    if (needSdcardWrite) {
      askPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE,
        new PermissionResultHandler() {