Added new ShowFeedback SimpleProperty (default true). This allows user

to specify if they want visual feedback to be shown for a button that
has an image.

Change-Id: I57371642955c025b24f47ad2dc07684556381bcd

appinventor/appengine/src/com/google/appinventor/client/youngandroid/YoungAndroidFormUpgrader.java

@@ -471,6 +471,11 @@ public final class YoungAndroidFormUpgrader {
       // No properties need to be modified to upgrade to version 4.
       srcCompVersion = 4;
     }
+    if (srcCompVersion < 5) {
+      // The ShowFeedback property was added.
+      // No properties need to be modified to upgrade to version 5.
+      srcCompVersion = 5;
+    }
     return srcCompVersion;
   }
 

appinventor/blockslib/src/openblocks/yacodeblocks/BlockSaveFile.java

@@ -668,6 +668,12 @@ public class BlockSaveFile {
       // No blocks need to be modified to upgrade to version 4.
       blkCompVersion = 4;
     }
+    if (blkCompVersion < 5) {
+      // The ShowFeedback property was added.
+      // No properties need to be modified to upgrade to version 5.
+      blkCompVersion = 5;
+    }
+
     return blkCompVersion;
   }
 

appinventor/components/src/com/google/appinventor/components/common/YaVersion.java

@@ -215,8 +215,9 @@ public class YaVersion {
   // - NOTIFIER_COMPONENT_VERSION was incremented to 2.
   // For YOUNG_ANDROID_VERSION 72:
   // - WEBVIEWER_COMPONENT_VERSION was incremented to 3
-
-  public static final int YOUNG_ANDROID_VERSION = 72;
+  // For YOUNG_ANDROID_VERSION 73:
+  // - BUTTON_COMPONENT_VERSION was incremented to 5.
+  public static final int YOUNG_ANDROID_VERSION = 73;
 
   // ............................... Blocks Language Version Number ...............................
 
@@ -341,7 +342,9 @@ public class YaVersion {
   // - The LongClick event was added.
   // For BUTTON_COMPONENT_VERSION 4:
   // - The Shape property was added.
-  public static final int BUTTON_COMPONENT_VERSION = 4;
+  // For BUTTON_COMPONENT_VERSION 5:
+  // - The ShowFeedback property was added.
+  public static final int BUTTON_COMPONENT_VERSION = 5;
 
   public static final int CAMCORDER_COMPONENT_VERSION = 1;
 

appinventor/components/src/com/google/appinventor/components/runtime/ButtonBase.java

@@ -68,6 +68,9 @@ public abstract class ButtonBase extends AndroidViewComponent
   // Backing for font bold
   private boolean bold;
 
+  // Used for determining if visual feedback should be provided for buttons that have images
+  private boolean showFeedback=true;
+
   // Backing for font italic
   private boolean italic;
 
@@ -142,6 +145,10 @@ public abstract class ButtonBase extends AndroidViewComponent
         //NOTE: We ALWAYS return false because we want to indicate that this listener has not
         //been consumed. Using this approach, other listeners (e.g. OnClick) can process as normal.
 
+        //If user has disabled the visual feedback, then don't even proceed any further
+        if (!ShowFeedback()) {
+            return false;
+        }
         //If regular button with no background image or default shape,
         // then we use the normal button visual feedback.
         boolean shouldOverlay=true;
@@ -166,12 +173,13 @@ public abstract class ButtonBase extends AndroidViewComponent
         if (me.getAction() == MotionEvent.ACTION_DOWN) {
             //button pressed, provide visual feedback AND return false
             view.getBackground().setAlpha(70); // translucent
+            view.invalidate();
 
         } else if (me.getAction() == MotionEvent.ACTION_UP ||
             me.getAction() == MotionEvent.ACTION_CANCEL) {
             //button released, set button back to normal AND return false
             view.getBackground().setAlpha(255); // opaque
-            return false;
+            view.invalidate();
         }
 
         return false;
@@ -455,6 +463,37 @@ public abstract class ButtonBase extends AndroidViewComponent
   }
 
   /**
+   * Specifies if a visual feedback should be shown when a button with an assigned image
+   * is pressed.
+   *
+   * @param showFeedback  {@code true} enables showing feedback,
+   *                 {@code false} disables it
+   */
+  @DesignerProperty(editorType = PropertyTypeConstants.PROPERTY_TYPE_BOOLEAN,
+          defaultValue = "True")
+  @SimpleProperty(description = "Specifies if a visual feedback should be shown " +
+          " for a button that as an image as background.")
+
+  public void ShowFeedback(boolean showFeedback) {
+    this.showFeedback =showFeedback;
+  }
+
+    /**
+     * Returns true if the button's text should be bold.
+     * If bold has been requested, this property will return true, even if the
+     * font does not support bold.
+     *
+     * @return {@code true} indicates visual feedback will be shown,
+     *                 {@code false} visual feedback will not be shown
+     */
+    @SimpleProperty(
+            category = PropertyCategory.APPEARANCE,
+            description = "Returns the button's visual feedback state")
+    public boolean ShowFeedback() {
+        return showFeedback;
+    }
+
+    /**
    * Returns true if the button's text should be italic.
    * If italic has been requested, this property will return true, even if the
    * font does not support italic.