Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
ArduinoCore-avr
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
xpstem
ArduinoCore-avr
Commits
ffeca151
Unverified
Commit
ffeca151
authored
Sep 16, 2019
by
Alexander Entinger
Committed by
GitHub
Sep 16, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #95 from jrowberg/master
Cast pins to signed integers to avoid Wtype-limits compile warning
parents
cc8daac4
c270eaab
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
cores/arduino/WString.cpp
cores/arduino/WString.cpp
+1
-1
libraries/SoftwareSerial/src/SoftwareSerial.cpp
libraries/SoftwareSerial/src/SoftwareSerial.cpp
+2
-2
No files found.
cores/arduino/WString.cpp
View file @
ffeca151
...
...
@@ -121,7 +121,7 @@ String::String(double value, unsigned char decimalPlaces)
String
::~
String
()
{
free
(
buffer
);
if
(
buffer
)
free
(
buffer
);
}
/*********************************************/
...
...
libraries/SoftwareSerial/src/SoftwareSerial.cpp
View file @
ffeca151
...
...
@@ -316,7 +316,7 @@ void SoftwareSerial::begin(long speed)
_tx_delay
=
subtract_cap
(
bit_delay
,
15
/
4
);
// Only setup rx when we have a valid PCINT for this pin
if
(
digitalPinToPCICR
(
_receivePin
))
{
if
(
digitalPinToPCICR
(
(
int8_t
)
_receivePin
))
{
#if GCC_VERSION > 40800
// Timings counted from gcc 4.8.2 output. This works up to 115200 on
// 16Mhz and 57600 on 8Mhz.
...
...
@@ -357,7 +357,7 @@ void SoftwareSerial::begin(long speed)
// Enable the PCINT for the entire port here, but never disable it
// (others might also need it, so we disable the interrupt by using
// the per-pin PCMSK register).
*
digitalPinToPCICR
(
_receivePin
)
|=
_BV
(
digitalPinToPCICRbit
(
_receivePin
));
*
digitalPinToPCICR
(
(
int8_t
)
_receivePin
)
|=
_BV
(
digitalPinToPCICRbit
(
_receivePin
));
// Precalculate the pcint mask register and value, so setRxIntMask
// can be used inside the ISR without costing too much time.
_pcint_maskreg
=
digitalPinToPCMSK
(
_receivePin
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment