Merge pull request #82 from luco5826/master

Minor optimization in shiftOut function

Merge pull request #82 from luco5826/master
Minor optimization in shiftOut function
3883e49b · Alexander Entinger · GitHub · ffeca151 · 4d074e8a · 3883e49b
Unverified Commit 3883e49b authored Sep 16, 2019 by Alexander Entinger Committed by GitHub Sep 16, 2019
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

cores/arduino/wiring_shift.c cores/arduino/wiring_shift.c +7 -4

No files found.
--- a/cores/arduino/wiring_shift.c
+++ b/cores/arduino/wiring_shift.c
@@ -42,10 +42,13 @@ void shiftOut(uint8_t dataPin, uint8_t clockPin, uint8_t bitOrder, uint8_t val)
 	uint8_t i;
 	for (i = 0; i < 8; i++)  {
-		if (bitOrder == LSBFIRST)
+		if (bitOrder == LSBFIRST) {
-			digitalWrite(dataPin, !!(val & (1 << i)));
+			digitalWrite(dataPin, val & 1);
-		else	
+			val >>= 1;
-			digitalWrite(dataPin, !!(val & (1 << (7 - i))));
+		} else {	
+			digitalWrite(dataPin, (val & 128) != 0);
+			val <<= 1;
+		}
 		digitalWrite(clockPin, HIGH);
 		digitalWrite(clockPin, LOW);