Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
S
scratch-www
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
xpstem
scratch-www
Commits
ff3c91f9
Unverified
Commit
ff3c91f9
authored
Aug 19, 2019
by
Benjamin Wheeler
Committed by
GitHub
Aug 19, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #3186 from benjiwheeler/join-flow-add-images
Join flow add images
parents
4a01fabf
1803641a
Changes
11
Hide whitespace changes
Inline
Side-by-side
Showing
11 changed files
with
18 additions
and
10 deletions
+18
-10
src/components/join-flow/birthdate-step.jsx
src/components/join-flow/birthdate-step.jsx
+1
-1
src/components/join-flow/country-step.jsx
src/components/join-flow/country-step.jsx
+1
-1
src/components/join-flow/email-step.jsx
src/components/join-flow/email-step.jsx
+1
-1
src/components/join-flow/join-flow-step.jsx
src/components/join-flow/join-flow-step.jsx
+5
-2
src/components/join-flow/join-flow-step.scss
src/components/join-flow/join-flow-step.scss
+7
-2
src/components/join-flow/welcome-step.jsx
src/components/join-flow/welcome-step.jsx
+1
-1
static/images/join-flow/birthdate-header.png
static/images/join-flow/birthdate-header.png
+0
-0
static/images/join-flow/country-header.png
static/images/join-flow/country-header.png
+0
-0
static/images/join-flow/email-header.png
static/images/join-flow/email-header.png
+0
-0
static/images/join-flow/welcome-header.png
static/images/join-flow/welcome-header.png
+0
-0
test/unit/components/join-flow-step.test.jsx
test/unit/components/join-flow-step.test.jsx
+2
-2
No files found.
src/components/join-flow/birthdate-step.jsx
View file @
ff3c91f9
...
...
@@ -87,7 +87,7 @@ class BirthDateStep extends React.Component {
return
(
<
JoinFlowStep
description=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.private
'
})
}
headerImgSrc=
"/images/
hoc/getting-started.jp
g"
headerImgSrc=
"/images/
join-flow/birthdate-header.pn
g"
infoMessage=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.birthDateStepInfo
'
})
}
innerClassName=
"join-flow-inner-birthdate-step"
title=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.birthDateStepTitle
'
})
}
...
...
src/components/join-flow/country-step.jsx
View file @
ff3c91f9
...
...
@@ -68,7 +68,7 @@ class CountryStep extends React.Component {
return
(
<
JoinFlowStep
description=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.countryStepDescription
'
})
}
headerImgSrc=
"/images/
hoc/getting-started.jp
g"
headerImgSrc=
"/images/
join-flow/country-header.pn
g"
innerClassName=
"join-flow-inner-country-step"
title=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.countryStepTitle
'
})
}
waiting=
{
isSubmitting
}
...
...
src/components/join-flow/email-step.jsx
View file @
ff3c91f9
...
...
@@ -74,7 +74,7 @@ class EmailStep extends React.Component {
}
}
/>
)
}
headerImgSrc=
"/images/
hoc/getting-started.jp
g"
headerImgSrc=
"/images/
join-flow/email-header.pn
g"
innerClassName=
"join-flow-inner-email-step"
nextButton=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.createAccount
'
})
}
title=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.emailStepTitle
'
})
}
...
...
src/components/join-flow/join-flow-step.jsx
View file @
ff3c91f9
...
...
@@ -25,8 +25,11 @@ const JoinFlowStep = ({
<
form
onSubmit=
{
onSubmit
}
>
<
div
className=
"join-flow-outer-content"
>
{
headerImgSrc
&&
(
<
div
className=
"join-flow-header-image"
>
<
img
src=
{
headerImgSrc
}
/>
<
div
className=
"join-flow-header-image-wrapper"
>
<
img
className=
"join-flow-header-image"
src=
{
headerImgSrc
}
/>
</
div
>
)
}
<
div
>
...
...
src/components/join-flow/join-flow-step.scss
View file @
ff3c91f9
...
...
@@ -33,15 +33,20 @@
}
/* overflow will only work if this class is set on parent of img, not img itself */
.join-flow-header-image
{
.join-flow-header-image
-wrapper
{
width
:
100%
;
height
:
7
.5rem
;
min-height
:
7
.5rem
;
max-height
:
8
.75rem
;
overflow
:
hidden
;
margin
:
0
;
border-top-left-radius
:
1rem
;
border-top-right-radius
:
1rem
;
}
.join-flow-header-image
{
width
:
27
.5rem
;
}
.join-flow-footer-message
{
width
:
100%
;
padding
:
1
.125rem
1
.5rem
1
.125rem
;
...
...
src/components/join-flow/welcome-step.jsx
View file @
ff3c91f9
...
...
@@ -44,7 +44,7 @@ class WelcomeStep extends React.Component {
description=
{
this
.
props
.
intl
.
formatMessage
({
id
:
'
registration.welcomeStepDescriptionNonEducator
'
})
}
headerImgSrc=
"/images/
hoc/getting-started.jp
g"
headerImgSrc=
"/images/
join-flow/welcome-header.pn
g"
innerClassName=
"join-flow-inner-welcome-step"
nextButton=
{
<
React
.
Fragment
>
...
...
static/images/join-flow/birthdate-header.png
0 → 100644
View file @
ff3c91f9
31.8 KB
static/images/join-flow/country-header.png
0 → 100644
View file @
ff3c91f9
14.9 KB
static/images/join-flow/email-header.png
0 → 100644
View file @
ff3c91f9
20.1 KB
static/images/join-flow/welcome-header.png
0 → 100644
View file @
ff3c91f9
22 KB
test/unit/components/join-flow-step.test.jsx
View file @
ff3c91f9
...
...
@@ -20,7 +20,7 @@ describe('JoinFlowStep', () => {
{
...
props
}
/>
);
expect
(
component
.
find
(
'
div
.join-flow-header-image
'
).
exists
()).
toEqual
(
true
);
expect
(
component
.
find
(
'
img
.join-flow-header-image
'
).
exists
()).
toEqual
(
true
);
expect
(
component
.
find
({
src
:
props
.
headerImgSrc
}).
exists
()).
toEqual
(
true
);
expect
(
component
.
find
(
'
.join-flow-inner-content
'
).
exists
()).
toEqual
(
true
);
expect
(
component
.
find
(
'
.join-flow-title
'
).
exists
()).
toEqual
(
true
);
...
...
@@ -39,7 +39,7 @@ describe('JoinFlowStep', () => {
<
JoinFlowStep
/>
);
expect
(
component
.
find
(
'
div
.join-flow-header-image
'
).
exists
()).
toEqual
(
false
);
expect
(
component
.
find
(
'
img
.join-flow-header-image
'
).
exists
()).
toEqual
(
false
);
expect
(
component
.
find
(
'
.join-flow-inner-content
'
).
exists
()).
toEqual
(
true
);
expect
(
component
.
find
(
'
.join-flow-title
'
).
exists
()).
toEqual
(
false
);
expect
(
component
.
find
(
'
div.join-flow-description
'
).
exists
()).
toEqual
(
false
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment