Unverified Commit 8b222f04 authored by Benjamin Wheeler's avatar Benjamin Wheeler Committed by GitHub

fix base modal prop passed to ReactModal (#2165)

parent 69299d3e
......@@ -26,7 +26,11 @@ class Modal extends React.Component {
return (
<ReactModal
appElement={document.getElementById('app')}
bodyOpenClassName={this.props.useStandardSizes ? classNames('overflow-hidden') : null}
// bodyOpenClassName can be blank string, but must not be null here; a null value causes
// an error, because ReactModal does not correctly handle the case of a null bodyOpenClassName
bodyOpenClassName={classNames({
'overflow-hidden': this.props.useStandardSizes
})}
className={{
base: classNames('modal-content', this.props.className, {
'modal-sizes': this.props.useStandardSizes
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment