circleci config move environment variables to contexts

.circleci/config.yml

@@ -8,46 +8,44 @@ aliases:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_PASSWORD
     working_directory: ~/repo
-  - &environment
-    CXX: g++-4.8
-    FASTLY_ACTIVATE_CHANGES: true
-    NODE_ENV: production
-    S3_LOCAL_DIR: build
-    SENTRY_ORG: scratch-foundation
-    SKIP_CLEANUP: true
+  # - &environment
+    # CXX: g++-4.8
+    # FASTLY_ACTIVATE_CHANGES: true
+    # NODE_ENV: production
+    # S3_LOCAL_DIR: build
+    # SENTRY_ORG: scratch-foundation
+    # SKIP_CLEANUP: true
     # WWW_VERSION: ${CIRCLE_SHA1:0:5}
-  - &env_production
-    API_HOST: https://api.scratch.mit.edu
-    ASSET_HOST: https://assets.scratch.mit.edu
-    BACKPACK_HOST: https://backpack.scratch.mit.edu
-    CLOUDDATA_HOST: clouddata.scratch.mit.edu
-    FASTLY_API_KEY: ${FASTLY_API_KEY_PRODUCTION}
-    FASTLY_SERVICE_ID: ${FASTLY_SERVICE_ID_PRODUCTION}
-    GA_TRACKER: UA-30688952-1
-    PROJECT_HOST: https://projects.scratch.mit.edu
-    RECAPTCHA_SITE_KEY: 6LeRbUwUAAAAAFYhKgk3G9OKWqE_OJ7Z-7VTUCbl
-    ROOT_URL: https://scratch.mit.edu
-    S3_BUCKET_NAME: scratch-www-production
-    SCRATCH_ENV: production
-    SENTRY_DSN: https://ebc2f8a6bc7b44ca8fd902fd4f16b3d7@sentry.io/1357122
-    SENTRY_PROJECT: scratch-30-production
-    STATIC_HOST: https://cdn2.scratch.mit.edu
-    TEST_PROJECT_ID: "414835599"
-  - &env_staging
-    API_HOST: https://api.scratch.ly
-    ASSET_HOST: https://assets.scratch.ly
-    BACKPACK_HOST: https://backpack.scratch.ly
-    CLOUDDATA_HOST: varserver2.scratch.ly
-    GA_TRACKER: UA-30688952-7
-    PROJECT_HOST: https://projects.scratch.ly
-    RECAPTCHA_SITE_KEY: 6LfukK4UAAAAAFR44yoZMhv8fj6xh-PMiIxwryG3
-    ROOT_URL: https://scratch.ly
-    S3_BUCKET_NAME: scratch-www-staging
-    SCRATCH_ENV: staging
-    SENTRY_DSN: https://c01014988b0a4f44bbefdf235623c456@sentry.io/1357982
-    SENTRY_PROJECT: scratch-30-staging
-    STATIC_HOST: https://cdn.scratch.ly
-    TEST_PROJECT_ID: "1300006196"
+  # - &env_production
+    # API_HOST: https://api.scratch.mit.edu
+    # ASSET_HOST: https://assets.scratch.mit.edu
+    # BACKPACK_HOST: https://backpack.scratch.mit.edu
+    # CLOUDDATA_HOST: clouddata.scratch.mit.edu
+    # GA_TRACKER: UA-30688952-1
+    # PROJECT_HOST: https://projects.scratch.mit.edu
+    # RECAPTCHA_SITE_KEY: 6LeRbUwUAAAAAFYhKgk3G9OKWqE_OJ7Z-7VTUCbl
+    # ROOT_URL: https://scratch.mit.edu
+    # S3_BUCKET_NAME: scratch-www-production
+    # SCRATCH_ENV: production
+    # SENTRY_DSN: https://ebc2f8a6bc7b44ca8fd902fd4f16b3d7@sentry.io/1357122
+    # SENTRY_PROJECT: scratch-30-production
+    # STATIC_HOST: https://cdn2.scratch.mit.edu
+    # TEST_PROJECT_ID: "414835599"
+  # - &env_staging
+    # API_HOST: https://api.scratch.ly
+    # ASSET_HOST: https://assets.scratch.ly
+    # BACKPACK_HOST: https://backpack.scratch.ly
+    # CLOUDDATA_HOST: varserver2.scratch.ly
+    # GA_TRACKER: UA-30688952-7
+    # PROJECT_HOST: https://projects.scratch.ly
+    # RECAPTCHA_SITE_KEY: 6LfukK4UAAAAAFR44yoZMhv8fj6xh-PMiIxwryG3
+    # ROOT_URL: https://scratch.ly
+    # S3_BUCKET_NAME: scratch-www-staging
+    # SCRATCH_ENV: staging
+    # SENTRY_DSN: https://c01014988b0a4f44bbefdf235623c456@sentry.io/1357982
+    # SENTRY_PROJECT: scratch-30-staging
+    # STATIC_HOST: https://cdn.scratch.ly
+    # TEST_PROJECT_ID: "1300006196"
   - &save_git_cache
     save_cache:
       paths:
@@ -79,13 +77,8 @@ aliases:
       keys:
         - v1-build-{{ .Revision }}
         - v1-build-
-
-jobs:
-  build-staging:
+  - &build
     <<: *defaults
-    environment:
-      <<: *environment
-      <<: *env_staging
     steps:
       - *restore_git_cache
       - checkout
@@ -98,28 +91,8 @@ jobs:
       - *save_npm_cache
       - *save_git_cache
       - *save_build_cache
-  build-production:
-    <<: *defaults
-    environment:
-      <<: *environment
-      # <<: *env_production
-    steps:
-      - *restore_git_cache
-      - checkout
-      - *restore_npm_cache
-      - run:
-          name: "Run npm test to build"
-          command: |
-            npm --production=false ci
-            WWW_VERSION=${CIRCLE_SHA1:0:5} npm run test npm run test
-      - *save_npm_cache
-      - *save_git_cache
-      - *save_build_cache
-  deploy-staging:
+  - &deploy
     <<: *defaults
-    environment:
-      <<: *environment
-      <<: *env_staging
     steps:
       - *restore_git_cache
       - checkout
@@ -128,33 +101,12 @@ jobs:
       - run:
           name: "deploy to staging"
           command: |
-            curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
-            python get-pip.py
-            pip install -r requirements.txt
-            FASTLY_API_KEY="${FASTLY_API_KEY_STAGING}" FASTLY_SERVICE_ID="${FASTLY_SERVICE_ID_STAGING}" npm run deploy
-  deploy-production:
-    <<: *defaults
-    environment:
-      <<: *environment
-      # <<: *env_production
-    steps:
-      - *restore_git_cache
-      - checkout
-      - *restore_npm_cache
-      - *restore_build_cache
-      - run:
-          name: "deploy to production"
-          command: |
-            echo "don't deploy to production until we know it works"
             curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
             python get-pip.py
             pip install -r requirements.txt
             npm run deploy
-  integration-staging:
+  - &integration
     <<: *defaults
-    environment:
-      <<: *environment
-      <<: *env_staging
     steps:
       - *restore_git_cache
       - checkout
@@ -163,24 +115,29 @@ jobs:
           name: "integration tests"
           command: |
             npm run test:integration:remote
+
+
+jobs:
+  build-staging:
+    <<: *build
+  build-production:
+    # <<: *build
+  deploy-staging:
+    <<: *deploy
+  deploy-production:
+    # <<: *deploy
+  integration-staging:
+    <<: *integration
   integration-production:
-    <<: *defaults
-    environment:
-      <<: *environment
-      # <<: *env_production
-    steps:
-      - *restore_git_cache
-      - checkout
-      - *restore_npm_cache
-      - run:
-          name: "integration tests"
-          command: |
-            npm run test:integration:remote
+    # <<: *integration
 
 workflows:
   build-test-deploy:
     jobs:
       - build-staging:
+          context:
+            - scratch-www-all
+            - scratch-www-staging
           filters:
             branches:
               only:
@@ -189,6 +146,9 @@ workflows:
                 - /^hotfix\/.*/
                 - /^release\/.*/
       - deploy-staging:
+          context:
+            - scratch-www-all
+            - scratch-www-staging
           requires:
             - build-staging
           filters:
@@ -199,6 +159,9 @@ workflows:
                 - /^hotfix\/.*/ # make sure this syntax works.  may need a regex
                 - /^release\/.*/
       - integration-staging:
+          context:
+            - scratch-www-all
+            - scratch-www-staging
           requires:
             - deploy-staging
           filters: