1. 20 Dec, 2017 2 commits
  2. 20 Nov, 2017 1 commit
  3. 19 Nov, 2017 1 commit
  4. 15 Nov, 2017 1 commit
  5. 14 Nov, 2017 2 commits
    • ColinTree's avatar
      Permit sub-directories in extensions · ccd4bc04
      ColinTree authored
      Permit sub-packages stored in sub-directories in extensions. Before this
      change sub-packages were mistakenly placed in the main package’s
      directory, resulting in a non-functional situation
      
      Fixes #962
      
      Change-Id: I8797cdca8fb98485264d7f691b5f90eb83f20fd6
      ccd4bc04
    • Evan W. Patton's avatar
      Add WorkspaceMove event for undoing viewport moves · c0374682
      Evan W. Patton authored
      We added a mechanism that moves the workspace when highlighting a
      procedure definition block. However, we do not provide a mechanism to
      go back to the original viewport position prior to the move. This
      commit adds a WorkspaceMove event that is recorded when the workspace
      is shifted and can be undo via the normal undo/redo stack to return
      the user from where they came in the workspace.
      
      Note this is not robust to changes in the viewport size between
      operations.
      
      Change-Id: I09f1af2f3d7db62af0f1487a90a56a66f99273bc
      c0374682
  6. 11 Nov, 2017 6 commits
    • Evan W. Patton's avatar
      Prevent error checking on block during drag · 7f5bcb65
      Evan W. Patton authored
      There was a visual glitch when dragging variable getters into sockets
      due to the error icon appearing and shifting the block visually from
      the coordinate Blockly maintained as the drag position. This resulted
      in the connection highlight and checking algorithms to not fire when
      the blocks were visually aligned but rather when the internal states
      were visually aligned. This commit prevents checking a block for
      errors if the block is being dragged. After the drag is complete, a
      Move event will be triggered and the workspaceChanged listener will
      perform an error check at the time the block is dropped. This prevents
      an error icon from causing the aforementioned glitch.
      
      Fixes #971
      
      Change-Id: I225dac2a278b58dae9e520747a9f2c69c96bf109
      7f5bcb65
    • Evan W. Patton's avatar
      Scroll to highlighted procedure · f5fdcd0e
      Evan W. Patton authored
      Previously the blocks editor would only highlight a procedure block
      when the "Highlight Definition" context menu item was chosen. This
      version will also scroll the workspace so that the definition block is
      visually centered in the workspace when possible, with a constraint
      that the top-left coordinate must appear on the screen.
      
      Fixes #984
      
      Change-Id: If8c06825b285ad7008cbf6f7e7948392be12c0c0
      f5fdcd0e
    • Evan W. Patton's avatar
      Fix component methods in typeblocking · 54565cde
      Evan W. Patton authored
      Fixes #995
      
      Change-Id: Icc3c90f9b5d18925031e1183d84ca84310208e7b
      54565cde
    • Evan W. Patton's avatar
      Bypass Closure's SafeHtml for HTML known to be safe · e2b5693d
      Evan W. Patton authored
      When we updated the Closure Compiler for the Blockly update, some
      strings containing HTML were escaped unnecessarily. These strings are
      part of internationalization, and so they will be code reviewed before
      acceptance into the code base. We therefore break the SafeHtml
      contract imposed by Google Closure Library and manipulate the content
      element directly so that the static HTML content is preserved.
      
      Fixes #985
      
      Change-Id: I8a545d46aceedcb8039f194ce03a86d924ab0867
      e2b5693d
    • Evan W. Patton's avatar
      Fix extension upgrade issues · 157e5944
      Evan W. Patton authored
      An interaction between an upgrading an extension with a new version
      number and a change to YaVersion results in being unable to open a
      project with extensions. This fix does two things to address this:
      
      1. Force a save of the project so that the version numbers of the
      extension are persisted back to the server.
      2. Check whether a component to be upgraded is an external component,
      and if so, skip the upgrade step since we don't have an upgrader for
      it anyway.
      
      Fixes #996
      
      Change-Id: I6d39f70b3cac80961ed538f5a2bd99ab81729a5e
      157e5944
    • Evan W. Patton's avatar
      Add "Extension Version" field to help widget · 494ca7d1
      Evan W. Patton authored
      Assisting users with extensions is difficult because it is unclear
      whether problems occur because of bugs in the extension or due to a
      mismatch in versions when extensions work together. This commit adds
      an "Extension Version" header on the helper widget that displays the
      version number specified in the @DesignerComponent annotation if the
      version number is greater than 0.
      
      Closes #894
      
      Change-Id: If7fdd49795e81f8ff784036ce5745de499aafbd9
      494ca7d1
  7. 27 Oct, 2017 2 commits
    • Evan W. Patton's avatar
      Make if block mutator robust to undo/redo operations · 00be41cd
      Evan W. Patton authored
      This commit reconciles our implementation of the `if` block with the
      implementation in Blockly. In particular, our implementation only
      works under the assumption that the user is making changes via the
      mutator and causes graphical problems when the undo/redo feature in
      Blockly is used. The Blockly version correctly handles undo/redo, but
      the mutator is slightly different in its implementation. This change
      maintains our visual presentation of the mutator but uses the Blockly
      logic for updating.
      
      Fixes #973
      
      Change-Id: Ib335d4cd7f132f8bf21f9c691ee7a7e53f28e674
      00be41cd
    • Conor's avatar
      Update reference materials with new logo (#966) · 6deba8bc
      Conor authored
      I have updated all of the reference documentation pages to use the new
      MIT AI logo.
      
      Fixes #932
      6deba8bc
  8. 24 Oct, 2017 1 commit
  9. 23 Oct, 2017 1 commit
  10. 22 Oct, 2017 1 commit
    • Evan W. Patton's avatar
      Update block tooltips when property selection changed · e2d49de6
      Evan W. Patton authored
      Prior to this commit, changing the target property in a getter/setter
      block would not update the tooltip of the block to match the new
      property. This commit updates the tooltip in response to the dropdown
      selection changing.
      
      Fixes #964
      
      Change-Id: I7ab095699f533fd262f2dc69cbae515e96163b8f
      e2d49de6
  11. 16 Oct, 2017 2 commits
    • Jeffrey I. Schiller's avatar
      Add Flag to enable AcceleratormeterSensor change · fef99674
      Jeffrey I. Schiller authored
      The previous commit adds support for the AccelerometerSensor to
      compensate for default landscape tablets. This change adds a flag that
      can be used (in branding branches) to disable this change at compile
      time.
      
      Change-Id: I6a98d2c7e2fdfab06ac5b40c9f9641acdd836be8
      fef99674
    • hal's avatar
      Support default landscape tablets · 0f01fbe5
      hal authored
      Change the accelerometer so that Xaccel and Yaccel behave on
      LandscapePrimary devices the same way as they do on PortraitPrimary
      devices.  If you hold the device vetically (long edge vertical) then
      xAccel should be 0 and yAccel should be -9.  Rotate 90 degree
      counterclock wise and xAccel,Yaccel should be 9,0.  This should be true
      on both PortraitPrimary and LandscapePrimary devices.
      
      Change-Id: I2537be388a7c77fee0a7f85bff98abe217546c80
      0f01fbe5
  12. 13 Oct, 2017 1 commit
    • Jeffrey I. Schiller's avatar
      ActionBar: Work with older Companion · 0a51d0f9
      Jeffrey I. Schiller authored
      Do not store the ActionBar property if it is set to its default value,
      which is “False.” This permits the Pre-ActionBar aware Companion to work
      with projects, as long as the ActionBar property is left unchecked.
      
      Change-Id: I3afaa761e66d7eecc5eb5ed79d9d6d7aa86835f3
      0a51d0f9
  13. 11 Oct, 2017 1 commit
    • Evan W. Patton's avatar
      Reduce number of companion updates · 51cafd67
      Evan W. Patton authored
      Opening and closing a mutator or clicking a block would result in the
      blocks code being resent to the companion because any workspace event
      would force a YAIL update. This change adds a isUi method to check
      whether a Blockly event is a UI event, which doesn't change the
      semantics of the program, and ignores such events for the purpose of
      updating the companion.
      
      Change-Id: Id80d1d094e585cc7182fe3987f8e0adc2b45b872
      51cafd67
  14. 10 Oct, 2017 1 commit
    • Evan W. Patton's avatar
      Defer update of warning indicator until workspace rendered · bd9758c1
      Evan W. Patton authored
      Warning indicator counters were 0 even if there were warnings in the
      workspace. This was due to a combination of optimizations where the
      warnings aren't computed if the workspace isn't rendered and the
      indicator isn't created until the first rendering pass. This means
      that when the indicator is rendered it has not been updated with the
      results of any error checking passes have been made.
      
      Fixes #953
      
      Change-Id: I5641c6444efeab9228efca5a74a78ed3a4577484
      bd9758c1
  15. 06 Oct, 2017 2 commits
  16. 03 Oct, 2017 1 commit
  17. 28 Sep, 2017 1 commit
    • Evan W. Patton's avatar
      Fix bugs related to ActionBar · f53b1656
      Evan W. Patton authored
      This commit fixes two bugs:
      
      1. NPE due to a race condition where clear() was called in the
         ReplForm before the FrameLayout was initialized.
      2. setImageTintMode on an internal Widget wasn't supported on
         Android 4.x, resulting in a crash on connection.
      
      Change-Id: Ia28f9eaa404fa0b8f830d5a809d77226a611b36c
      f53b1656
  18. 24 Sep, 2017 1 commit
    • Jeffrey I. Schiller's avatar
      Fix button height when font size is changed · cbb7ed03
      Jeffrey I. Schiller authored
      Make sure the button in the designer scales along with the font size.
      
      This change is a simplification of work originally done by Olivier Midy
      <osmidy@mit.edu>.
      
      Change-Id: Iad2033001f26b102506f8bba2dff89f94f6b8ab6
      cbb7ed03
  19. 22 Sep, 2017 3 commits
    • Evan W. Patton's avatar
      Use immediately deferred timer for MockForm refresh · 2fbb4bdb
      Evan W. Patton authored
      Large projects demonstrated that an O(n^2) behavior for the MockForm
      refresh function caused significant slowdown when loading and
      rendering large projects in the designer. Jeff originally fixed this
      by introducing a timer so that at least 2 seconds were provided
      between refresh calls. However, this introduces some visual glitches
      when components are dragged or immediately after project load due to
      the fact that up to two seconds must elapse before the component sizes
      are updated.
      
      This commit uses a timer that immediately fires after the current
      JavaScript execution context finishes so that changes to the form and
      its components takes effect immediately on the next render pass. To
      prevent O(n^2) behavior, only one timer is scheduled at any one point,
      and the timer is only cleared after the refresh pass has completed.
      
      Change-Id: I7c43ec19b6aad2d8fa6de2d5cdbf9913dec44abf
      2fbb4bdb
    • Evan W. Patton's avatar
      Fix project switching when connected to REPL · aef02557
      Evan W. Patton authored
      The Blockly update broke how the REPL interacted with App Inventor
      when switching between projects after connecting. This change ensures
      that pollYail is called when a workspace is made active so that the
      screen will be updated accordingly.
      
      Change-Id: I3b10365e59d247590a7f5f9e522a450b7ad2ab4b
      aef02557
    • Evan W. Patton's avatar
      Store block positions during upgrades · 853908e0
      Evan W. Patton authored
      Blocks workspace upgraders sometimes operate on the workspace in XML
      form rather than workspace form. When we did the Blockly update in May
      2017, we moved updating the positions of blocks to occur immediately
      before the first render of the workspace rather than at workspace load
      time. This results in all blocks being at 0, 0 if the project relied
      on a component where the upgrader used XML because the blocks do not
      get positioned until after the upgrade has run.
      
      This code wraps the blockToDOMWithXY function to update the position
      of the block during serialization to XML if rendering is turned off,
      i.e. we are loading the workspace.
      
      Fixes #920
      
      Change-Id: Ie19cbe4207e6c36979c2adb767748bb54def4551
      853908e0
  20. 18 Sep, 2017 1 commit
    • Jeffrey I. Schiller's avatar
      Make sure /about and /static are served · 2da38fa8
      Jeffrey I. Schiller authored
      App Engine may soon require that static content be declared static in
      appengine-web.xml. This change makes sure these directories, which hold
      the “Terms of Service” among other things, are properly declared.
      
      Change-Id: Id7409362e96a731cec75bd6cbbe3de376bf2beec
      2da38fa8
  21. 12 Sep, 2017 2 commits
    • Evan W. Patton's avatar
      Enable any Component type to be used as a parameter · 4b9aad2a
      Evan W. Patton authored
      The component processor only allows concrete types to be specified as
      Java method parameters and return values. However, for abstraction it
      is sometimes useful to use an interface or abstract base class in
      order to reduce repeat code. This commit updates ComponentProcessor to
      use the class hierarchy of any parameter or return type of a property,
      method, or event to determine whether an entity passed through would
      be a Component.
      
      Change-Id: Ie2487ed20ad1b4ca6e8acc08ca8102cb6b7eb258
      4b9aad2a
    • Evan W. Patton's avatar
      Add is-text? block to test for whether a value is a string · 746343f3
      Evan W. Patton authored
      Change-Id: Ib30e302ecf5f19970532bab66e409e50aed08b40
      746343f3
  22. 08 Sep, 2017 1 commit
    • Evan W. Patton's avatar
      Add support for app themes · 6e23c47c
      Evan W. Patton authored
      With the addition of the Android support libraries we can now allow
      users to change the theme and colors of their apps globally. This
      commit adds a handful of properties to accomplish and give rough
      approximations of the theme in both the web environment and
      companion. Some colors cannot be changed at runtime so the only way to
      see the results is to compile an app.
      
      Change-Id: Iba0be346f1824445ab4edcdca37dd384abd42850
      6e23c47c
  23. 01 Sep, 2017 2 commits
    • Evan W. Patton's avatar
      Add support for 32-bit color palette picker · ecb66599
      Evan W. Patton authored
      This commit adds a Custom... menu item to color pickers to allow users
      more customizability in their user interfaces. This was originally
      part of the Maps commit, but has been broken out to a separate commit
      since it also supports customizing theme colors with Material UI.
      
      Change-Id: Iea5ec183a086d8541f81e1c8280c45b48c12d17f
      ecb66599
    • Evan W. Patton's avatar
      Add support for Android Archive (AAR) libraries · 6d1548a8
      Evan W. Patton authored
      To support newer features of Android devices, such as the action bar
      and new UI themes, this commit adds support for compiling App Inventor
      apps with the Android Archives (AAR).
      
      Change-Id: I6e51b07f6ff3a5516ea5b945b39c9260f6fd5423
      6d1548a8
  24. 31 Aug, 2017 1 commit
  25. 28 Aug, 2017 2 commits
    • Jeffrey I. Schiller's avatar
      Display the Login page instead of empty dialog · 896ae5ef
      Jeffrey I. Schiller authored
      During development it is common to erase the local development datastore
      and start over. However if the browser in use still had a valid
      authentication cookie (very common), a blank dialog would be displayed
      because the cookie resolved to a non-existent account. This change
      results instead with either the login page, or Google authentication
      being invoked (depending on configuration). Note: This code should *not*
      get triggered in production.
      
      Change-Id: Iafbc7c774c392d99073342c49108dc6774e715a0
      896ae5ef
    • Evan W. Patton's avatar
      Enable \t as valid escape sequence in blocks language · dfe67162
      Evan W. Patton authored
      Change-Id: I0d0b6cdb0dc8b5e7360616a75d96cb18391eb8ae
      dfe67162