GitLab

Closes #1038
Fixes #1037 

This commit makes our TitleVisible property changes affect title bar's
visibility in the designer as well as on any connected device.

Change-Id: I64ab6917761fe627fc6565be784ad78a3bfdcbd9

Fixes #1002

Change-Id: If3e9612736cf8b827d47b6738a4d979fd0aaff3e

Permit sub-packages stored in sub-directories in extensions. Before this
change sub-packages were mistakenly placed in the main package’s
directory, resulting in a non-functional situation

Fixes #962

Change-Id: I8797cdca8fb98485264d7f691b5f90eb83f20fd6

We added a mechanism that moves the workspace when highlighting a
procedure definition block. However, we do not provide a mechanism to
go back to the original viewport position prior to the move. This
commit adds a WorkspaceMove event that is recorded when the workspace
is shifted and can be undo via the normal undo/redo stack to return
the user from where they came in the workspace.

Note this is not robust to changes in the viewport size between
operations.

Change-Id: I09f1af2f3d7db62af0f1487a90a56a66f99273bc

There was a visual glitch when dragging variable getters into sockets
due to the error icon appearing and shifting the block visually from
the coordinate Blockly maintained as the drag position. This resulted
in the connection highlight and checking algorithms to not fire when
the blocks were visually aligned but rather when the internal states
were visually aligned. This commit prevents checking a block for
errors if the block is being dragged. After the drag is complete, a
Move event will be triggered and the workspaceChanged listener will
perform an error check at the time the block is dropped. This prevents
an error icon from causing the aforementioned glitch.

Fixes #971

Change-Id: I225dac2a278b58dae9e520747a9f2c69c96bf109

Previously the blocks editor would only highlight a procedure block
when the "Highlight Definition" context menu item was chosen. This
version will also scroll the workspace so that the definition block is
visually centered in the workspace when possible, with a constraint
that the top-left coordinate must appear on the screen.

Fixes #984

Change-Id: If8c06825b285ad7008cbf6f7e7948392be12c0c0

Fixes #995

Change-Id: Icc3c90f9b5d18925031e1183d84ca84310208e7b

When we updated the Closure Compiler for the Blockly update, some
strings containing HTML were escaped unnecessarily. These strings are
part of internationalization, and so they will be code reviewed before
acceptance into the code base. We therefore break the SafeHtml
contract imposed by Google Closure Library and manipulate the content
element directly so that the static HTML content is preserved.

Fixes #985

Change-Id: I8a545d46aceedcb8039f194ce03a86d924ab0867

An interaction between an upgrading an extension with a new version
number and a change to YaVersion results in being unable to open a
project with extensions. This fix does two things to address this:

1. Force a save of the project so that the version numbers of the
extension are persisted back to the server.
2. Check whether a component to be upgraded is an external component,
and if so, skip the upgrade step since we don't have an upgrader for
it anyway.

Fixes #996

Change-Id: I6d39f70b3cac80961ed538f5a2bd99ab81729a5e

Assisting users with extensions is difficult because it is unclear
whether problems occur because of bugs in the extension or due to a
mismatch in versions when extensions work together. This commit adds
an "Extension Version" header on the helper widget that displays the
version number specified in the @DesignerComponent annotation if the
version number is greater than 0.

Closes #894

Change-Id: If7fdd49795e81f8ff784036ce5745de499aafbd9

This commit reconciles our implementation of the `if` block with the
implementation in Blockly. In particular, our implementation only
works under the assumption that the user is making changes via the
mutator and causes graphical problems when the undo/redo feature in
Blockly is used. The Blockly version correctly handles undo/redo, but
the mutator is slightly different in its implementation. This change
maintains our visual presentation of the mutator but uses the Blockly
logic for updating.

Fixes #973

Change-Id: Ib335d4cd7f132f8bf21f9c691ee7a7e53f28e674

I have updated all of the reference documentation pages to use the new
MIT AI logo.

Fixes #932

Fixes #959

Change-Id: I07a51181269adfd79b8db11a40cec66dc43a4ed9

Prior to this commit, changing the target property in a getter/setter
block would not update the tooltip of the block to match the new
property. This commit updates the tooltip in response to the dropdown
selection changing.

Fixes #964

Change-Id: I7ab095699f533fd262f2dc69cbae515e96163b8f

Opening and closing a mutator or clicking a block would result in the
blocks code being resent to the companion because any workspace event
would force a YAIL update. This change adds a isUi method to check
whether a Blockly event is a UI event, which doesn't change the
semantics of the program, and ignores such events for the purpose of
updating the companion.

Change-Id: Id80d1d094e585cc7182fe3987f8e0adc2b45b872

Warning indicator counters were 0 even if there were warnings in the
workspace. This was due to a combination of optimizations where the
warnings aren't computed if the workspace isn't rendered and the
indicator isn't created until the first rendering pass. This means
that when the indicator is rendered it has not been updated with the
results of any error checking passes have been made.

Fixes #953

Change-Id: I5641c6444efeab9228efca5a74a78ed3a4577484

Fixes #944

Change-Id: I9fbb8d8a5d2c546ad44ab639f21a165fd7194d1e

When upgrading a project, do not attempt to save the upgraded version if
we are in read only mode.

Change-Id: I7e2f089293ae864dbe1a18c2504ac71d1b51fc9d

Make sure the button in the designer scales along with the font size.

This change is a simplification of work originally done by Olivier Midy
<osmidy@mit.edu>.

Change-Id: Iad2033001f26b102506f8bba2dff89f94f6b8ab6

Large projects demonstrated that an O(n^2) behavior for the MockForm
refresh function caused significant slowdown when loading and
rendering large projects in the designer. Jeff originally fixed this
by introducing a timer so that at least 2 seconds were provided
between refresh calls. However, this introduces some visual glitches
when components are dragged or immediately after project load due to
the fact that up to two seconds must elapse before the component sizes
are updated.

This commit uses a timer that immediately fires after the current
JavaScript execution context finishes so that changes to the form and
its components takes effect immediately on the next render pass. To
prevent O(n^2) behavior, only one timer is scheduled at any one point,
and the timer is only cleared after the refresh pass has completed.

Change-Id: I7c43ec19b6aad2d8fa6de2d5cdbf9913dec44abf

The Blockly update broke how the REPL interacted with App Inventor
when switching between projects after connecting. This change ensures
that pollYail is called when a workspace is made active so that the
screen will be updated accordingly.

Change-Id: I3b10365e59d247590a7f5f9e522a450b7ad2ab4b

Blocks workspace upgraders sometimes operate on the workspace in XML
form rather than workspace form. When we did the Blockly update in May
2017, we moved updating the positions of blocks to occur immediately
before the first render of the workspace rather than at workspace load
time. This results in all blocks being at 0, 0 if the project relied
on a component where the upgrader used XML because the blocks do not
get positioned until after the upgrade has run.

This code wraps the blockToDOMWithXY function to update the position
of the block during serialization to XML if rendering is turned off,
i.e. we are loading the workspace.

Fixes #920

Change-Id: Ie19cbe4207e6c36979c2adb767748bb54def4551

App Engine may soon require that static content be declared static in
appengine-web.xml. This change makes sure these directories, which hold
the “Terms of Service” among other things, are properly declared.

Change-Id: Id7409362e96a731cec75bd6cbbe3de376bf2beec

During development it is common to erase the local development datastore
and start over. However if the browser in use still had a valid
authentication cookie (very common), a blank dialog would be displayed
because the cookie resolved to a non-existent account. This change
results instead with either the login page, or Google authentication
being invoked (depending on configuration). Note: This code should *not*
get triggered in production.

Change-Id: Iafbc7c774c392d99073342c49108dc6774e715a0

Change-Id: I0d0b6cdb0dc8b5e7360616a75d96cb18391eb8ae

Fixes build issues on Windows where the default charset isn't UTF-8.

Change-Id: I22f583eda2f000ef1dd82a672b5a0de6a4b9e7cb

Close #852

Change-Id: I99e8fea50b5d0632bb935183fe90c9a1b2c7bdd4

Includes the favicon.ico as well as the logo

Change-Id: Ie05bd5e3a6a3f072c81c91d11aee60b52fe9905c

A user reported an issue with a project where connecting the companion
caused the ReplMgr to go into an infinite loop. The issue was due to a
combination of setter block having an empty socket (triggering an
error resulting in the slow path) and the fact that there were more
than 20 top-level blocks in the project. After testing the first 20
blocks it would attempt the fast path, which would retrigger the slow
path, ad infinitum.

This commit updates the countdown in the slow path to use the number
of top-level blocks in the workspace rather than hard-coding 20
checks.

Fixes #887

Change-Id: Ie15b0f35cd145ecc0b789707f032eca6c179d107

Prior to the IOT release, extensions were packaged using the FQCN of
the extension inside of the AIX file. To faciltate being able to
contain multiple extension components in a single package, we switched
to using the package name rather than the FQCN. This causes backward
compatibility issues for extension developers who released extensions
prior to the update.

This commit adds a extensions.packagefqcn property to ant that can be
set to true by developers supporting older extensions so that the
internals of the extension package reflect the older layout. It is
recommended that all new extensions be built with the default (false)
to benefit from the new layout.

Change-Id: Idd9134c7d4d7c19f9a8869e4f88e164e2efa5cc8

ClientJsonParser was calling a GWT API that used eval() to parse JSON
content rather than JSON.parse(). A maliciously crafted project
containing an extension components.json file with Javascript instead
of JSON would allow injecting arbitrary Javascript into the user's
session. This commit switches to strict parsing and includes exception
handling to report corrupt/invalid components.json to the user.

Change-Id: Iafaaf004310ac45cf0c1cea18eae1cfd58de17ef

If a project contained multiple extensions sharing the same package
name, deleting one extension would also remove the other extensions
sharing that package name. This generally shouldn't happen going
forward because extension bundles automatically group extensions by
package name (which is why this logic is in place), but it didn't
handle the case where old extensions were in the same package.

This commit groups extensions by the components.json file that defines
them, and only deletes those extensions that are siblings by the
components.json file, rather than blanket-deleting extensions solely
by package name.

Fixes #910

Change-Id: I26a5db29a3919033fd50f2a2d65c6f805513ae2c

Replace the default App Logo with our new Bee based version.

Change-Id: Ibfaa3792bf29d799b253b261cd83b26e187eaa18

Change-Id: I16d609f13d7818a03f4de13761aaca3d1f5c40b2

Change-Id: Ic5f5d83e40051cfd62504196bd71f9a9781b521f

Taifun reported that importing many extensions of the same package
name into a single project made them unable to load. This change
detects this scenario and returns an error to the user preventing them
from loading the conflicting extension. There is also a test to ensure
that if one has two extensions in the same package and then loads a
bundle containing the individually FQCN extensions the old extensions
will be removed and placed with the bundled version.

Change-Id: If35663d650d3a24f6c5aaeceaf490a24ac008522