Fix button height when font size is changed

Make sure the button in the designer scales along with the font size.

This change is a simplification of work originally done by Olivier Midy
<osmidy@mit.edu>.

Change-Id: Iad2033001f26b102506f8bba2dff89f94f6b8ab6
parent 2fbb4bdb
...@@ -255,13 +255,17 @@ public final class MockComponentsUtil { ...@@ -255,13 +255,17 @@ public final class MockComponentsUtil {
Element element = w.getElement(); Element element = w.getElement();
String widthStyle = DOM.getStyleAttribute(element, "width"); String widthStyle = DOM.getStyleAttribute(element, "width");
String heightStyle = DOM.getStyleAttribute(element, "height"); String heightStyle = DOM.getStyleAttribute(element, "height");
String lineHeightStyle = DOM.getStyleAttribute(element, "line-height");
if (widthStyle != null) { if (widthStyle != null) {
DOM.setStyleAttribute(element, "width", null); DOM.setStyleAttribute(element, "width", null);
} }
if (heightStyle != null) { if (heightStyle != null) {
DOM.setStyleAttribute(element, "height", null); DOM.setStyleAttribute(element, "height", null);
} }
return new String[] { widthStyle, heightStyle }; if (lineHeightStyle != null) {
DOM.setStyleAttribute(element, "line-height", "initial");
}
return new String[] { widthStyle, heightStyle, lineHeightStyle };
} }
/* /*
...@@ -279,6 +283,9 @@ public final class MockComponentsUtil { ...@@ -279,6 +283,9 @@ public final class MockComponentsUtil {
if (style[1] != null) { if (style[1] != null) {
DOM.setStyleAttribute(element, "height", style[1]); DOM.setStyleAttribute(element, "height", style[1]);
} }
if (style[2] != null) {
DOM.setStyleAttribute(element, "line-height", style[2]);
}
} }
/** /**
...@@ -321,7 +328,10 @@ public final class MockComponentsUtil { ...@@ -321,7 +328,10 @@ public final class MockComponentsUtil {
String[] style = clearSizeStyle(w); String[] style = clearSizeStyle(w);
int width = w.getOffsetWidth() + 4; int width = w.getOffsetWidth() + 4;
int height = w.getOffsetHeight(); int height = w.getOffsetHeight() + 6;
if (height < 26) { // Do not make the button smaller
height = 26; // then 26, as this mimicks what happens
} // on the real device
restoreSizeStyle(w, style); restoreSizeStyle(w, style);
// Detach the widget from the DOM before returning // Detach the widget from the DOM before returning
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment